On Wed, Aug 21, 2019 at 02:26:18AM -0700, Greg KH wrote:
> On Tue, Aug 20, 2019 at 09:12:51PM -0700, Edmund Huber wrote:
> > My apologies. Is it possible that you are replying to a different thread
> > than intended? I don't think I have an email addressed to me from the
> > patchbot.
>
> I got a
On Wed, Aug 21, 2019 at 10:31:22AM +0800, Gao Xiang wrote:
> On Tue, Aug 20, 2019 at 07:26:46PM -0700, Joe Perches wrote:
> > On Tue, 2019-08-20 at 20:18 -0400, Caitlyn wrote:
> > > Balanced braces to fix some checkpath warnings in inode.c and
> > > unzip_vle.c
> > []
> > > diff --git a/drivers/sta
On Sun, Sep 01, 2019 at 05:30:23AM +0530, Amit Kumar wrote:
> Hi,
> I think now your tutorial should be ready.
I do not understand what this means sorry. Is it a request for action?
The tutorial was a couple of weeks ago now, here is a link to the
material if that is what you were asking
https:
On Mon, Sep 02, 2019 at 10:08:54AM -0400, Valdis Klētnieks wrote:
> On Mon, 02 Sep 2019 15:42:19 +0300, Anatoly Pugachev said:
>
> > is it intentionally that you use
> >
> > yes "" | make oldconfig
> >
> > instead of
> >
> > make olddefconfig
>
> They do something different. 'olddefconfig' just
Hi,
I am doing a tutorial at OSSNA in San Diego on getting into kernel
hacking. I'm only a couple of years deep into kernel hacking so I
wanted to reach out to those more experienced than myself (and those
less experienced).
Is there any thing that you would really like to see covered in this
tu
On Fri, Jul 05, 2019 at 10:40:43AM +0530, Amit Kumar wrote:
> On Fri, Jul 5, 2019 at 9:02 AM Amit Kumar wrote:
> >
> > On Fri, Jul 5, 2019 at 8:21 AM Tobin C. Harding wrote:
> > >
> > > Hi,
> > >
> > > I am doing a tutorial at OSSNA in San Dieg
On Fri, Jul 19, 2019 at 12:36:58PM +0300, Dan Carpenter wrote:
> On Fri, Jul 05, 2019 at 12:50:55PM +1000, Tobin C. Harding wrote:
> > Outcome will (hopefully) be a small patch set into drivers/staging/.
> > (Don't worry Greg only one group got to this stage last time, you
&
The kernel would like to have all stack VLA usage removed[1]. The
arrays are fixed here (declared with a const variable) but they appear
like VLAs to the compiler. We can use a pre-processor define to fix the
warning.
[1]: https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Tobin C. Harding
On Thu, Mar 08, 2018 at 10:01:07PM -0800, Joe Perches wrote:
> On Fri, 2018-03-09 at 16:50 +1100, Tobin C. Harding wrote:
> > The kernel would like to have all stack VLA usage removed[1]. The
> > arrays are fixed here (declared with a const variable) but they appear
> > like
The kernel would like to have all stack VLA usage removed[1]. The
array here is fixed (declared with a const variable) but it appears
like VLA to the compiler. We can use a pre-processor define to quiet
the compiler.
[1]: https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Tobin C. Harding
On Fri, Mar 09, 2018 at 12:16:21AM -0600, Gustavo A. R. Silva wrote:
>
> I sent a patch for this six hours ago:
>
> https://patchwork.kernel.org/patch/10268591/
>
> --
> Gustavo
lol, I knew there would be a race on to fix these :) And you got it
right, bonus points. Let's drop this one then.
, let's just allocate the memory instead of using the
stack. This saves stack space and removes the VLA build warning.
kmalloc a buffer for dumping state instead of using the stack.
[1]: https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Tobin C. Harding
---
v1 of this patch already merged
On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote:
> The kernel would like to have all stack VLA usage removed[1]. The array
> here is fixed (declared with a const variable) but it appears like a VLA
> to the compiler. Also, currently we are putting 768 bytes on the
>
On Mon, Mar 12, 2018 at 06:58:04AM +0100, Stefan Wahren wrote:
> Hi Tobin,
>
> > "Tobin C. Harding" hat am 12. März 2018 um 06:46
> > geschrieben:
> >
> >
> > On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote:
> > > The
ack. So save stack space and removes the VLA build warning by
> making it static.
>
> [1]: https://lkml.org/lkml/2018/3/7/621
>
> CC: Tobin C. Harding
> Signed-off-by: Stefan Wahren
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_arm.c| 20
> ++
Checkpatch emits multiple warnings of type
CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
Fix parenthesis alignment in line with checkpatch suggestion.
---
drivers/staging/rtlwifi/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/stagi
Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the
driver. Both functions call rtl_addr_delay(), this function is unused
outside of these call sites.The driver (and kernel) code base is cleaner
if unused functions are removed.
Remove unused functions.
---
drivers/staging/rtlwifi
checkpatch emits multiple warnings of type
WARNING:ALLOC_WITH_MULTIPLY: Prefer kcalloc over kzalloc with multiply
Replace two calls to kzalloc() with calls to kcalloc().
---
drivers/staging/rtlwifi/efuse.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/r
.
Tobin C. Harding (3):
staging: rtlwifi: fix parenthesis alignment
staging: rtlwifi: use kcalloc instead of multiply
staging: rtlwifi: remove unused functions
drivers/staging/rtlwifi/core.c | 43 +++--
drivers/staging/rtlwifi/core.h | 4
drivers
On Tue, Sep 05, 2017 at 09:46:55AM -0500, Larry Finger wrote:
> On 09/05/2017 01:53 AM, Tobin C. Harding wrote:
> >Functions rtl_rfreg_delay() and rtl_bb_delay() are unused within the
> >driver. Both functions call rtl_addr_delay(), this function is unused
> >outside of these
On Wed, Sep 13, 2017 at 04:14:29PM +0100, Liam Ryan wrote:
> On Wed, Sep 13, 2017 at 08:47:39AM +0200, Frans Klaver wrote:
> > On Tue, Sep 12, 2017 at 2:40 AM, Liam Ryan wrote:
> > > Fix checkpath-reported unbalanced braces in the following areas
> > >
> > > 221: FILE: drivers/staging/rtl8712/hal_
Good work getting this set submitted.
On Thu, Sep 14, 2017 at 12:05:18PM -0700, Valentine Sinitsyn wrote:
> This improves spelling in the comment line to make things easier to get
> for future rtl8188eu developers.
>
> Fixes: ee5f8a431ea (staging: rtl8188eu: Move all efuse related code to
> rtw_e
On Thu, Sep 14, 2017 at 12:05:17PM -0700, Valentine Sinitsyn wrote:
> There are some fixes for typos we discovered in rtl8188eu staging driver
> as a part of our Open Source Summit North America 2017 tutorial session.
>
> Valentine Sinitsyn (3):
> staging: rtl8188eu: Fix a typo ("deflaut")
> s
> Improve this by fixing typos so they won't catch eyes of future driver
> developers anymore.
This would be better in imperative mood i.e "Fix typos so they won't catch the
eyes of future
developers."
> Signed-off-by: Wolfgang Hartmann
> Signed-off-by: Manis
Hi Shreeya,
We don't usually add a period to the subject line for kernel patches. (reason:
we only have about
52 characters for the commit brief description so best not to waste any).
On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote:
> This patch removes unnecessary comments which a
On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote:
> Replaces instances of container_of with list_entry to
> access current list element.
>
> Srishti Sharma (6):
> Staging: rtl8188eu: core: Use list_entry instead of container_of
> Staging: rtl8188eu: core: Use list_entry instead
On Sat, Sep 30, 2017 at 07:41:11PM +0530, Shreeya Patel wrote:
> Remove unnecessary comments which are there
> to explain why call to memset is in comments. Both of the
> comments are not needed as they are not very useful.
>
>
> Signed-off-by: Shreeya Patel
> ---
> Changes in v2:
> -Remove so
On Sun, Oct 01, 2017 at 03:30:38PM -0400, Jérémy Lefaure wrote:
> Hi everyone,
> Using ARRAY_SIZE improves the code readability. I used coccinelle (I
> made a change to the array_size.cocci file [1]) to find several places
> where ARRAY_SIZE could be used instead of other macros or sizeof
> divisio
On Tue, Oct 10, 2017 at 02:48:58AM +0530, Shreeya Patel wrote:
> Remove NULL pointer dereference as it results in undefined
> behaviour, and will usually lead to a runtime error.
The diff does not show any pointer dereference so it is hard to understand what
you are trying to do
with this patch.
Hi Branislav,
On Tue, Oct 10, 2017 at 03:29:19PM +0200, Branislav Radocaj wrote:
> This is a patch to the radio-bcm2048.c file that fixes up
> a warning found by the checkpatch.pl tool.
>
> Signed-off-by: Branislav Radocaj
Nice work, a few git log nit picks for you to ensure your future kernel
On Wed, Oct 11, 2017 at 06:02:47PM +0530, Shreeya Patel wrote:
> On Tue, 2017-10-10 at 11:06 +1100, Tobin C. Harding wrote:
> > On Tue, Oct 10, 2017 at 02:48:58AM +0530, Shreeya Patel wrote:
> > >
> > > Remove NULL pointer dereference as it results in undefined
> &
On Mon, Oct 16, 2017 at 02:34:48PM +0200, Hans de Goede wrote:
> The common-clk core expects clk consumers to always call enable/disable
> in a balanced manner. The atomisp driver does not call gmin_flisclk_ctrl()
> in a balanced manner, so add a clock_on bool and skip redundant calls.
>
> This fi
On Mon, Oct 16, 2017 at 03:38:11PM +0530, suni...@techveda.org wrote:
> From: Suniel Mahesh
>
> Bool tests don't need comparisons.
This commit log could be a bit longer. You may like to read
Documentation/process/submitting-patches.rst (section 2).
> This fixes the following coccinelle warning:
On Mon, Oct 16, 2017 at 03:39:57PM +0530, suni...@techveda.org wrote:
> From: Suniel Mahesh
>
> This fixes the following coccinelle warning:
> WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
Perhaps
Coccinelle emits WARNING: return of 0/1 in function 'ssi_is_hw_key' wi
On Wed, Oct 18, 2017 at 07:40:14AM +0530, suni...@techveda.org wrote:
> From: Suniel Mahesh
>
> Comparision operator "equal to" not required on a variable
> "foo" of type "bool". Bool has only two values, can be used
> directly or with logical not.
>
> This fixes the following coccinelle warning
On Wed, Oct 18, 2017 at 07:42:53AM +0530, suni...@techveda.org wrote:
> From: Suniel Mahesh
>
> Return "false" instead of 0.
>
> This fixes the following coccinelle warning:
> WARNING: return of 0/1 in function 'ssi_is_hw_key' with return type bool.
So close! The order of problem description and
*tfm)
> {
> - return 0;
> + return false;
> }
>
> #endif /* CRYPTO_TFM_REQ_HW_KEY */
> --
> 1.9.1
>
For what it's worth, Reviewed-by: Tobin C. Harding
As stated I am being particularly 'nit picky', the commit log is _probably_
good enough to
On Wed, Oct 18, 2017 at 11:48:21AM -0400, Frank A. Cancio Bello wrote:
> Remove unnecessary parentheses to comply with preferred coding style for
> the linux kernel and avoid the following checkpatch's messages:
> 'CHECK: Unnecessary parentheses around'
> 'CHECK: Logical continuations should be on
On Wed, Oct 18, 2017 at 06:50:52PM -0400, Frank A. Cancio Bello wrote:
> On Thu, Oct 19, 2017 at 08:40:08AM +1100, Tobin C. Harding wrote:
> > On Wed, Oct 18, 2017 at 11:48:21AM -0400, Frank A. Cancio Bello wrote:
> > > --- a/drivers/staging/wlan-ng/p80211req.c
> > > ++
On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote:
> Simply break down some long lines and tab-indent them.
Hi Stephen,
Welcome to the Linux kernel. Great that you have put in a patch, you are,
however, unlikely to see
success fixing 'line over 80' warnings. There are a bunch of ar
correct etiquette, I am
still learning also.
On Tue, Oct 24, 2017 at 11:49:41AM +0300, Gilad Ben-Yossef wrote:
> Hi Tobin,
>
> On Tue, Oct 24, 2017 at 6:02 AM, Tobin C. Harding wrote:
> > On Mon, Oct 23, 2017 at 07:53:18AM -0700, Stephen Brennan wrote:
> >> Simply break
On Tue, Oct 24, 2017 at 11:52:58PM -0700, Stephen Brennan wrote:
> Hi Gilad & Tobin,
>
> > > Perhaps, if Stephen is willing, re-write the code to be more readable
> > > by, for example, using a temp
> > > variable for the register address, and in doing so both making the
> > > code more readable a
On Thu, Apr 20, 2017 at 09:02:26PM +0200, Johan Svensson wrote:
>
> On 2017-04-18 20:38, Greg KH wrote:
> > On Tue, Apr 18, 2017 at 08:24:01PM +0200, Johan Svensson wrote:
> >> Change capability field to __le16 in struct ap_info_t,
> >> struct link_ap_info_t, and struct local_ap_t.
> >> This fixes
On Mon, Apr 24, 2017 at 08:44:38PM +1000, Tobin C. Harding wrote:
> On Thu, Apr 20, 2017 at 09:02:26PM +0200, Johan Svensson wrote:
> >
> > On 2017-04-18 20:38, Greg KH wrote:
> > > On Tue, Apr 18, 2017 at 08:24:01PM +0200, Johan Svensson wrote:
> > >> Change
18 renames header and source files 'ks_hostif' to 'hostif'.
Patch 19 renames header and source files 'ks7010_sdio' to 'sdio'.
Patch series was created using `git format-patch -M ...`
Series is untested, builds on x86_64 and PowerPC.
Tobin C. Harding
Code declares and assigns to a local variable that is never used, it
can be safely removed.
Remove unused local variable.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010
Constant SLP_SLEEP is ambiguous, if it were named SLP_ASLEEP the code
would be less ambiguous and easier to read.
Rename constand SLP_SLEEP to SLP_ASLEEP.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
drivers/staging/ks7010/ks_hostif.c | 4 +-
drivers
. This aids the readability of the code and
makes explicit the error path.
Check for NULL directly after allocating the sk_buff, return if
allocation fails. Reduce indentation of subsequent code. Do not change
the program logic.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010
Checkpatch emits CHECK: Please don't use multiple blank lines.
Remove multiple blank lines.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
r. 'mgmt' is widely
accepted as an abbreviation of 'management'. 'power' can be spelled
out in full, the extra two characters aids readability without an
excessive cost.
Make abbreviation of 'management' uniform across the driver, function
names, preprocesso
, further aiding readability.
Add enumeration type sleep_mode_type. Update code that handles sleep
mode to use the new enumeration type.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 7 ---
drivers/staging/ks7010/ks_hostif.h | 8 +---
drivers/staging/ks7010
Macro includes commented out code. Removing dead code line enables
braces to be removed. Macro is easier to read if the code is clean.
Clean up macro ps_confirm_wait_inc.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 10 +-
1 file changed, 5 insertions(+), 5
The returned pointer from netdev_priv() (void *) does not need to be
cast.
Remove unnecessary cast of void * returned by netdev_priv().
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 184 ---
1 file changed, 64 insertions(+), 120
.
Remove unnecessary duplicate address check.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index ee262b2..2dd3047 100644
--- a/drivers/staging/ks7010
d/or expression using existing kernel constant.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/eap_packet.h | 2 ++
drivers/staging/ks7010/ks_hostif.c | 25 -
2 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/ks7010/eap_pack
the magic numbers onto a single line opens the way for
further refactoring.
Clean memory allocation code, remove debug statements.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/stag
: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.h | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
index 384d876..e679765 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging
host interface code, however, the driver uses the
abbreviation 'hostif' for host interface. Best to be uniform within
the driver.
Rename ks_hostif.c to hostif.c
Rename ks_hostif.h to hostif.h
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/Makefile | 2 +
SDIO
code.
Rename ks7010_sdio.c to sdio.c
Rename ks7010_sdio.h to sdio.h
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/Makefile | 2 +-
drivers/staging/ks7010/ks_wlan.h | 2 +-
drivers/staging/ks7010/{ks7010_sdio.c => sdio.c} | 2 +-
drivers/s
.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 34 --
1 file changed, 12 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 6f90e23..d5ec487 100644
--- a/drivers
t the status integer check. Update all sites
that do the check manually to use the newly defined functions.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan.h
helper function to allocate the memory and set the
initial hostif_hdr members code duplication is reduced.
Add function to allocate memory for a host interface request. Set
'size' and 'event' members. Remove duplicate code using newly defined
function.
Signed-off-by: Tobin C. H
Driver header declares enumeration types without tags. Using
informative tags makes the code easier to understand and
eliminates the need to comment the enum.
Add tags to enumeration types.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.h | 9 -
1 file changed, 4
tatement conditional, continue loop if new conditional
evaluates to true. Reduce subsequent code indentation level. Do not
change program logic.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff
On Tue, Apr 25, 2017 at 10:59:25PM +0200, Ilia Sergachev wrote:
> This is a patch to the ks_wlan_net.c file that fixes up the following warning
> found by the checkpatch.pl tool:
> WARNING: Block comments use a trailing */ on a separate line
Good work resubmitting this following Greg's comments. M
On Wed, Apr 26, 2017 at 10:38:54AM +0200, Ilia Sergachev wrote:
> Fix the style of block comments.
> Move trailing */ to a separate line.
> Checkpatch was showing:
> WARNING: Block comments use a trailing */ on a separate line.
You are doing well Ilia. A few nitpicks
- Your first subject was bett
On Wed, Apr 26, 2017 at 01:00:23PM +0200, Ilia Sergachev wrote:
> Checkpatch was showing:
> WARNING: Block comments use a trailing */ on a separate line.
>
> Move trailing */ to a separate line.
>
> Signed-off-by: Ilia Sergachev
Reviewed-by: Tobin C. Harding
>
On Fri, Mar 31, 2017 at 12:42:22PM +0200, Wolfram Sang wrote:
> Hi,
>
> > The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is
> > a SDW-823 and should use the ks7010 driver.
>
> Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for
> which no driver is known:
On Wed, Apr 26, 2017 at 10:55:24AM +1000, Tobin C. Harding wrote:
[snip]
Please drop this patch.
thanks,
Tobin.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Apr 26, 2017 at 10:55:23AM +1000, Tobin C. Harding wrote:
[snip]
Please drop from the series this patch on wards (patch 18 and patch 19).
Is it easier for you if I resubmit the whole series?
Reason :
I just found the original GPL driver source released in 2009 by
Renesas and file
On Wed, Apr 26, 2017 at 10:55:05AM +1000, Tobin C. Harding wrote:
[snip]
Please drop this series. Will re-submit. Apologies for the noise, bad
newbie - no biscuit.
thanks,
Tobin.
___
devel mailing list
de...@linuxdriverproject.org
http
.
Remove unnecessary duplicate address check.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 7151f16..2216409 100644
--- a/drivers/staging/ks7010
. This aids the readability of the code and
makes explicit the error path.
Check for NULL directly after allocating the sk_buff, return if
allocation fails. Reduce indentation of subsequent code. Do not change
the program logic.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010
Code declares and assigns to a local variable that is never used, it
can be safely removed.
Remove unused local variable.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010
d/or expression using existing kernel constant.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/eap_packet.h | 2 ++
drivers/staging/ks7010/ks_hostif.c | 25 -
2 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/ks7010/eap_pack
submission
- remove file renames (patch 18 and patch 19)
- remove spurious refactoring that had slipped into patch
'staging: ks7010: add enum sleep_mode_type'
Tobin C. Harding (16):
staging: ks7010: remove unnecessary address check
staging: ks7010: remove unused local variable eap_key
the magic numbers onto a single line opens the way for
further refactoring.
Clean memory allocation code, remove debug statements.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/stag
.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 34 --
1 file changed, 12 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 8cfda60..8755bd9 100644
--- a/drivers
helper function to allocate the memory and set the
initial hostif_hdr members code duplication is reduced.
Add function to allocate memory for a host interface request. Set
'size' and 'event' members. Remove duplicate code using newly defined
function.
Signed-off-by: Tobin C.
Macro includes commented out code. Removing dead code line enables
braces to be removed. Macro is easier to read if the code is clean.
Clean up macro ps_confirm_wait_inc.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 10 +-
1 file changed, 5 insertions(+), 5
r. 'mgmt' is widely
accepted as an abbreviation of 'management'. 'power' can be spelled
out in full, the extra two characters aids readability without an
excessive cost.
Make abbreviation of 'management' uniform across the driver, function
names, preprocesso
tatement conditional, continue loop if new conditional
evaluates to true. Reduce subsequent code indentation level. Do not
change program logic.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff
, further aiding readability.
Add enumeration type sleep_mode_type. Update code that handles sleep
mode to use the new enumeration type.
Signed-off-by: Tobin C. Harding
---
Change since previous submission
- remove spurious refactoring.
drivers/staging/ks7010/ks_hostif.c | 7 ---
drivers
t the status integer check. Update all sites
that do the check manually to use the newly defined functions.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
drivers/staging/ks7010/ks_hostif.c | 24
drivers/staging/ks7010/ks_wlan.h
Driver header declares enumeration types without tags. Using
informative tags makes the code easier to understand and
eliminates the need to comment the enum.
Add tags to enumeration types.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.h | 9 -
1 file changed, 4
: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.h | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
index f1fdd840..41ae74a 100644
--- a/drivers/staging/ks7010/ks_hostif.h
+++ b/drivers/staging
Checkpatch emits CHECK: Please don't use multiple blank lines.
Remove multiple blank lines.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
The returned pointer from netdev_priv() (void *) does not need to be
cast.
Remove unnecessary cast of void * returned by netdev_priv().
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_wlan_net.c | 184 ---
1 file changed, 64 insertions(+), 120
On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote:
> Sparse spits out a warnings about __le16 and unsigned short assignment.
> Change the type of size and event members of struct hostif_hdr
> to __le16 and correct conversion to the proper cpu type.
I believe that this patch is correc
On Fri, Apr 28, 2017 at 04:27:29PM +0200, Wolfram Sang wrote:
> On Fri, Apr 28, 2017 at 04:41:33PM +0300, Dan Carpenter wrote:
>
> Adding Tobin to CC, he is way more into the driver than I am these
> days...
I've mocked up a patch set to address this issue (along with some
further refactoring of
On Sat, Apr 29, 2017 at 10:58:44PM +0200, Janusz Lisiecki wrote:
> Replace CamelCase struct field names with underscores to comply
> with the standard kernel coding style.
> Changed:
> - FhParms_t
> - DsParms_t
> - CfParms_t
> - IbssParms_t
> - ErpParams_t
>
> Signed-off-by: Janusz Lisiecki
> ---
On Sat, Apr 29, 2017 at 10:58:40PM +0200, Janusz Lisiecki wrote:
> This patchset fix CamelCases in ks7010 driver except michael_mic
> which will be replaced by kernel implementation in the future.
Series looks good to me. For what its worth;
Reviewed-by: Tobin C. Harding
> Janusz Li
On Fri, Apr 28, 2017 at 05:26:17PM +0300, Dan Carpenter wrote:
> On Fri, Apr 28, 2017 at 04:19:28PM +0200, Ilia Sergachev wrote:
> > Checkpatch emits WARNING: Avoid line continuations in quoted strings.
> >
> > Remove line continuations - split strings using quotes.
> >
> > Signed-off-by: Ilia Se
On Fri, Apr 28, 2017 at 03:01:32PM +0200, Ilia Sergachev wrote:
> On Fri, 28 Apr 2017 14:20:21 +0200
> Greg Kroah-Hartman wrote:
>
> >
> > Nope, the whole thing still doesn't apply:
> >
> > checking file drivers/staging/ks7010/ks_wlan_net.c
> > Hunk #1 FAILED at 230.
> > Hunk #2 FAILED at 343.
be
here to fix it up :)
Reviewed-by: Tobin C. Harding
Good work Cezsary, apologies for the wish-washy replies. I'm learning
also ;)
Good luck,
Tobin.
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 10 ++
> drivers/staging/ks7010/ks_hostif.h | 4 ++--
> 2 files
On Mon, May 01, 2017 at 04:11:30PM +0200, gapalinux wrote:
> On Mon, 1 May 2017 19:59:44 +1000
> "Tobin C. Harding" wrote:
>
> > On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote:
> > > Sparse spits out a warnings about __le16 and unsigned short
&g
On Tue, May 02, 2017 at 04:18:39PM +0200, Vincent Siles wrote:
> Removing empty line at the end of the file
Hi Vincent,
Small comment on your patch series. You may have more success if your
summary phrase is in imperative mood i.e sounds like you are
commanding changes to be made to the code base
is untested. Builds on x86_64 and PowerPC.
Tobin C. Harding (3):
staging: ks7010: eap, change unsigned short to __be16
staging: ks7010: hostif, u16 data types to __le16
staging: ks7010: hostif, u32 data types to __le32
drivers/staging/ks7010/eap_packet.h | 4 +-
drivers/staging/ks7010
Sparse emits warning: cast to restricted __be16. EAP header uses
network byte order. The structures used to describe it should use
__beXX data types.
Change data type unsigned short -> __be16.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/eap_packet.h | 4 ++--
1 file changed
data.
Change all u16 data types in host interface structures to be
__le16. Update all code that touches modified data types. Check using
Sparse.
Signed-off-by: Tobin C. Harding
---
drivers/staging/ks7010/ks_hostif.c | 14 ++--
drivers/staging/ks7010/ks_hostif.h | 130
1 - 100 of 566 matches
Mail list logo
