[PATCH] staging: drop fpgaboot driver

2022-02-04 Thread Tong Zhang
The gs_fpgaboot driver is totally broken since 2014 and no one even noticed the driver is not probing. Given the quality of the driver and its current state it makes sense to drop it. Signed-off-by: Tong Zhang --- drivers/staging/Kconfig | 2 - drivers/staging/Makefile

Re: [PATCH] staging: gs_fpgaboot: revert removed board specific code

2022-02-04 Thread Tong Zhang
On Fri, Feb 4, 2022 at 6:23 AM Greg Kroah-Hartman wrote: > > On Thu, Feb 03, 2022 at 09:40:27PM -0800, Tong Zhang wrote: > > Loading the driver will always fail since > > xl_init_io() always returns -1. This driver is broken since 2014 and I > > doubt anyone is actually u

[PATCH] staging: gs_fpgaboot: revert removed board specific code

2022-02-03 Thread Tong Zhang
version. $ modprobe gs_fpga GPIO INIT FAIL!! This patch reverts previously removed code and adds a Kconfig to make this board selectable for PPC_85xx processors. Fixes: 06a3fab941da ("staging: gs_fpgaboot: remove checks for CONFIG_B4860G100") Signed-off-by: Tong Zhang --- drive

Re: [PATCH] staging: comedi: das800: fix request_irq() warn

2021-03-18 Thread Tong Zhang
Thank you all, I fixed the commit log and resent as v2. Thanks, - Tong On Wed, Mar 17, 2021 at 8:48 AM Ian Abbott wrote: > > On 16/03/2021 22:42, Tong Zhang wrote: > > request_irq() wont accept a name which contains slash so we need to > > repalce it with something else --

[PATCH v2] staging: comedi: das800: fix request_irq() warn

2021-03-18 Thread Tong Zhang
anging the parameters passed to request_irq() Suggested-by: Ian Abbott Signed-off-by: Tong Zhang Reviewed-by: Ian Abbott --- v2: fix commit log drivers/staging/comedi/drivers/das800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das800.c b/drive

Re: [PATCH] staging: comedi: das800: fix request_irq() warn

2021-03-17 Thread Tong Zhang
Thanks for sharing those best practices, Dan. I was wondering if there is a spelling checker for git. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] staging: comedi: replace slash in name

2021-03-16 Thread Tong Zhang
On Tue, Mar 16, 2021 at 6:37 AM Ian Abbott wrote: > > Thanks. I think the only other Comedi driver with the same problem is > "drivers/staging/comedi/drivers/das800.c". It passes dev->board_name as > the name argument of request_irq(), but that is "cio-das802/16" for one > of the boards supporte

[PATCH] staging: comedi: das800: fix request_irq() warn

2021-03-16 Thread Tong Zhang
g the parameters passed to request_irq() Suggested-by: Ian Abbott Signed-off-by: Tong Zhang --- drivers/staging/comedi/drivers/das800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/staging/comedi/drivers/das800.c index 2881808

Re: [PATCH] staging: comedi: replace slash in name

2021-03-15 Thread Tong Zhang
Thanks Ian, I have submitted a v2 patch based on your suggestions. Thanks, - Tong On Mon, Mar 15, 2021 at 6:48 AM Ian Abbott wrote: > > On 15/03/2021 10:44, Ian Abbott wrote: > > On 14/03/2021 03:57, Tong Zhang wrote: > >> request_irq() wont accept a name which contain

[PATCH v2] staging: comedi: cb_pcidas: fix request_irq() warn

2021-03-15 Thread Tong Zhang
0 [1.641946] request_threaded_irq+0xfe/0x160 [1.642186] cb_pcidas_auto_attach+0xf4/0x610 [cb_pcidas] Suggested-by: Ian Abbott Signed-off-by: Tong Zhang --- v2: revert changes to .name field so that we dont break userspace drivers/staging/comedi/drivers/cb_pcidas.c | 2 +- 1 file changed, 1

[PATCH v2] staging: comedi: cb_pcidas64: fix request_irq() warn

2021-03-15 Thread Tong Zhang
0 [1.576629] request_threaded_irq+0xfe/0x160 [1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64] Suggested-by: Ian Abbott Signed-off-by: Tong Zhang --- v2: revert changes to .name field so that we dont break userspace drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +- 1 file changed, 1 insertion

[PATCH] staging: comedi: cb_pcidas: replace slash in name

2021-03-13 Thread Tong Zhang
eric.c:180 __xlate_proc_name+0x93/0xb0 [1.634009] RIP: 0010:__xlate_proc_name+0x93/0xb0 [1.639441] Call Trace: [1.639976] proc_mkdir+0x18/0x20 [1.641946] request_threaded_irq+0xfe/0x160 [1.642186] cb_pcidas_auto_attach+0xf4/0x610 [cb_pcidas] Signed-off-by: Tong Zhang --- drive

[PATCH] staging: comedi: replace slash in name

2021-03-13 Thread Tong Zhang
eric.c:180 __xlate_proc_name+0x93/0xb0 [1.568923] RIP: 0010:__xlate_proc_name+0x93/0xb0 [1.574200] Call Trace: [1.574722] proc_mkdir+0x18/0x20 [1.576629] request_threaded_irq+0xfe/0x160 [1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64] Signed-off-by: Tong Zhang --- drivers/stag

[PATCH v1] media: atomisp: fix compiler warning

2021-02-09 Thread Tong Zhang
from highmem %d, user ptr %p, cached %d\n", | ^~~ Signed-off-by: Tong Zhang --- drivers/staging/media/atomisp/pci/hmm/hmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH v1] media: atomisp add auto selection to prevent ce

2021-02-09 Thread Tong Zhang
fh.pad, V4L2_SUBDEV_FORMAT_ACTIVE, add auto select VIDEO_V4L2_SUBDEV_API if VIDEO_ATOMISP is selected Signed-off-by: Tong Zhang --- drivers/staging/media/atomisp/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfi

leaking path in android binder: set_nice

2018-09-25 Thread Tong Zhang
Kernel Version: 4.18.5 Problem Description: When setting nice value, it is checked by LSM function security_task_setnice(). see kernel/sched/core.c:3972 SYSCALL_DEFINE1(nice, int, increment) We discovered a leaking path in android binder which allows using binder’s interface to change a proces