[PATCH 2/4] staging: wilc1000: delete function declaration SendRawPacket

2015-09-14 Thread Tony Cho
From: Glen Lee SendRawpacket is declared but not implemented. It is not used also. So just delete it. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.h

[PATCH 6/7] staging: wilc1000: replace wilc error types with kernel generic error type.

2015-09-14 Thread Tony Cho
error types. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 24 +-- drivers/staging/wilc1000/host_interface.c | 238 +++--- drivers/staging/wilc1000/linux_mon.c | 14 +- drivers/staging/wilc1000

[PATCH 2/7] staging: wilc1000: remove definition WILC_NULLCHECK

2015-09-14 Thread Tony Cho
From: Leo Kim This patch removes the definition WILC_NULLCHECK which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 8 ++-- drivers/staging/wilc1000/wilc_errorsupport.h | 6 -- drivers/staging

[PATCH 7/7] staging: wilc1000: remove wilc_errorsupport

2015-09-14 Thread Tony Cho
From: Leo Kim This patch removes the file, wilc_errorsupport which is not used anymore. Remove #include "wilc_errorsupport.h" from the source code. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_errorsupport.h | 15 --- drivers/stagin

[PATCH 3/7] staging: wilc1000: remove definition WILC_ERRORCHECK

2015-09-14 Thread Tony Cho
Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 3 ++- drivers/staging/wilc1000/wilc_errorsupport.h | 7 --- drivers/staging/wilc1000/wilc_msgqueue.c | 5 - drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 24 --- 4

[PATCH 5/7] staging: wilc1000: remove definitions unused

2015-09-14 Thread Tony Cho
: Tony Cho --- drivers/staging/wilc1000/wilc_errorsupport.h | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_errorsupport.h b/drivers/staging/wilc1000/wilc_errorsupport.h index 99ded3d..054ed76 100644 --- a/drivers/staging/wilc1000

[PATCH 4/7] staging: wilc1000: remove definition WILC_ERRORREPORT

2015-09-14 Thread Tony Cho
and ERRORHANDLER in some of functions. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 6 +- drivers/staging/wilc1000/host_interface.c | 919 +- drivers/staging/wilc1000/wilc_errorsupport.h | 5 - drivers

[PATCH 1/7] staging: wilc1000: remove definition WILC_IS_ERR

2015-09-14 Thread Tony Cho
From: Leo Kim This patch removes the definition WILC_IS_ERR which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_errorsupport.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000

[PATCH 0/7] remove wilc_errorsupport.h from the wilc driver

2015-09-14 Thread Tony Cho
This patch aims to remove the wilc_errorsupport.h which is unnecessary in the wilc driver. This patch replaces the error types defined by wilc driver with kernel generic error types and removes macros which handles the errors. Leo Kim (7): staging: wilc1000: remove definition WILC_IS_ERR stagi

Re: [PATCH 2/2] staging: wilc1000: remove RX_BH_TYPE

2015-09-14 Thread Tony Cho
Hi Greg, I am sorry but please ignore this patch in this time. It's my mistake to include this patch from my queue into the series of 7 patches. Thanks, Tony. On 2015년 09월 11일 16:52, Tony Cho wrote: This patch removes the preprocessor definition, RX_BH_TYPE and use

Re: [PATCH v2 1/2] staging: wilc1000: remove unused enum

2015-09-13 Thread Tony Cho
On 2015년 09월 14일 13:25, Greg KH wrote: On Mon, Sep 14, 2015 at 10:29:26AM +0900, Tony Cho wrote: On 2015년 09월 12일 11:35, Greg KH wrote: On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote: From: Glen Lee This patch removes a unused enum tenuFrameClass. Signed-off-by: Glen Lee

Re: [PATCH v2 1/2] staging: wilc1000: remove unused enum

2015-09-13 Thread Tony Cho
On 2015년 09월 12일 11:35, Greg KH wrote: On Fri, Sep 11, 2015 at 12:04:19PM +0900, Tony Cho wrote: From: Glen Lee This patch removes a unused enum tenuFrameClass. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file changed

[PATCH 7/7] staging: wilc1000: remove unused variables

2015-09-11 Thread Tony Cho
From: Glen Lee Variable g_num_total_switches is never used so just remove it. gastrWIDs is also not used because g_num_total_switches is deleted. Remove gastrWIDs also. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 127

[PATCH 5/7] staging: wilc1000: remove unnecessary extern function declaration

2015-09-11 Thread Tony Cho
From: Glen Lee Function NetworkInfoReceived, GnrlAsyncInfoReceived and host_int_ScanCompleteReceived are declared in the header file already. Just removes the declaration and comments. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8

[PATCH 6/7] staging: wilc1000: delete unused global variables.

2015-09-11 Thread Tony Cho
From: Glen Lee gstrConfigPktInfo, SemHandleSendPkt and SemHandlePktResp are never used in the drivers. So just delete the variables and it's related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 11 --- 1 file change

[PATCH 2/7] staging: wilc1000: remove useless define PHY_802_11n

2015-09-11 Thread Tony Cho
From: Glen Lee The define PHY_802_11n is useless because wilc1000 support 802.11n as always. Remove PHY_802_11n and it related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers

[PATCH 4/7] staging: wilc1000: remove unused defines

2015-09-11 Thread Tony Cho
From: Glen Lee This patch removes follwing unused defines. MAX_CFG_PKTLEN MSG_HEADER_LEN QUERY_MSG_TYPE WRITE_MSG_TYPE RESP_MSG_TYPE WRITE_RESP_SUCCESS INVALID MAC_ADDR_LEN Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file

[PATCH 3/7] staging: wilc1000: remove unnecessary define FIVE_GHZ_BAND

2015-09-11 Thread Tony Cho
From: Glen Lee wilc1000 driver does not support five Ghz band. Remove FIVE_GHZ_BAND and it's related code. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/wil

[PATCH 2/2] staging: wilc1000: remove RX_BH_TYPE

2015-09-11 Thread Tony Cho
This patch removes the preprocessor definition, RX_BH_TYPE and uses the request_threaded_irq instead of kernel thread to execute the interrupt handler. As a result, linux_wlan_enable_irq() and linux_wlan_disable_irq() are also removed from the linux_wlan.c file. Signed-off-by: Tony Cho

[PATCH 1/7] staging: wilc1000: remove PANDA_BOARD

2015-09-11 Thread Tony Cho
This patch removes one of the platform dependencies, PANDA_BOARD from the driver codes. The device tree will provide the platform dependencies in the future commits. Signed-off-by: Tony Cho Signed-off-by: Glen Lee --- drivers/staging/wilc1000/linux_wlan.c | 4 drivers/staging

[PATCH v2 2/2] staging: wilc1000: coreconfigurator.c: remove unused functions

2015-09-10 Thread Tony Cho
. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 1051 --- 1 file changed, 1051 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c index 450c3ff..f393424

[PATCH 0/2] resending v2 of the patch for coreconfigurator.c file

2015-09-10 Thread Tony Cho
This is the version 2 for the series of the patch which removes unused functions from the coreconfigurator.c file. Some of functions was not included in the first patch. Glen Lee (2): staging: wilc1000: remove unused enum staging: wilc1000: coreconfigurator.c: remove unused functions drivers

[PATCH v2 1/2] staging: wilc1000: remove unused enum

2015-09-10 Thread Tony Cho
From: Glen Lee This patch removes a unused enum tenuFrameClass. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000

[PATCH 5/5] staging: wilc1000: coreconfigurator.c: remove unused functions

2015-09-10 Thread Tony Cho
. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 151 1 file changed, 151 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c index 450c3ff..f339085

[PATCH 2/5] staging: wilc1000: remove firmware definition

2015-09-10 Thread Tony Cho
This patch removes the firmware definitions, STA_FIRMWARE, AP_FIRMWARE, and P2P_CONCURRENCY_FIRMWARE from the linux_wlan.c file because they are defined in the Makefile. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 12 1 file changed, 12 deletions(-) diff

[PATCH 3/5] staging: wilc1000: remove unused global variables

2015-09-10 Thread Tony Cho
This patch removes the followings from the driver because they are in debugging purpose but not used anymore. - int_clrd - int_rcvdU - int_rcvdB - android_wifi_priv_cmd structure Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 17 - drivers/staging/wilc1000

[PATCH 4/5] staging: wilc1000: remove unused enum

2015-09-10 Thread Tony Cho
From: Glen Lee This patch removes a unused enum tenuFrameClass. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000

[PATCH 1/5] staging: wilc1000: remove STATIC_MACADDRESS

2015-09-10 Thread Tony Cho
This patch removes unused definition, STATIC_MACADDRESS from the linux_wlan.c file. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 77 --- 1 file changed, 77 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging

[PATCH v2 2/2] staging: wilc1000: delete wilc_memory.c and wilc_memory.h

2015-09-09 Thread Tony Cho
From: Glen Lee The macro WILC_MALLOC is not used in the driver anymore, so just delete files. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 2 +- drivers/staging/wilc1000/wilc_memory.c| 16 drivers/staging/wilc1000/wilc_memory.h

[PATCH v2 1/2] staging: wilc1000: remove kmalloc wrapper

2015-09-09 Thread Tony Cho
From: Glen Lee This patch calls kmalloc() directly. No need to wrap kmalloc(). All is not holding a spin lock or in interrupt context. So use GFP_KERNEL flag for kmalloc. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 110

[PATCH] staging: wilc1000: remove BROKEN status

2015-09-09 Thread Tony Cho
This patch removes BROKEN status from the Kconfig. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/Kconfig b/drivers/staging/wilc1000/Kconfig index 51bbf46..59ccecc 100644 --- a/drivers/staging/wilc1000

Re: [PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h

2015-09-09 Thread Tony Cho
error values defined in the errorsupport.h file so that I send you the next patch when done. Thanks, Tony. On 2015년 09월 10일 03:19, Greg KH wrote: On Wed, Sep 09, 2015 at 04:08:12PM +0900, Tony Cho wrote: From: Glen Lee wilc1000 driver runs on Linux. No need to have oswrapper or platform

Re: [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper

2015-09-09 Thread Tony Cho
On 2015년 09월 10일 03:17, Greg KH wrote: On Wed, Sep 09, 2015 at 04:08:10PM +0900, Tony Cho wrote: From: Glen Lee Call kmalloc directly. No need to wrap kmalloc. Only one function, wilc_mq_send which use WILC_MALLOC, can be running in interrupt context or process context. In this case, We

[PATCH 4/4] staging: wilc1000: remove unused PLAT_RK3026_TCHIP

2015-09-09 Thread Tony Cho
From: Leo Kim This patch removes the preprocessor definition, PLAT_RK3026_TCHIP which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.c | 24 1 file changed, 24 deletions(-) diff --git a/drivers/staging

[PATCH 1/4] staging: wilc1000: remove kmalloc wrapper

2015-09-09 Thread Tony Cho
is one kmalloc which flag is always GFP_ATOMIC. This also changed together. Others are not holding a spin lock or in interrupt context. So use GFP_KERNEL flag for kmalloc. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 110

[PATCH 2/4] staging: wilc1000: delete wilc_memory.c and wilc_memory.h

2015-09-09 Thread Tony Cho
From: Glen Lee The macro WILC_MALLOC is not used in the driver anymore, so just delete files. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 2 +- drivers/staging/wilc1000/wilc_memory.c| 16 drivers/staging/wilc1000/wilc_memory.h

[PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h

2015-09-09 Thread Tony Cho
, remove wilc_oswrapper.h and wilc_platform.h. Signed-off-by: Glen Lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 1 + drivers/staging/wilc1000/host_interface.c | 3 ++ drivers/staging/wilc1000/host_interface.h | 1 + drivers/staging/wilc1000/wilc_msgqueue.c

[PATCH 4/5] staging: wilc1000: remove unused NM73131_0_BOARD

2015-09-08 Thread Tony Cho
From: "Kim, Leo" This patch removes the preprocessor definition, NM73131_0_BOARD which is not used anymore. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 40 -- drivers/staging/wilc1000/linux_wlan_common.h | 7 +-

[PATCH 5/5] staging: wilc1000: delete definition USE_WIRELESS

2015-09-08 Thread Tony Cho
From: "Kim, Leo" The preprocessor definition, USE_WIRELESS is always in use. So, this patch deletes the definitions from the makefile and source codes. Signed-off-by: Leo Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/Makefile | 2 +- drivers/staging/wilc1000/linux_m

[PATCH 3/5] staging: wilc1000: add maintainers for Atmel 802.11 driver

2015-09-08 Thread Tony Cho
This patch adds new maintainers who develops new design for Atmel 802.11 link controller and deletes Dean Lee who cannot maintain the wireless driver anymore. Signed-off-by: Tony Cho --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

[PATCH 2/5] staging: wilc1000: remove meaningless line

2015-09-08 Thread Tony Cho
the line for dummy headroom. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index 59c9b44..dc297fc 100644 --- a/drivers

[PATCH 1/5] staging: wilc1000: define undefined operation mode

2015-09-08 Thread Tony Cho
From: Johnny Kim This patch adds new define, IDLE_MODE to change comparison statement which is wrong due to typecasting to null. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 1 + 2 files

Re: [PATCH 4/5] staging: wilc1000: wilc_msgqueue.c: use kmalloc with GFP_ATOMIC

2015-09-07 Thread Tony Cho
On 2015년 09월 08일 00:36, Chaehyun Lim wrote: This patch use kmalloc with GFP_ATOMIC instead of WILC_MALLOC. It is inside the spin lock region. Signed-off-by: Chaehyun Lim --- drivers/staging/wilc1000/wilc_msgqueue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 1/3] staging: wilc1000: remove dead codes

2015-09-07 Thread Tony Cho
This patch removes the preprocessor definition from the codes, as shown in the following, which is not used anymore. - WILC_FULLY_HOSTING_AP Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_mon.c | 97 --- drivers/staging/wilc1000/linux_wlan.c

[PATCH 3/3] staging: wilc1000: fix potential memory leak

2015-09-07 Thread Tony Cho
This patch adds kfree(mgmt_tx) when memory allocation of mgmt_tx->buff fails in the second calls of kmalloc() to avoid the memory leak from mgmt_tx first allocated before the second calls of kmalloc(). Signed-off-by: Tony Cho Signed-off-by: Chris Park --- drivers/staging/wilc1000/linux_mo

[PATCH 2/3] staging: wilc1000: remove unused preprocessor definition

2015-09-07 Thread Tony Cho
This patch removes a preprocessor definition, SWITCH_LOG_TERMINAL, which is not used. Enabling this definition affects the performance. Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c| 6 -- drivers/staging/wilc1000/wilc_wlan_cfg.c | 8 2 files changed, 14

[PATCH 3/5] staging: wilc1000: use id value as argument

2015-08-20 Thread Tony Cho
them. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 241 +++--- drivers/staging/wilc1000/host_interface.h | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 3 files changed, 176 insertions(+), 67 dele

[PATCH 4/5] staging: wilc1000: change address to fixed value

2015-08-20 Thread Tony Cho
From: Johnny Kim The linux_wlan_init_test_config() is called once when net driver is loaded. And because the pointer type of the pstrWFIDrv is changed with the interger type, this patch replaces it with designated value instead of pointer. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho

[PATCH 5/5] staging: wilc1000: define undefined operation mode

2015-08-20 Thread Tony Cho
From: Johnny Kim This patch adds new define, IDLE_MODE to change comparison statement which is wrong due to typecasting to null. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 1 + 2 files

[PATCH 2/5] staging: wilc1000: add an argument for Handle_SetWfiDrvHandler

2015-08-20 Thread Tony Cho
From: Johnny Kim Similar to functions of same layer, this patch add an argument for Handle_SetWfiDrvHandler function. As a result, the redundant typecasting is removed. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 +++- 1 file

[PATCH 1/5] staging: wilc1000: use the real data type

2015-08-20 Thread Tony Cho
From: Johnny Kim This patch changes the type of gu8FlushedJoinReqDrvHandler with his real data type becasue typecasting is not necessary. In result, typecasting which is not necessary and some building warnings is removed. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging

[PATCH 0/5] staging: wilc1000: support 64bit machine and remove warnings

2015-08-20 Thread Tony Cho
This includes the remaining patches for 64bits. The driver uses the redundant typecasting to communicate with the chipset, which causes several compile warnings. However, this patch uses the real data type and removes unnecessary typecasting. Also, the driver allocates the ID value to the pointer

[PATCH 5/5] staging: wilc1000: use id value as argument

2015-08-12 Thread Tony Cho
them. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 249 +++--- drivers/staging/wilc1000/host_interface.h | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 3 files changed, 186 insertions(+), 65 dele

[PATCH 4/5] staging: wilc1000: use the real data type

2015-08-12 Thread Tony Cho
From: Johnny Kim This patch changes the type of gu8FlushedJoinReqDrvHandler with his real data type becasue typecasting is not necessary. In result, typecasting which is not necessary and some building warnings is removed. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging

[PATCH 3/5] staging: wilc1000: clarify the argument type

2015-08-12 Thread Tony Cho
is removed becasue it is not necessary. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 78 +++ drivers/staging/wilc1000/host_interface.h | 4 +- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a

[PATCH 1/5] staging: wilc1000: replace WILC_WFIDrvHandle by tstrWILC_WFIDrv

2015-08-12 Thread Tony Cho
Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 126 +++--- drivers/staging/wilc1000/host_interface.h | 104 +- drivers/staging/wilc1000/linux_wlan.c | 16 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperatio

[PATCH 2/5] staging: wilc1000: change void pointer type to real type

2015-08-12 Thread Tony Cho
From: Johnny Kim This patch changes the void pointer member of the tstrHostIFmsg to the real data type because the void pointer type is ambiguous and not readable. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1

[PATCH 0/5] staging: wilc1000: 64bit build patch

2015-08-12 Thread Tony Cho
This series of patch includes new design for 64 bits. The driver uses the redundant typecasting to communicate with the chipset, which causes several compile warnings. However, this patch uses the real data type and removes unnecessary typecasting. Also, the driver allocates the ID value to the po

[PATCH 2/5] staging: wilc1000: change void pointer type to real type

2015-08-09 Thread Tony Cho
From: Johnny Kim This patch changes the void pointer member of the tstrHostIFmsg to the real data type because the void pointer type is ambiguous and not readable. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1

[PATCH 1/5] staging: wilc1000: replace WILC_WFIDrvHandle by tstrWILC_WFIDrv

2015-08-09 Thread Tony Cho
Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 126 +++--- drivers/staging/wilc1000/host_interface.h | 104 +- drivers/staging/wilc1000/linux_wlan.c | 16 +-- drivers/staging/wilc1000/wilc_wfi_cfgoperatio

[PATCH 4/5] staging: wilc1000: use the real data type

2015-08-09 Thread Tony Cho
From: Johnny Kim This patch changes the type of gu8FlushedJoinReqDrvHandler with his real data type becasue typecasting is not necessary. In result, typecasting which is not necessary and some building warnings is removed. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging

[PATCH 5/5] staging: wilc1000: use id value as argument

2015-08-09 Thread Tony Cho
them. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 242 +++--- drivers/staging/wilc1000/host_interface.h | 1 + drivers/staging/wilc1000/wilc_wfi_netdevice.h | 1 - 3 files changed, 180 insertions(+), 64 dele

[PATCH 3/5] staging: wilc1000: clarify the argument type

2015-08-09 Thread Tony Cho
is removed becasue it is not necessary. Signed-off-by: Johnny Kim Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 78 +++ drivers/staging/wilc1000/host_interface.h | 4 +- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a

[PATCH 0/5] 64 bit build patch

2015-08-09 Thread Tony Cho
This series of patch includes new design for 64 bits. The driver uses the redundant typecasting to communicate with the chipset, which causes several compile warnings. However, this patch uses the real data type and removes unnecessary typecasting. Also, the driver allocates the ID value to the

Re: [PATCH 25/28] staging: wilc1000: change cast type from pointer to uintptr_t

2015-08-03 Thread tony . cho
05:50, Greg KH wrote: On Fri, Jul 31, 2015 at 04:38:33PM +0900, Tony Cho wrote: From: glen lee To use drvHandler as integer operation, cast type to uintptr_t. Here is the build warning. drivers/staging/wilc1000/wilc_wlan.c:1871:23: warning: cast from pointer to integer of different size [-Wpoint

[PATCH 28/28] staging: wilc1000: change data type of variable

2015-07-31 Thread Tony Cho
:6878:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] pstrWFIDrv = (tstrWILC_WFIDrv *)drvHandler; Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 27/28] staging: wilc1000: fix casting build warning

2015-07-31 Thread Tony Cho
ULL) Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index c5db385..b36f98c 100644 --- a/driv

[PATCH 23/28] staging: wilc1000: change type of parameter in wilc_wlan_cfg_commit

2015-07-31 Thread Tony Cho
From: glen lee This patch changes drvHandler of uinit32_t type with WILC_WFIDrvHandle type to match driver handle type since wilc_wlan_cfg_commit gets drvHandler of WILC_WFIDrvHandle type as argument now. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000

[PATCH 17/28] staging: wilc1000: fix comparison between different type warning

2015-07-31 Thread Tony Cho
] if (gu8FlushedInfoElemAsoc != NULL && gu8FlushedJoinReqDrvHandler == (u32)drvHandler) { Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/

[PATCH 26/28] staging: wilc1000: remove unused variable

2015-07-31 Thread Tony Cho
From: glen lee This patch removes unused variable pstrWFIDrv. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000

[PATCH 24/28] staging: wilc1000: fix cast from pointer to integer warning

2015-07-31 Thread Tony Cho
to integer of different size [-Wpointer-to-int-cast] skb_reserve(skb, (unsigned int)skb->data & 0x3); Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/w

[PATCH 18/28] staging: wilc1000: change pstrWFIDrv with drvHandler

2015-07-31 Thread Tony Cho
From: glen lee As type of gu8FlushedJoinReqDrvHandler was changed with WILC_WFIDrvHandle, change right value with drvHandler to match type. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 22/28] staging: wilc1000: fix passing argument from incompatible type warning

2015-07-31 Thread Tony Cho
ler->u32Address as argument as it is. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c

[PATCH 19/28] staging: wilc1000: change type of variable in tstrHostIfSetDrvHandler

2015-07-31 Thread Tony Cho
From: glen lee This patch changes u32Address of u32 type with WILC_WFIDrvHandle type in the structure tstrHostIfSetDrvHandler because u32Address is used to hold driver handler. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 2 +- 1 file

[PATCH 21/28] staging: wilc1000: remove unwanted type cast

2015-07-31 Thread Tony Cho
From: glen lee This patch removes (u32) type cast which makes build warning because the parameter of u32 type in the function host_int_set_wfi_drv_handler was changed with WILC_WFIDrvHandle. Not necessary to cast type. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging

[PATCH 25/28] staging: wilc1000: change cast type from pointer to uintptr_t

2015-07-31 Thread Tony Cho
lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 2 +- drivers/staging/wilc1000/wilc_wlan.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index ec80849..14c2071 100644

[PATCH 20/28] staging: wilc1000: remove unnecessary type case

2015-07-31 Thread Tony Cho
From: glen lee This patch removes (u32) type cast which makes build warning since the u32Address of u32 type was changed with WILC_WFIDrvHandle. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 10/28] staging: wilc1000: change driver handle variable

2015-07-31 Thread Tony Cho
From: glen lee This patch change (u32)pstrWFIDrv with priv->hWILCWFIDrv as a argument of wlan_cfg_set since the parameter drvHandler of uint32_t type in wlan_cfg_set was changed with WILC_WFIDrvHandle. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wla

[PATCH 12/28] staging: wilc1000: change type of driver handler in tstrInterfaceInfo

2015-07-31 Thread Tony Cho
From: glen lee This patch changes drvHandler of uint32_t type with WILC_WFIDrvHandle type since drvHandler is used to pass WILC_WFIDrvHandle type to other functions. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_netdevice.h | 2 +- 1 file changed, 1

[PATCH 14/28] staging: wilc1000: remove unnecessary type cast in host_int_set_wfi_drv_handler

2015-07-31 Thread Tony Cho
From: glen lee This patch removes unnecessary type cast since the u32 type parameter in host_int_set_wfi_drv_handler was changed with WILC_WFIDrvHandle. Therefore, No need to cast u32. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wfi_cfgoperations.c | 4

[PATCH 13/28] staging: wilc1000: change type of argument in host_int_set_wfi_drv_handler

2015-07-31 Thread Tony Cho
-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index

[PATCH 15/28] staging: wilc1000: fix cast from pointer to integer warning

2015-07-31 Thread Tony Cho
ler = (u32)priv->hWILCWFIDrv; Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/linux_wlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c index a808722..5dcb30c 100644

[PATCH 09/28] staging: wilc1000: change drvHandler type in wlan_cfg_set

2015-07-31 Thread Tony Cho
: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.c| 2 +- drivers/staging/wilc1000/wilc_wlan_if.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index 273073f..d5fc54b

[PATCH 11/28] staging: wilc1000: fix incompatible type in assignment warning

2015-07-31 Thread Tony Cho
; Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 66565f6..e9cd77d 100644 --- a

[PATCH 16/28] staging: wilc1000: change type of variable

2015-07-31 Thread Tony Cho
From: glen lee This patch changes gu8FlushedJoinReqDrvHandler of u32 type with WILC_WFIDrvHandle type. gu8FlushedJoinReqDrvHandler is used to hold driver handler for comparison but the type mismatches with it. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000

[PATCH 08/28] staging: wilc1000: change drvHandler type in wlan_cfg_get

2015-07-31 Thread Tony Cho
: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/wilc_wlan.c| 2 +- drivers/staging/wilc1000/wilc_wlan_if.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c index def72fd..273073f

[PATCH 07/28] staging: wilc1000: remove unused variables

2015-07-31 Thread Tony Cho
From: glen lee This patch removes unused variable pstrWFIDrv. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging

[PATCH 02/28] staging: wilc1000: change void type of argument with WILC_WFIDrvHandle

2015-07-31 Thread Tony Cho
: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 74 +++ drivers/staging/wilc1000/host_interface.h | 2 +- 2 files changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c

[PATCH 06/28] staging: wilc1000: chage driver handler variable in SendConfigPkt

2015-07-31 Thread Tony Cho
From: glen lee This patch changes pstrWFIDrv with WILC_WFIDrvHandle type variable as a argument of SendConfigPkt in all associate code because the type of argument 5 in SendConfigPkt was changed with WILC_WFIDrvHandle type. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging

[PATCH 04/28] staging: wilc1000: change type of argument 5 in SendConfigPkt

2015-07-31 Thread Tony Cho
. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/coreconfigurator.c | 2 +- drivers/staging/wilc1000/coreconfigurator.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000

[PATCH 05/28] staging: wilc1000: remove unnecessary type cast

2015-07-31 Thread Tony Cho
pointer to integer of different size [-Wpointer-to-int-cast] s32Error = SendConfigPkt(SET_CFG, &strWID, 1, true, (u32)pstrWFIDrv); Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 100 +++--- 1 file changed, 50 insert

[PATCH 01/28] staging: wilc1000: change type of driver handler in host interface msg

2015-07-31 Thread Tony Cho
as argument. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c index 02aaf39..fb4194a 100644

[PATCH 03/28] staging: wilc1000: move structure WILC_WFIDrvHandle into wilc_wlan_if.h

2015-07-31 Thread Tony Cho
header file. Signed-off-by: glen lee Signed-off-by: Tony Cho --- drivers/staging/wilc1000/host_interface.h | 3 --- drivers/staging/wilc1000/wilc_wlan_if.h | 4 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wilc1000/host_interface.h b/drivers/staging

[PATCH 00/28] removing the compile warnings for 64-bit

2015-07-31 Thread Tony Cho
Hi Greg, This patch focuses on removing the compile warnings for 64bit incompatability. Most warnings are due to senseless type castings from driver handler to u32 and also to void pointers. They are removed by using the same handler with this series of patch. All warnings disappear. This patch is

Re: [PATCH 0/5] 2nd patch for illegal coding style

2015-07-30 Thread tony . cho
12:49, Greg KH wrote: On Thu, Jul 30, 2015 at 06:10:09PM +0900, Tony Cho wrote: This patch V2 includes only patches rejected. The rejected patch for the following, #ifdef conditionals cover entire functions, introduced new error on required space before the open parenthesis '('. This is

Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread tony . cho
On 2015년 07월 30일 20:56, Sudip Mukherjee wrote: On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote: This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than portions

Re: [PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread tony . cho
On 2015년 07월 30일 20:56, Sudip Mukherjee wrote: On Thu, Jul 30, 2015 at 06:10:10PM +0900, Tony Cho wrote: This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than portions

[PATCH V2 5/5] staging: wilc1000: remove unused functions

2015-07-30 Thread Tony Cho
This patch removes the dead functions which are not used anymore. - sdio_check_bs - sdio_xfer_cnt Signed-off-by: Tony Cho --- V2: This patch doesn't have any difference with the first patch becasue this patch just removes unnecessary functions. However, it is resent because

[PATCH V2 1/5] staging: wilc1000: #ifdef conditionals cover entire functions

2015-07-30 Thread Tony Cho
This patch lets preprocessor conditionals (#ifdef) related to WILC_SDIO_IRQ_GPIO to compile out the entire functions. Compiling out the entire functions is preferred rather than portions of functions or expressions becausue doing so makes code harder to read. Signed-off-by: Tony Cho --- V2

[PATCH V2 4/5] staging: wilc1000: remove errors on required space

2015-07-30 Thread Tony Cho
This patch removes the errors reported by checkpatch.pl, which is the space required before the open parenthesis '('. Signed-off-by: Tony Cho --- V2: This patch is not different with the first one. This patch includes warnings on no space required before the open parenthesis in th

<    1   2   3   4   5   6   7   >