Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-19 Thread Tristan Lelong
Greg, On Sun, Jan 18, 2015 at 04:02:22PM +0900, Greg KH wrote: On Sat, Jan 17, 2015 at 10:41:44PM -0800, Tristan Lelong wrote: Hi Greg, On Sat, Jan 17, 2015 at 03:28:27PM -0800, Greg KH wrote: I took your v2 version, please send me the difference as this is a mess

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-17 Thread Tristan Lelong
Hi Greg, On Sat, Jan 17, 2015 at 03:28:27PM -0800, Greg KH wrote: I took your v2 version, please send me the difference as this is a mess... Not sure I understand what you meant here. Do you want me to submit a new patch that contains only the differences between v2 and v3? Thanks,

[PATCH] staging: lustre: remove kmalloc from fld_proc_hash_seq_write

2015-01-17 Thread Tristan Lelong
This patch simplifies the fld_proc_hash_seq_write function by removing the dynamic memory allocation. The longest fh_name used so far in lustre is 4 characters. We use a 8 bytes variable to be on the safe side. Signed-off-by: Tristan Lelong tris...@lelong.xyz --- Hi Greg, This patch is a rework

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-24 Thread Tristan Lelong
On Sat, Dec 06, 2014 at 04:03:22PM -0800, Tristan Lelong wrote: This patch fix a sparse warning in lustre sources warning: incorrect type in argument 1 (different address spaces) expected void [noderef] asn:1*to got char *noident This is done by adding the missing __user attribute

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-06 Thread Tristan Lelong
Andreas, On Sat, Dec 06, 2014 at 05:05:14PM +, Dilger, Andreas wrote: On 2014/12/05, 3:41 PM, Tristan Lelong tris...@lelong.xyz wrote: Sorry, but I don't see where you get 80 from? fh_name is declared as a const char *, and initialized in the declaration of fld_hash[]. I'd thought

Re: [PATCH] staging: lustre: replace static value with define

2014-12-06 Thread Tristan Lelong
On Sat, Dec 06, 2014 at 05:09:29PM +, Dilger, Andreas wrote: diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c index 74b4db9..7a55941 100644 --- a/drivers/staging/lustre/lustre/fld/lproc_fld.c +++

[PATCH v2] staging: lustre: replace static value with define

2014-12-06 Thread Tristan Lelong
the same define for LCS, LSS, LCF, and LSF. Signed-off-by: Tristan Lelong tris...@lelong.xyz --- Notes: This modification answers Joe Perches suggestion: https://lkml.org/lkml/2014/12/5/107 Changes in v2: Remove check on LUSTRE_MDT_MAXNAMELEN for fh_name which is not a MDT

[PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-06 Thread Tristan Lelong
ones): - lprocfs_write_frac_helper - lprocfs_write_helper - lprocfs_write_u64_helper The patch also fixes one __user pointer direct dereference by strncmp in function fld_proc_hash_seq_write. Signed-off-by: Tristan Lelong tris...@lelong.xyz --- Changes in v2: Use dynamic allocation

[PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
ones): - lprocfs_write_frac_helper - lprocfs_write_helper - lprocfs_write_u64_helper The patch also fixes one __user pointer direct dereference by strncmp in function fld_proc_hash_seq_write by adding the proper copy_from_user. Signed-off-by: Tristan Lelong tris...@lelong.xyz --- drivers/staging

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote: On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: This patch fix a sparse warning in lustre sources warning: incorrect type in argument 1 (different address spaces) expected void [noderef] asn:1*to got char

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
On Fri, Dec 05, 2014 at 12:44:07AM -0800, Joe Perches wrote: On Fri, 2014-12-05 at 00:37 -0800, Tristan Lelong wrote: On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote: On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote: [] diff --git a/drivers/staging/lustre/lustre/fld

Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
On Fri, Dec 05, 2014 at 01:27:23PM -0800, Greg KH wrote: On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote: static ssize_t -fld_proc_hash_seq_write(struct file *file, const char *buffer, - size_t count, loff_t *off) +fld_proc_hash_seq_write(struct file

[PATCH v2] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2014-12-05 Thread Tristan Lelong
ones): - lprocfs_write_frac_helper - lprocfs_write_helper - lprocfs_write_u64_helper The patch also fixes one __user pointer direct dereference by strncmp in function fld_proc_hash_seq_write. Signed-off-by: Tristan Lelong tris...@lelong.xyz --- Changes in v2: Use dynamic allocation

[PATCH] staging: lustre: replace static value with define

2014-12-05 Thread Tristan Lelong
the same define for LCS, LSS, LCF, and LSF names. Signed-off-by: Tristan Lelong tris...@lelong.xyz --- Note: This modification answers Joe Perches suggestion: https://lkml.org/lkml/2014/12/5/107 The patch has to be applied on top of https://lkml.org/lkml/2014/12/6/17 --- drivers

[PATCH] Staging: android: ion: fix typos in comments

2014-10-31 Thread Tristan Lelong
Fix some coding style warnings detected by checkpatch.pl in ion. Signed-off-by: Tristan Lelong tris...@lelong.xyz --- drivers/staging/android/ion/ion.c | 2 +- drivers/staging/android/ion/ion.h | 2 +- drivers/staging/android/ion/ion_priv.h | 4 ++-- 3 files changed, 4 insertions(+), 4

[PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration

2014-10-29 Thread Tristan Lelong
This patch removes tabs used to align variable names in declaration and assignation. It replaces them with exactly one space. Signed-off-by: Tristan Lelong tristan.lel...@blunderer.org --- drivers/staging/android/logger.c | 49 1 file changed, 24

Re: [PATCH] Staging: android: logger: Remove uneeded tabs in variable declaration

2014-10-29 Thread Tristan Lelong
On Thu, Oct 30, 2014 at 12:08:12AM +0800, Greg KH wrote: On Tue, Oct 28, 2014 at 11:09:10PM -0700, Tristan Lelong wrote: This patch removes tabs used to align variable names in declaration and assignation. It replaces them with exactly one space. Why? This seems like a totally unneeded