is not found, just skip and free
> the others.
>
nit, typo error "If if one".
> Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic
> audio module")
> Reported-by: Hulk Robot
> Signed-off-by: Wang Hai
On Fri, Dec 4, 2020 at 2:10 PM Johan Hovold wrote:
>
> On Fri, Dec 04, 2020 at 10:13:50AM +0800, Wang Hai wrote:
> > Add the missing unlock before return from function
> > gbaudio_dapm_free_controls() in the error handling case.
> >
> > Fixes: 510e340efe0c ("staging: greybus: audio: Add helper API
--
Hi Coiby,
Thanks for sharing the patch. Sorry, I could not reply to the v1 series.
Now, I have gone through the patches. Looks good (all 3 patches).
Reviewed-by: Vaibhav Agarwal
--
Thanks,
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
if (gbvalue.value.integer_value[0] != val) {
This patch fixes the issue with fetching the gbvalue before using it for
comparision.
Fixes: 6339d2322c47 ("greybus: audio: Add topology parser for GB codec")
Reported-by: Colin Ian King
Signed-off-by: Vaibhav Agarwal
---
Changelog:
v
if (gbvalue.value.integer_value[0] != val) {
This patch fixes the issue with fetching the gbvalue before using it for
comparision.
Fixes: 6339d2322c47 ("greybus: audio: Add topology parser for GB codec")
Reported-by: Colin Ian King
Signed-off-by: Vaibhav Agarwal
---
Changelog:
v
On Mon, Aug 10, 2020 at 8:34 PM Dan Carpenter wrote:
>
> On Thu, Aug 06, 2020 at 09:51:57PM +0530, Vaibhav Agarwal wrote:
> > diff --git a/drivers/staging/greybus/audio_topology.c
> > b/drivers/staging/greybus/audio_topology.c
> > index 2f9fdbdcd547..4b914d0edef2 100644
&
if (gbvalue.value.integer_value[0] != val) {
This patch fixes the issue with fetching the gbvalue before using it for
comparision.
Fixes: 6339d2322c47 ("greybus: audio: Add topology parser for GB codec")
Reported-by: Colin Ian King
Signed-off-by: Vaibhav Agarwal
---
drivers/stagi
On Wed, Aug 05, 2020 at 08:35:15AM -0500, Alex Elder wrote:
>
> I think the fix is to add a call to this:
>
> ret = gb_audio_gb_get_control(module->mgmt_connection, data->ctl_id,
> GB_AUDIO_INVALID_INDEX, &gbvalue);
>
> before the field within gbv
On Wed, Aug 5, 2020 at 6:35 PM Alex Elder wrote:
>
> On 7/9/20 5:27 AM, Vaibhav Agarwal wrote:
> > snd_soc_jack APIs are modified in recent kernel versions. This patch
> > updates the codec driver to resolve the compilation errors related to
> > jack framework.
>
>
dynamic
> audio modules")
> Signed-off-by: Dan Carpenter
Thanks Dan for sharing this patch.
Reviewed-by: Vaibhav Agarwal
> ---
> drivers/staging/greybus/audio_helper.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greyb
On Thu, Jul 30, 2020 at 05:02:22PM +0100, Colin Ian King wrote:
> Hi,
>
> Static analysis with Coverity has detected an uninitialized value being
> used in a comparison. The error was detected on a recent change to
> drivers/staging/greybus/audio_topology.c however the issue actually
> dates back
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_topology.c | 123 +++
1 file changed, 57 insertions(+), 66 deletions(-)
diff --git a/drivers
This patch fixes the warning reported for missing prototypes due to
missing header file. Also, it includes changes to remove
unused_but_set_variables.
Reported-by: kernel test robot
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_helper.c | 1 +
drivers/staging/greybus
modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 12 +-
drivers/staging/greybus/audio_helper.c | 197
06200150.mnvj1duq%25...@intel.com/
Vaibhav Agarwal (7):
staging: greybus: audio: Update snd_jack FW usage as per new APIs
staging: greybus: audio: Maintain jack list within GB Audio module
staging: greybus: audio: Resolve compilation errors for GB codec
module
staging: greybus: audio:
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 74 +-
drivers/staging/greybus/audio_codec.h | 10 +++-
drivers
o I had to update the dependencies for GREYBUS_AUDIO to
make the compile work.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions(+), 3 deletions(-)
di
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 88
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 54 +--
1
On Wed, Jul 01, 2020 at 03:36:55PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Jun 19, 2020 at 04:50:26PM +0530, Vaibhav Agarwal wrote:
> > Currently you can't enable the Gey Bus Audio Codec because there is no
> > entry for it in the Kconfig file. Originally the config name
modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 12 +-
drivers/staging/greybus/audio_helper.c | 197
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 74 +-
drivers/staging/greybus/audio_codec.h | 10 +++-
drivers
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 88
o I had to update the dependencies for GREYBUS_AUDIO to
make the compile work.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions(+), 3 deletions(-)
di
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_topology.c | 123 +++
1 file changed, 57 insertions(+), 66 deletions(-)
diff --git a/drivers
2:
- Avoid defining unused 'update' pointer
- Fix the missing connect bool value required during mixer_update_power
- Added Reviewed-by tag from Dan
- Rebase to latest staging-next
Vaibhav Agarwal (6):
staging: greybus: audio: Update snd_jack FW usage as per new APIs
staging: greybus: audio
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
Reviewed-by: Dan Carpenter
---
drivers/staging/greybus/audio_codec.c | 54 +--
1
On Thu, Jun 11, 2020 at 09:26:16AM +0100, Mark Brown wrote:
> On Wed, Jun 10, 2020 at 11:53:24PM +0530, Vaibhav Agarwal wrote:
>
> > With patch#6 in this series, I'm proposing some of the (dummy) helper
> > APIs required to link DAPM DAI widgets for the GB Audio mod
On Wed, Jun 10, 2020 at 08:45:35PM +0300, Dan Carpenter wrote:
> On Wed, Jun 10, 2020 at 10:58:28PM +0530, Vaibhav Agarwal wrote:
> > @@ -437,11 +433,12 @@ static int gbcodec_mixer_dapm_ctl_put(struct
> > snd_kcontrol *kcontrol,
> > struct gbaudio_module_info *m
On Wed, Jun 10, 2020 at 06:37:11PM +0100, Mark Brown wrote:
> On Wed, Jun 10, 2020 at 10:58:24PM +0530, Vaibhav Agarwal wrote:
> > The existing GB Audio codec driver is dependent on MSM8994 Audio driver.
> > During the development stage, this dependency was configured due to
>
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c | 128 +++
1 file changed, 60 insertions(+), 68 deletions(-)
diff --git a/drivers/staging/greybus
modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 12 +-
drivers/staging/greybus/audio_helper.c | 197
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 88 +--
drivers/staging/greybus
o I had to update the dependencies for GREYBUS_AUDIO to
make the compile work.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/greyb
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 54 +--
1 file changed, 42 insertions
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 74 +-
drivers/staging/greybus/audio_codec.h | 10 +++-
drivers/staging/greybus/audio_module.c
necessary changes.
[1]
https://lore.kernel.org/lkml/20200507212912.599433-1-alexandre.bell...@bootlin.com/
Changes from v1
- Include the changes for the review comments suggested by Dan
- Rebase to latest staging-next
Vaibhav Agarwal (6):
staging: greybus: audio: Update snd_jack FW usage as per
On Tue, Jun 02, 2020 at 03:57:15PM +0300, Dan Carpenter wrote:
> On Tue, Jun 02, 2020 at 10:51:15AM +0530, Vaibhav Agarwal wrote:
> > Currently, GB codec and audio module is conditionally compiled based on
> > GREYBUS_AUDIO_MSM8994. However, audio module is not dependent on MSM89
modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 13 +-
drivers/staging/greybus/audio_helper.c | 197
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 87 +--
drivers/staging/greybus
represented by I2S port
available on Toshiba AP Bridge. Added config option for the same in
kconfig file and accordingly updated Makefile.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c | 130 +++
1 file changed, 61 insertions(+), 69 deletions(-)
diff --git a/drivers/staging/greybus
n/removal of
modules.
Patch 6: Finally provides config options and related Makefile changes to
enable GB Codec driver.
Thanks to Alexandre for raising the headsup [1] and motivating me to provide
the necessary changes.
[1]
https://lore.kernel.org/lkml/20200507212912.599433-1-alexandre.bell...@boot
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 76 ++
drivers/staging/greybus/audio_codec.h | 10 +++-
drivers/staging/greybus/audio_module.c
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 59 +--
1 file changed, 47 insertions
On Sun, May 17, 2020 at 07:37:06PM +0200, Alexandre Belloni wrote:
> Hi,
>
> On 17/05/2020 22:47:20+0530, Vaibhav Agarwal wrote:
> > Greybus Codec driver allows modules to be dynamically added and removed,
> > which further requires updating the DAPM configurations as well.
represented by I2S port
available on Toshiba AP Bridge. Added config option for the same in
kconfig file and accordingly updated Makefile.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Kconfig | 14 +-
drivers/staging/greybus/Makefile | 4 ++--
2 files changed, 15 insertions
modules which are dynamically added or removed. The
source is primarily based on snd_dapm.c
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/Makefile | 2 +-
drivers/staging/greybus/audio_codec.c | 13 ++-
drivers/staging/greybus/audio_helper.c | 197
snd_soc_jack APIs are modified in recent kernel versions. This patch
updates the codec driver to resolve the compilation errors related to
jack framework.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 59 ---
1 file changed, 47
Fix compilation errors for GB Audio topology parser code with recent
kernel versions.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c | 130 +++
1 file changed, 61 insertions(+), 69 deletions(-)
diff --git a/drivers/staging/greybus
maintained within gbaudio_module_info as well. This patch provides the
relevant changes for the same.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 76 ++
drivers/staging/greybus/audio_codec.h | 10 -
drivers/staging/greybus
necessary changes.
[1]
https://lore.kernel.org/lkml/20200507212912.599433-1-alexandre.bell...@bootlin.com/
Vaibhav Agarwal (6):
staging: greybus: audio: Update snd_jack FW usage as per new APIs
staging: greybus: audio: Maintain jack list within GB Audio module
staging: greybus: audio: Resolve
Due to dependencies on ASoC framework changes, GB dummy codec module
compilation is currently disabled. This patch updates codec driver as
per the latest ASoC APIs.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_codec.c | 87 +--
drivers/staging
On Wed, May 13, 2020 at 11:15 PM Mark Greer wrote:
>
> On Thu, May 07, 2020 at 11:29:11PM +0200, Alexandre Belloni wrote:
> > GREYBUS_AUDIO_MSM8994 is not an existing configuration option and as
> > reported in September 2016, it depends on an "out-of-tree qualcomm audio
> > driver". This driver n
ach_entry_safe(module, next, &modules_list, list) {
> list_del(&module->list);
> - kobject_put(&module->kobj);
> ida_simple_remove(&module_id, module->id);
> + kobject_put(&module->kobj);
>
er_module *module, *next;
> - int is_empty = 1;
> + int is_empty;
>
> down_write(&modules_rwsem);
>
> --
> 2.20.1
>
Reviewed-by: Vaibhav Agarwal
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
t
> gb_audio_manager_module_descriptor *desc)
> int err;
>
> id = ida_simple_get(&module_id, 0, 0, GFP_KERNEL);
> + if (id < 0)
> + return id;
> +
> err = gb_audio_manager_module_create(&module, manager_kset,
>
unt=%d for %s\n",
> w->ncontrols, w->name);
> return ret;
> }
> --
> 2.17.0
Acked-by: Vaibhav Agarwal
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
ging/greybus/audio_codec.h
> +++ b/drivers/staging/greybus/audio_codec.h
> @@ -23,7 +23,10 @@ enum {
> NUM_CODEC_DAIS,
> };
>
> -/* device_type should be same as defined in audio.h (Android media layer) */
> +/*
> + * device_type should be same as defined in audio
On Wed, Jan 3, 2018 at 3:09 PM, Sumit Pundir wrote:
> This patch fixes the following checkpatch.pl issue at multiple lines:
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t format, rate;
>
> Signed-off-by: Sumit Pundir
> ---
Hi Sumit,
Similar patches are already submitted
On Fri, Dec 22, 2017 at 4:50 PM, Kamal Heib wrote:
> Cleanup "Alignment should match open parenthesis" checkpatch.pl errors.
>
> Cc: Vaibhav Agarwal
> Signed-off-by: Kamal Heib
Hi Kamal,
Thanks for sharing cleanup patches. Kindly share the complete series
with greybus-de
ved.
>
> Cc: Vaibhav Hiremath
> Cc: Johan Hovold
> Cc: Alex Elder
> Cc: Greg Kroah-Hartman
> Cc: Vaibhav Agarwal
> Cc: Mark Greer
> Cc: Viresh Kumar
> Cc: Rui Miguel Silva
> Cc: David Lin
> Cc: "Bryan O'Donoghue"
ovold
> Cc: Alex Elder
> Cc: Greg Kroah-Hartman
> Cc: Vaibhav Hiremath
> Cc: Vaibhav Agarwal
> Cc: Mark Greer
> Cc: Viresh Kumar
> Cc: Rui Miguel Silva
> Cc: David Lin
> Cc: "Bryan O'Donoghue"
> Cc: Thomas Gleixner
> Cc: Kate Stewart
> Cc
t;
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t format, uint32_t rate, u8 channels,
>
> Signed-off-by: Marcos Paulo de Souza
> ---
Acked-by: Vaibhav Agarwal
___
devel mailing lis
From: Vaibhav Agarwal
Dummy codec register were initially added while populating dummy codec
mixer controls until module topology parser was available. Now, these
dummy registers are nowhere used and thus can be safely removed.
Since ASoC framework requires a valid callback for both read
mixer control->info call back function checks for -ve values to rebase
min and max values. However, le32 variable is used to fetch values from
GB module FW. Thus negative value checking is not required. Fix this!!
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c
From: Vaibhav Agarwal
Uninitialized variable sig_bits was used while configuring stream params
for codec module. These params are used to configure PCM settings for
APBridgeA.
Usually, this is dependent on codec capability and thus populated via
codec dai_driver definition. In our case, it is
From: Vaibhav Agarwal
Proper byte order was completely disregarded for multi byte data shared
between AP and module (and APB1). Fix this.
Signed-off-by: Vaibhav Agarwal
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_module.c | 2 +-
drivers/staging/greybus
ude review comments from Dan
Vaibhav Agarwal (4):
staging: greybus: audio: Avoid less than zero check for le32 variable
staging: greybus: audio: Initialize sig_bits before configuring
hwparams
staging: greybus: audio: Cleanup junk codec registers
staging: greybus: audio: Ensure proper
On Tue, Jan 17, 2017 at 11:22 PM, Mark Greer wrote:
> On Tue, Jan 17, 2017 at 08:19:30PM +0530, Vaibhav Agarwal wrote:
>> From: Vaibhav Agarwal
>>
>> Proper byte order was completely disregarded for multi byte data shared
>> between AP and module (and APB1). Fi
On Tue, Jan 17, 2017 at 11:04 PM, Mark Greer wrote:
> On Tue, Jan 17, 2017 at 08:19:29PM +0530, Vaibhav Agarwal wrote:
>> From: Vaibhav Agarwal
>>
>> Dummy codec register were initially added while populating dummy codec
>> mixer controls until module topology parse
On Tue, Jan 17, 2017 at 10:56 PM, Mark Greer wrote:
> Hi Vaibhav.
>
> On Tue, Jan 17, 2017 at 08:19:27PM +0530, Vaibhav Agarwal wrote:
>> mixer control->info call back function checks for -ve values to rebase
>> min and max values. However, le32 variable is used to fetch
From: Vaibhav Agarwal
Proper byte order was completely disregarded for multi byte data shared
between AP and module (and APB1). Fix this.
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_module.c | 2 +-
drivers/staging/greybus/audio_topology.c | 88
From: Vaibhav Agarwal
Uninitialized variable sig_bits was used while configuring stream params
for codec module. These params are used to configure PCM settings for
APBridgeA.
Usually, this is dependent on codec capability and thus populated via
codec dai_driver definition. In our case, it is
From: Vaibhav Agarwal
Dummy codec register were initially added while populating dummy codec
mixer controls until module topology parser was available. Now, these
dummy registers are nowhere used and thus can be safely removed.
Since ASoC framework requires a valid callback for both read
ude review comments from Dan
Vaibhav Agarwal (4):
staging: greybus: audio: Avoid less than zero check for le32 variable
staging: greybus: audio: Initialize sig_bits before configuring
hwparams
staging: greybus: audio: Cleanup junk codec registers
staging: greybus: audio: Ensure proper
mixer control->info call back function checks for -ve values to rebase
min and max values. However, le32 variable is used to fetch values from
GB module FW. Thus -ve value checking is not required. Fix this!!
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c |
On Mon, Jan 16, 2017 at 4:17 PM, Dan Carpenter wrote:
> On Sat, Jan 14, 2017 at 11:17:07PM +0530, Vaibhav Agarwal wrote:
>> @@ -656,13 +660,13 @@ static int gbaudio_tplg_create_enum_kctl(struct
>> gbaudio_module_info *gb,
>> gb_enum = &ctl->info.value.enumerated
mixer control->info call back function checks for -ve values to rebase
min and max values. However, le32 variable is used to fetch values from
GB module FW. Thus -ve value checking is not required. Fix this!!
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c |
From: Vaibhav Agarwal
Uninitialized variable sig_bits was used while configuring stream params
for codec module. These params are used to configure PCM settings for
APBridgeA.
Usually, this is dependent on codec capability and thus populated via
codec dai_driver definition. In our case, it is
From: Vaibhav Agarwal
Proper byte order was completely disregarded for multi byte data shared
between AP and module (and APB1). Fix this.
Signed-off-by: Vaibhav Agarwal
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_module.c | 2 +-
drivers/staging/greybus
this requires
pushing some changes in ASoC framework. Possibly in another two weeks
(based on my freetime), I'll try to submit those changes to ASoC mailing
list. And once the same are accepted there, I'll share relevant patches
for GB Audio codec driver as well.
Vaibhav Agarwal (4):
From: Vaibhav Agarwal
Dummy codec register were initially added while populating dummy codec
mixer controls until module topology parser was available. Now, these
dummy registers are nowhere used and thus can be safely removed.
Since ASoC framework requires a valid callback for both read
On Mon, Oct 17, 2016 at 9:01 PM, Johan Hovold wrote:
> On Sun, Oct 16, 2016 at 03:29:14PM +0530, Pankaj Bharadiya wrote:
>> gb_audio_manager_module_descriptor's cport field is actually used to
>> manage and pass interface id to user space.
>>
>> Thus rename gb_audio_manager_module_descriptor's 'cp
ices=0x%X o/p
> devices=0x%X",
> + desc.name, &desc.vid, &desc.pid, &desc.intf_id,
> + &desc.ip_devices, &desc.op_devices);
>
> if (num != 7)
> return -EINVAL;
> diff --git a/drivers/staging/greybus
gt; + &desc.intf_id, &desc.ip_devices, &desc.op_devices);
>
> if (num != 7)
> return -EINVAL;
> diff --git a/drivers/staging/greybus/audio_module.c
> b/drivers/staging/greybus/audio_module.c
> i
On Wed, Oct 12, 2016 at 5:19 AM, Chase Metzger wrote:
> Added braces for else and else if statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger
> ---
> drivers/staging/greybus/audio_topology.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/driv
gb_audio_manager_dump_all();
> - else
> + } else {
> return -EINVAL;
> + }
>
> return count;
> }
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
; ret = -EINVAL;
> + }
> +
> if (ret)
> dev_err_ratelimited(dai->dev,
> "%s:Error during %s %s stream:%d\n",
> --
> 2.1.4
>
Reviewed-by: Vaibhav Agarwal
On Fri, Oct 7, 2016 at 8:08 AM, Chase Metzger wrote:
> Added braces to else statements where checkpatch complained.
>
> Signed-off-by: Chase Metzger
> ---
Reviewed-by: Vaibhav Agarwal
___
devel mailing list
de...@linuxdriverproj
Ian King
Signed-off-by: Vaibhav Agarwal
---
drivers/staging/greybus/audio_topology.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_topology.c
b/drivers/staging/greybus/audio_topology.c
index f9f33817a092..b6251691a33d 100644
--- a/driv
On Fri, Sep 23, 2016 at 10:28 PM, Greg Kroah-Hartman
wrote:
> On Fri, Sep 23, 2016 at 11:25:40AM +0100, Colin King wrote:
>> From: Colin Ian King
>>
>> Currently, if info is null, the dev_err message is dereferencing an
>> uninitialized module pointer. Instead, initialize module before the
>> de
92 matches
Mail list logo