Re: [Outreachy kernel] [PATCH 1/2] staging: kpc2000: resolve various code style issues

On Wed, Oct 21, 2020 at 8:33 AM Deepak R Varma wrote: > > Multiple issues reported by checkpatch script around lines exceeding 100 > columns, indentation of function parameters, extra blank lines. These > code formatting changes improves the code readability. Please send separate patches while

Re: [Outreachy kernel] [PATCH 1/3] staging/rtl8712: remove extra blank lines; fix code alignment

On Wed, Oct 21, 2020 at 12:01 AM Elena Afanasova wrote: > > Reported by checkpatch.pl > > Signed-off-by: Elena Afanasova This patch is fixing 2 different checkpatch warnings. They should be sent as separate patches. One for removing extra blank lines, another one for fixing the code alignment.

Re: [Outreachy kernel] [PATCH] staging/rtl8188eu: fix line length exceeds 100 columns

On Tue, Oct 20, 2020 at 8:56 PM Elena Afanasova wrote: > > Reported by checkpatch.pl Hi Elena, Thanks for your patches. Your commit log should mention why are you doing certain changes. Above commit log doesn't give reviewer/maintainer an idea about what are you fixing and why that change is

Re: [Outreachy kernel] Re: [PATCH v2 4/6] staging: fbtft: Fix sparse warnings of incorrect type in assignment

On Sun, Mar 5, 2017 at 10:10 AM, SIMRAN SINGHAL wrote: > On Sun, Mar 5, 2017 at 5:36 AM, Alison Schofield wrote: >> On Thu, Mar 02, 2017 at 02:26:37PM +0100, Noralf Trønnes wrote: >>> >>> Den 02.03.2017 14.04, skrev simran singhal: >>> >This patch

Re: [PATCH v3] staging: rtl8192e: remove unnecesary whitespace in rtl_wx.c

On Wednesday 01 March 2017 03:23 PM, Sumantro wrote: Remove unnecessary whitespaces in rtl_wc. Problem found by checkpatch.pl. Signed-off-by: Sumantro You went back to the same state again. :( Your from and signed-off-by should have this format: 'firstname lastname

Re: [PATCH] staging/rtl8192e fixed checkpatch.pl warnings in rtl_wx.c

On Tuesday 28 February 2017 07:21 PM, Sumantro wrote: Fixed Warning rasied by checkpatch.pl Hi, Usually we prefer to have subject stating what change is done and commit log stating why that change is done instead of stating tool name. Though you can give credit to the tool in the commit log

Re: [PATCH v4] staging: greybus: Fix a commit coding style issue.

On Monday 03 October 2016 04:21 PM, Sidhant Gupta wrote: > Fixes a comment coding style warning by adding 2 blank lines. Issue > found by checkpatch. > > Signed-off-by: Sidhant Gupta <guptasidhant...@gmail.com> Reviewed-by: Vaishali Thakkar <vaishali.thak...@oracle.com

Re: [PATCH] speakup: Add spinlock in synth_direct_store

Andrianov <andria...@ispras.ru> Acked-by: Vaishali Thakkar <vaishali.thak...@oracle.com> > --- > drivers/staging/speakup/kobjects.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/speakup/kobjects.c > b/drivers/staging/sp

Re: [PATCH] staging: rtl8192e: rtllib_softmac.c: Remove multiple blank lines

On Sunday 28 February 2016 08:18 PM, Tapan Prakash T wrote: > Fixed blank lines issues reported by checkpatch.pl Hi, I can see that you have sent 3 patches for the same file. But they are sent as separate patches. So, this might be confusing for the maintainer. So, in this case these are some

Re: [PATCH] Staging:wilc1000 :Remove braces for single statement blocks

On 31 Jul 2015 10:49, Shraddha Barke shraddha.6...@gmail.com wrote: This patch fixes the following checkpatch.pl warning: WARNING: braces {} are not necessary for single statement blocks There should be one line space between your commit log and Signed-off-by line. Signed-off-by: Shraddha

[PATCH] Staging: rtl8192u: Replace memset with eth_zero_addr

is as follows: // smpl @eth_zero_addr@ expression e; @@ -memset(e,0x00,6); +eth_zero_addr(e); // /smpl Signed-off-by: Vaishali Thakkar vthakkar1...@gmail.com --- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] Staging: rtl8192e: Replace memset with eth_zero_addr

is as follows: // smpl @eth_zero_addr@ expression e; @@ -memset(e,0x00,6); +eth_zero_addr(e); // /smpl Signed-off-by: Vaishali Thakkar vthakkar1...@gmail.com --- drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 2 files changed, 2 insertions(+), 2

[PATCH] Staging: wilc1000: Replace memset with eth_zero_addr

Signed-off-by: Vaishali Thakkar vthakkar1...@gmail.com --- drivers/staging/wilc1000/linux_mon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wilc1000/linux_mon.c b/drivers/staging/wilc1000/linux_mon.c index f5296f5..2a3d875 100644 --- a/drivers/staging

[PATCH] staging: wlan-ng: Use setup_timer

This patch introduces the use of function setup_timer. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,y,z; @@ - init_timer (x); + setup_timer (x, y, z); - x.function = y; - x.data = z; Signed-off-by: Vaishali Thakkar vthakkar1...@gmail.com --- drivers

[PATCH] staging: comedi: Use setup_timer

This patch introduces the use of function setup_timer. This is done using Coccinelle and semantic patch used is as follows: @@ expression x,y,z; @@ - init_timer (x); + setup_timer (x, y, z); - x.function = y; - x.data = z; Signed-off-by: Vaishali Thakkar vthakkar1...@gmail.com --- drivers

[PATCH] Staging: rtl8192u: Use put_unaligned_le16 in rtl819x_BAProc.c

!= tmp ( - memcpy(ptr, (T)tmp, \(2\|sizeof(u16)\|sizeof(__le16)\|sizeof(uint16_t)\|sizeof(e16)\)); + put_unaligned_le16(y,ptr); | - memcpy(ptr, (T)tmp, ...); + put_unaligned_le16(y,ptr); ) ...+ ? tmp = e @@ type T; identifier a.tmp; @@ - T tmp; ...when != tmp Signed-off-by: Vaishali Thakkar

[PATCH] Staging: rtl8192u: Remove check of ieee in rtl819x_BAProc.c

This patch fixes following smatch warning: drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c:117 ieee80211_ADDBA() warn: variable dereferenced before check 'ieee' (see line 114) As ieee can not be NULL at this point, all such checks are removed. Signed-off-by: Vaishali Thakkar vthakkar1