[PATCH v2 6/6] staging: rtl8723bs: core: Move logical operator to previous line.

2019-05-05 Thread Vatsala Narang
Move logical operator to previous line to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging

[PATCH v2 5/6] staging: rtl8723bs: core: Fix variable constant comparisons.

2019-05-05 Thread Vatsala Narang
Swap the terms of comparisons whenever the constant comes first to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

[PATCH v2 3/6] staging: rtl8723bs: core: Remove unnecessary parentheses.

2019-05-05 Thread Vatsala Narang
Remove unnecessary parentheses after 'address-of' operator to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core

[PATCH v2 4/6] staging: rtl8723bs: core: Remove braces from single if statement.

2019-05-05 Thread Vatsala Narang
Remove braces from single if statement to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers

[PATCH v2 2/6] staging: rtl8723bs: core: Replace NULL comparisons.

2019-05-05 Thread Vatsala Narang
Replace NULL comparisons in the file to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b

[PATCH v2 1/6] staging: rtl8723bs: core: Remove blank line.

2019-05-05 Thread Vatsala Narang
To avoid style issues, remove multiple blank lines. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index

[PATCH v2 0/6] staging: rtl8723bs: core: Fix checkpatch warnings.

2019-05-05 Thread Vatsala Narang
as it had some compilatin error. Vatsala Narang (6): staging: rtl8723bs: core: Remove blank line. staging: rtl8723bs: core: Replace NULL comparisons. staging: rtl8723bs: core: Remove unnecessary parentheses. staging: rtl8723bs: core: Remove braces from single if statement. staging

[PATCH 6/7] staging: rtl8723bs: core: Fix variable constant comparisons.

2019-05-04 Thread Vatsala Narang
Swap the terms of comparisons whenever the constant comes first to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c

[PATCH 5/7] staging: rtl8723bs: core: Remove braces from single if statement.

2019-05-04 Thread Vatsala Narang
Remove braces from single if statement to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers

[PATCH 7/7] staging: rtl8723bs: core: Moved logical operator to previous line.

2019-05-04 Thread Vatsala Narang
Moved logical operator to previous line to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging

[PATCH 4/7] staging: rtl8723bs: core: Remove unnecessary parentheses.

2019-05-04 Thread Vatsala Narang
Remove unnecessary parentheses after 'address-of' operator to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core

[PATCH 0/7] staging: rtl8723bs: core: Fix various checkpatch

2019-05-04 Thread Vatsala Narang
This series fix the following warnings: -Remove multiple blank lines. -Remove return in void function. -Replace NULL comparison. -Remove unnecessary parentheses. -Remove braces from single if statement. -Fix variable constant comparison. -Move logical operator to previous line. Vatsala Narang (7

[PATCH 3/7] staging: rtl8723bs: core: Replace NULL comparisons.

2019-05-04 Thread Vatsala Narang
Replace NULL comparisons in the file to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b

[PATCH 2/7] staging: rtl8723bs: core: Remove return in void function.

2019-05-04 Thread Vatsala Narang
Remove return in void function to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core

[PATCH 1/7] staging: rtl8723bs: core: Remove blank line.

2019-05-04 Thread Vatsala Narang
To avoid style issues, remove multiple blank lines. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c index

[PATCH] staging: rtl8723bs: core: Prefer using the BIT Macro.

2019-05-01 Thread Vatsala Narang
Replace bit shifting on 1 with the BIT(x) macro. Issue found using coccinelle. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers

[PATCH] staging: rtl8723bs: core: Use !x in place of NULL comparison.

2019-05-01 Thread Vatsala Narang
Avoid NULL comparison, compare using boolean operator. Issue found using coccinelle. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_io.c | 2 +- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] staging: iio: adc: Add paragraph to describe Kconfig symbol

2019-05-01 Thread Vatsala Narang
This patch updates Kconfig with paragraph that describe config symbol fully.Issue addressed by checkpatch. Signed-off-by: Vatsala Narang --- drivers/staging/iio/adc/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/iio/adc/Kconfig b/drivers/staging/iio/adc/Kconfig

[PATCH v2] staging: vc04_services: bcm2835-camera: Compress two lines into one line

2019-04-30 Thread Vatsala Narang
Return value directly without saving it in a variable and remove that variable. Issue suggested by Coccinelle. Signed-off-by: Vatsala Narang --- Changes in v2: -Change subject line and log message -Remove respective unused variable drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c

[PATCH] staging: vc04_services: bcm2835-camera: Modify return statement.

2019-04-29 Thread Vatsala Narang
Modify return statement and remove the respective assignment. Issue found by coccinelle. Signed-off-by: Vatsala Narang --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835

[PATCH] staging: rtl8723bs: core: Remove blank line.

2019-04-28 Thread Vatsala Narang
To avoid style issues, remove multiple blank lines. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c index

[PATCH] staging: rtl8723bs: core: Remove else after return statement.

2019-04-28 Thread Vatsala Narang
Remove else after return statement as it is not useful. Issue found using checkpatch. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers

[PATCH 2/2] staging: rtl8723bs: core: Remove else after return statement.

2019-04-28 Thread Vatsala Narang
Remove else after return statement as it is not useful. Issue found using checkpatch. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers

[PATCH] staging: vc04_services: bcm2835-camera: Modify return statement.

2019-04-27 Thread Vatsala Narang
Modify return statement and remove the respective assignment. Issue found by Coccinelle. Signed-off-by: Vatsala Narang --- drivers/staging/vc04_services/bcm2835-camera/controls.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835

[PATCH v2 2/2] staging: rtl8192u: ieee80211: Fix spelling mistake

2019-04-26 Thread Vatsala Narang
Replace explicitely with explicitly to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- Changes in v2: -added this patch to patchset to fix spelling mistake. drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v2 1/2] staging: rtl8192u: ieee80211: Replace bit shifting with BIT macro

2019-04-26 Thread Vatsala Narang
Change suggested by coccinelle. Replace bit shifting on 1 with the BIT(x) macro. Coccinelle script: @@ expression c; @@ -(1 << c) +BIT(c) Signed-off-by: Vatsala Narang --- Changes in v2: -changed log message -added space around '&' opreator and after 'if' -added another patch to fi

[PATCH] staging: rtl8723bs: core: Remove return in void function

2019-04-25 Thread Vatsala Narang
Remove return in void function to get rid of checkpatch warning. Signed-off-by: Vatsala Narang --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index

[PATCH] staging: rtl8192u: ieee80211: Replace bit shifting with BIT macro

2019-04-25 Thread Vatsala Narang
Challenge suggested by coccinelle. Replace bit shifting on 1 with the BIT(x) macro. Coccinelle script: @@ expression c; @@ -(1 << c) +BIT(c) Signed-off-by: Vatsala Narang --- drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)