On Thu, Apr 19, 2018 at 03:47:10AM -0300, Andrew Jye Shih Chuang wrote:
> Increase readability of code following the Kernel coding style by breaking
> long lines and thus eliminating the checkpatch.pl warning.
>
> Signed-off-by: Andrew Jye Shih Chuang
> ---
> drivers/staging/speakup/main.c | 15
pt it.
Sorry for the delay, still trying to catch up with my e-mails.
Acked-by: Willy Tarreau
Thanks,
willy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Mon, Jan 25, 2016 at 06:19:44PM +0530, Sudip Mukherjee wrote:
> On Mon, Jan 25, 2016 at 03:40:41PM +0300, Dan Carpenter wrote:
> > Ying, could you CC the subsystem list for these reports? This one was
> > CC'd to Sirnam, Greg and LKML. Sirnam is too new to understand what
> > they mean, Greg i
Hello Arthur,
On Wed, Jan 20, 2016 at 03:09:20PM -0600, Arthur Marble wrote:
> This patch fixes 'Lines longer than 80 columns' and 'No space is necessary
> after
> a cast' warnings in /drivers/staging/panel/panel.c.
Thank you but this one has already been proposed twice and I think the
last one
Hi Ksenija,
several points, see below.
On Tue, Dec 29, 2015 at 09:11:03PM +0100, Ksenija Stanojevic wrote:
> Broke statement into 3 different lines to make it more readable.
>
> Signeded-off-by: Ksenija Stanojevic
^^
Extra "ed". Don't waste your time typing it by hand, several git comma
On Tue, Dec 29, 2015 at 03:59:26PM -0500, Ilia Mirkin wrote:
> On Tue, Dec 29, 2015 at 3:08 PM, Ksenija Stanojevic
> wrote:
> > Remove ULL since it's useless.
> >
> > Signed-off-by: Ksenija Stanojevic
> > ---
> > drivers/staging/panel/panel.c | 12 ++--
> > 1 file changed, 6 insertions(+
Hi Dan,
Thanks for your review, I'm adding a few extra comments below.
On Mon, Dec 28, 2015 at 06:27:36PM +0300, Dan Carpenter wrote:
> On Mon, Dec 28, 2015 at 12:32:39PM +0100, Ksenija Stanojevi?? wrote:
> > Hi Willy,
> >
> > I'm helping Greg do a bit of cleanup in the staging tree, I noticed t
Hi Ksenija,
On Mon, Dec 28, 2015 at 12:32:39PM +0100, Ksenija Stanojevi?? wrote:
> Hi Willy,
>
> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
> panel driver is maybe ready to be moved to drivers/misc.
I think so as well, we discussed this with Greg 6 months ago or so
On Sat, Dec 19, 2015 at 11:55:13AM +0530, Sudip Mukherjee wrote:
> On Fri, Dec 18, 2015 at 08:01:58AM -0800, Greg KH wrote:
> > On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> > > From: Bijosh T
> > >
> > > This patch fixes coding style errors for staging/panel driver.
> > >
> > > Si
I'm realizing that I sometimes miss e-mails sent to my old address, so
better update it. Since I only have the relevant hardware at my work place,
let's use this address so that I can test code if needed.
Signed-off-by: Willy Tarreau
---
MAINTAINERS| 2 +-
drivers/sta
On Fri, Dec 18, 2015 at 02:48:58PM +0530, Bijosh T wrote:
> From: Bijosh T
>
> This patch fixes coding style errors for staging/panel driver.
>
> Signed-off-by: Bijosh T
Acked-by: Willy Tarreau
Thanks Bijosh,
Willy
___
devel
On Tue, Nov 10, 2015 at 07:35:30PM +0100, Daniel H. Hemmingsen wrote:
> Fixed a spacing after cast coding style issue.
>
> Signed-off-by: Daniel H. Hemmingsen
Acked-by: Willy Tarreau
Thanks,
Willy
___
devel mailing list
de...@linuxdriverpr
On Thu, Aug 27, 2015 at 09:02:46PM +0530, nayeem wrote:
> From: Nayeemahmed Badebade
>
> Fixed warnings reported by checkpatch.pl:
> - Block comments use a trailing */ on a separate line
> - Block comments use * on subsequent lines
>
> Signed-off-by: Nayeemahmed Badeb
On Wed, Aug 05, 2015 at 10:43:23PM +0300, Lior Pugatch wrote:
> This patch fixes checkpatch.pl warning,
> all warnings are releted to comments code style.
Acked-by: Willy Tarreau
Thanks!
Willy
___
devel mailing list
de...@linuxdriverproject.or
ies which handles all
> corner-cases correctly, was used.
>
> Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
> CONFIG_PARPORT=m, CONFIG_PANEL=m
>
> Signed-off-by: Nicholas Mc Guire
Acked-by: Willy Tarreau
> ---
> Patch is against 4.1-rc5 (localversion-nex
On Wed, May 20, 2015 at 05:46:44PM +0200, Richard Weinberger wrote:
> On Wed, May 20, 2015 at 5:27 PM, Sudip Mukherjee
> wrote:
> > Lets give the parport subsystem a proper name and start
> > maintaining the files.
>
> Excuse me, but usually someone takes over the maintainer role after
> proving
On Wed, May 20, 2015 at 06:02:06PM -0700, Joe Perches wrote:
> Perhaps space aligned declarations should have some
> checkpatch --strict warning for 2 or more spaces
> around any assignment of the declaration.
>
> int a = 1;// 2+ spaces before =
> int b = 2;
On Mon, May 11, 2015 at 04:42:19PM +0530, Sudip Mukherjee wrote:
> if we load the module, unload and then again try to load the module, we
> will get a stackdump. In the module_exit function we are unregistering
> the device and releasing the parport. So when we reach the detach
> function parport
On Wed, Apr 08, 2015 at 03:27:37PM +0300, Dan Carpenter wrote:
> On Wed, Apr 08, 2015 at 05:20:10PM +0530, Sudip Mukherjee wrote:
> > On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote:
> > > 1) We can't apply this patch on its own so this way of breaking up the
> > > patches doesn't wor
On Tue, Apr 07, 2015 at 07:51:17PM +0530, Sudip Mukherjee wrote:
> On Tue, Apr 07, 2015 at 04:14:59PM +0200, Willy Tarreau wrote:
> > Not-so-old laptops used to have parport connectors for a while, and can be
> > found at a very cheap price or even for free by now with dead ba
On Tue, Apr 07, 2015 at 12:12:06PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 07, 2015 at 03:26:58PM +0530, Sudip Mukherjee wrote:
> > On Tue, Apr 07, 2015 at 11:44:29AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 07, 2015 at 02:55:02PM +0530, Sudip Mukherjee wrote:
> > > > On Tue, Apr 0
D204A lcd with LCD_TYPE_CUSTOM configuration.
>
> Cc: # 2.6.32+
> Signed-off-by: Sudip Mukherjee
> ---
>
> v3: added the module_parameters
> v2: cc-ed stable
Acked-by: Willy Tarreau
[ next time I'll read my mails in reverse order :-) ]
Willy
_
On Tue, Mar 24, 2015 at 02:56:33PM +0530, Sudip Mukherjee wrote:
> with reference to the previous patch of the series, fixed the
> lcd type in module parameters.
Sudip, it's better to avoid fragmenting patches like you did, because
it will result in a kernel state where there is an inconsistency b
On Tue, Mar 24, 2015 at 01:22:16PM +0530, Sudip Mukherjee wrote:
> On Tue, Mar 24, 2015 at 08:04:11AM +0100, Willy Tarreau wrote:
> > Hi Sudip!
> >
> > On Tue, Mar 24, 2015 at 10:18:10AM +0530, Sudip Mukherjee wrote:
> > > the lcd type as defined in the Kconf
Hi Sudip!
On Tue, Mar 24, 2015 at 10:18:10AM +0530, Sudip Mukherjee wrote:
> the lcd type as defined in the Kconfig is not matching in the code.
> as a result the rs, rw and en pins were getting interchanged.
> Kconfig defines the value of PANEL_LCD to be 1 if we select custom
> configuration but
On Mon, Mar 16, 2015 at 12:25:31PM +0300, Dan Carpenter wrote:
> Both "bits.e" and "BIT_CHK(bits, LCD_BIT_E_MASK)" are terrible. The new
> one is worse because it takes more words to tell you nothing and because
> it is wrong since E is a flag not a mask.
Yep, I agree. Maybe simply renaming "bits
Hello,
On Sat, Mar 14, 2015 at 11:14:43AM +0100, Isaac Lleida wrote:
> This path implements a bit array representing the LCD signal states instead
> of the old "struct bits", which used char to represent a single bit. This
> will reduce the memory usage.
>
> Signed-off-by: Isaac Lleida
> ---
>
On Mon, Mar 09, 2015 at 08:08:24PM +0530, Sudip Mukherjee wrote:
> we were returning success even if the module failed to register.
> now we are returning the actual return value, success or error.
>
> Signed-off-by: Sudip Mukherjee
Thanks for this.
Acked-by: Willy Tar
On Mon, Mar 09, 2015 at 07:05:59PM +0530, Sudip Mukherjee wrote:
> On Mon, Mar 09, 2015 at 07:30:07AM +0100, Willy Tarreau wrote:
> > On Sun, Mar 08, 2015 at 11:07:25PM +0530, Sudip Mukherjee wrote:
> > >
> > > - if (parport_register_driver(&panel_driver)) {
&g
On Sun, Mar 08, 2015 at 11:07:25PM +0530, Sudip Mukherjee wrote:
> we were returning success even if the module failed to register.
> now we are returning the actual return value, success or error.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/panel/panel.c | 7 +--
> 1 file cha
r the module has initialized.
>
> Signed-off-by: Sudip Mukherjee
Acked-by: Willy Tarreau
willy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
nd similarly unregister at detach.
>
> Signed-off-by: Sudip Mukherjee
Acked-by: Willy Tarreau
Willy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Feb 10, 2015 at 05:26:02PM +0530, Sudip Mukherjee wrote:
> register the driver only if lcd or keypad has been enabled and if
> both are disabled then just exit.
>
> Signed-off-by: Sudip Mukherjee
Acked-by: Willy Tarreau
Willy
_
On Tue, Feb 10, 2015 at 05:26:03PM +0530, Sudip Mukherjee wrote:
> initialiaze lcd parameters only if lcd is enabled.
>
> Signed-off-by: Sudip Mukherjee
One minor comment below (cosmetic), but after this it's OK.
Acked-by: Willy Tarreau
> +
hat awful! Obvious ack.
Acked-by: Willy Tarreau
Thanks,
willy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
to be missing it :-)
Acked-by: Willy Tarreau
Willy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Nov 27, 2014 at 08:50:55PM +0100, Mariusz Gorski wrote:
> > And the reason I got confused was because you didn't label your second
> > set of patches "v2", which it was, I saw two separate series, one with a
> > few patches, and then 2 sets of 9, the second set labeled "v2" so I
> > thought
On Thu, Nov 27, 2014 at 07:57:06AM -0800, Greg Kroah-Hartman wrote:
> And the reason I got confused was because you didn't label your second
> set of patches "v2", which it was, I saw two separate series, one with a
> few patches, and then 2 sets of 9, the second set labeled "v2" so I
> thought the
Hi Mariusz,
On Wed, Nov 19, 2014 at 09:38:42PM +0100, Mariusz Gorski wrote:
> This set of patches focuses on making current initialization
> process easier to understand - especially it tries to emphasize
> what are the priorities of the params coming from different
> sources (Kconfig values, devi
On Wed, Nov 19, 2014 at 09:38:50PM +0100, Mariusz Gorski wrote:
> Use a defined value instead of magic number comparison
> for checking whether a module param value has been set.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
_
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
m values etc).
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Wed, Nov 19, 2014 at 09:38:46PM +0100, Mariusz Gorski wrote:
> Avoid magic number and use a comparison with a defined value instead
> that checks whether module param has been set by the user to some
> value at loading time.
>
> Signed-off-by: Mariusz Gorski
Acked-by
On Tue, Nov 18, 2014 at 10:51:08PM +0100, Mariusz Gorski wrote:
> On Tue, Nov 18, 2014 at 10:23:26PM +0100, Willy Tarreau wrote:
> > On Tue, Nov 18, 2014 at 09:56:12PM +0100, Mariusz Gorski wrote:
> > > Rework lcd_init method to make it a little bit more clear about
> >
On Tue, Nov 18, 2014 at 10:50:35PM +0100, Mariusz Gorski wrote:
> On Tue, Nov 18, 2014 at 10:20:34PM +0100, Willy Tarreau wrote:
> > On Tue, Nov 18, 2014 at 09:56:11PM +0100, Mariusz Gorski wrote:
> > > Make keypad_type and lcd_type module params read-only.
> > > This
On Tue, Nov 18, 2014 at 09:56:14PM +0100, Mariusz Gorski wrote:
> Move more or less all LCD-related state into struct lcd
> in order to get better cohesion; use bool instead of int
> where it makes sense.
>
> Signed-off-by: Mariusz Gorski
Acked-by
On Tue, Nov 18, 2014 at 09:56:13PM +0100, Mariusz Gorski wrote:
> Use a macro instead of magic number comparison for checking
> whether a module param value has been set.
>
> Signed-off-by: Mariusz Gorski
> ---
> drivers/staging/panel/panel.c | 21 +++--
> 1 file changed, 11 inse
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
I like this refactoring. However I don't know if you got your LCD module
to work or not, but for such important changes you should definitely test
the code, since it's very easy to introduce minor bugs or even to fix a
bug
On Tue, Nov 18, 2014 at 09:56:11PM +0100, Mariusz Gorski wrote:
> Make keypad_type and lcd_type module params read-only.
> This step also starts making it more clear what is
> the precedence of device params coming from different
> sources (device profile, runtime module param values etc).
>
> Sig
On Tue, Nov 18, 2014 at 09:56:10PM +0100, Mariusz Gorski wrote:
> Start decoupling module params from the actual device state,
> both for lcd and keypad, by keeping the params read-only
> and moving the device state to related structs.
>
> Signed-off-by: Mariusz Gorski
Acked-by
On Tue, Nov 18, 2014 at 09:56:09PM +0100, Mariusz Gorski wrote:
> Avoid values comparison and use a macro instead that checks
> whether module param has been set by the user to some value
> at loading time.
>
> Signed-off-by: Mariusz Gorski
> ---
> drivers/staging/panel/panel.c | 88
> +
On Tue, Nov 18, 2014 at 09:56:07PM +0100, Mariusz Gorski wrote:
> Remove useless function and let the kernel call the actual
> init function directly.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
___
devel mai
On Tue, Nov 18, 2014 at 09:56:08PM +0100, Mariusz Gorski wrote:
> Get rid of magic numbers indicating that the value of a module param
> is not set. Use a defined value instead.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
_
On Tue, Nov 18, 2014 at 09:56:06PM +0100, Mariusz Gorski wrote:
> Set default parport module param value to DEFAULT_PARPORT so that
> a if-block can be avoided.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy Tarreau
___
devel mai
order module parameter declarations
> staging: panel: Use better names for two defined values
Whole patchset Acked-By: Willy Tarreau
BTW Mariusz, please use this e-mail address instead of the meta-x.org
one in the future.
Thanks,
Willy
___
devel mai
On Wed, Nov 05, 2014 at 12:51:22PM +0100, Mariusz Gorski wrote:
> On Wed, Nov 05, 2014 at 01:19:10PM +0300, Dan Carpenter wrote:
> > On Tue, Nov 04, 2014 at 10:47:19PM +0100, Mariusz Gorski wrote:
> > > Fix the implementation of a single-open policy for both
> > > devices (lcd and keypad) by using
Hi Mariusz,
On Wed, Oct 29, 2014 at 11:32:30PM +0100, Mariusz Gorski wrote:
> Fix "warning: missing initializer [-Wmissing-field-initializers]"
> by using designated struct initializers.
>
> Signed-off-by: Mariusz Gorski
Acked-by: Willy T
On Thu, Jul 10, 2014 at 03:34:28AM -0700, Vincent Heuken wrote:
> Fixed one instance of the following checkpatch.pl warning in
> panel.c:
> WARNING: else is not generally useful after a break or return
>
> Signed-off-by: Vincent Heuken
Acked-By: Willy Tarreau
Vincent, ar
On Fri, Jun 20, 2014 at 11:46:45AM -0700, Greg KH wrote:
> On Fri, Jun 20, 2014 at 09:39:26PM +0300, Kristina Mart??enko wrote:
> > On 20/06/14 19:52, Willy Tarreau wrote:
> > > Hi Kristina,
> > >
> > > On Fri, Jun 20, 2014 at 06:35:03PM +0300, Krist
Hi Kristina,
On Fri, Jun 20, 2014 at 06:35:03PM +0300, Kristina Mart?enko wrote:
> Hi Willy,
>
> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> nobody seems to have worked towards moving panel out of staging in over
> a year. Are there any plans to clean it up and move
On Wed, Apr 23, 2014 at 07:35:02PM +0200, Bastien Armand wrote:
> On Tue, Apr 22, 2014 at 01:01:45PM +0300, Dan Carpenter wrote:
> > Btw, this whole function is terrible. It should be reading larger
> > chunks at once instead of get_user() for each character.
Just for the record, very small chara
panel: fix sparse warnings in lcd_write
Just reviewed them both and I'm fine with these patches. You can
add my :
Acked-by: Willy Tarreau
Willy
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Thu, Apr 10, 2014 at 12:05:52AM -0700, narasimharo bolisetti wrote:
> My kernel version is:
> 2.6.35.6-45.fc14.i686
Maintenance for this kernel has been dropped years ago, so it very
likely contains many bugs that were fixed in more recent ones. You
should definitely upgrade.
Hoping this he
On Thu, Apr 03, 2014 at 06:59:09PM +0200, armand.bast...@laposte.net wrote:
> This patch fixes "Missing a blank line after declarations" checkpatch warning
> in panel.c.
Acked-By: Willy Tarreau
Thanks Bastien for this.
Willy
___
de
64 matches
Mail list logo
