[PATCH v3] staging: gdm72xx: add userspace data struct

2015-12-11 Thread Wim de With
This fixes the sparse warnings about dereferencing a userspace pointer. Once I updated the sparse annotations, I noticed a bug in gdm_wimax_ioctl() where we pass a user space pointer to gdm_update_fsm() which dereferences it. I fixed this. Signed-off-by: Wim de With --- drivers/staging/gdm72xx

Re: [PATCH v2] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
On Thu, Dec 10, 2015 at 02:44:45PM +, One Thousand Gnomes wrote: > (except that you mean sizeof(struct fsm_s) and it doesn't compile at the > moment! Oops, sloppy mistake. > data_s can just be modified to be __user. All uses of it follow that > rule. What do you mean? The data still needs to

[PATCH v2] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
This fixes the sparse warnings about dereferencing a userspace pointer. Once I updated the sparse annotations, I noticed a bug in gdm_wimax_ioctl() where we pass a user space pointer to gdm_update_fsm() which dereferences it. I fixed this. Signed-off-by: Wim de With --- drivers/staging/gdm72xx

Re: [PATCH] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
On 10-12-2015 10:37, Dan Carpenter wrote: > On Thu, Dec 10, 2015 at 10:11:12AM +0100, Wim de With wrote: >> @@ -482,8 +483,16 @@ static int gdm_wimax_ioctl(struct net_device *dev, >> struct ifreq *ifr, int cmd) >> /* NOTE: gdm_update

[PATCH] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
, and am not sure what to do about it. Signed-off-by: Wim de With --- drivers/staging/gdm72xx/gdm_wimax.c | 17 + drivers/staging/gdm72xx/wm_ioctl.h | 7 ++- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/st

[PATCH] staging: lustre: add __user attributes to llite/file.c

2015-12-08 Thread Wim de With
/file.c:2483:36:expected void const [noderef] * drivers/staging/lustre/lustre/llite/file.c:2483:36:got void * It simply casts pointers to __user pointers in most cases, and changes a few pointers to __user pointers. Signed-off-by: Wim de With --- drivers/staging/lustre/lustre/llite

[PATCH] staging: dgnc: fix line length over 80 chars in dgnc_sysfs.c

2015-05-20 Thread Wim de With
This patch fixes most of the lines over 80 characters long in dgnc_sysfs.c. I couldn't find a way to break line 202-207 in a sensible way. If there is a way, let me know. Signed-off-by: Wim de With --- drivers/staging/dgnc/dgnc_sysfs.c | 110 +- 1

Re: [PATCH] Staging: unisys: fix function declaration format in visorchipset.c

2015-05-18 Thread Wim de With
On 18-5-2015 12:45, Jes Sorensen wrote: > Wim de With writes: >> This is a patch that fixes the function declarations in >> visorbus/visorchipset.c by removing newlines after the function return >> type > > This patch doesn't fix things, it makes things worse! >

[PATCH] Staging: unisys: fix function declaration format in visorchipset.c

2015-05-18 Thread Wim de With
This is a patch that fixes the function declarations in visorbus/visorchipset.c by removing newlines after the function return type Signed-off-by: Wim de With --- drivers/staging/unisys/visorbus/visorchipset.c | 225 ++--- 1 file changed, 85 insertions(+), 140 deletions