From: Marcus Wolf
According to the proposal of Walter Harms, I removed some macros
and added some inline functions.
Since I used a bit more intelligent interface, this enhances
readability and reduces problems with checkpatch.pl at the same time.
In addition obsolete debug ifdefs were removed.
(my patch, concerning the bit shifting,
we talked about last week and an other patch fixing an issue
with a bit inversion).
Hope it helps :-)
Marcus
Am Mi, 2.08.2017, 13:10 schrieb Wolf Entwicklungen:
> According to the proposal of Walter Harms, I removed some macros
> and added some
According to the proposal of Walter Harms, I removed some macros
and added some inline functions.
Since I used a bit more intelligent interface, this enhances
readability and reduces problems with checkpatch.pl at the same time.
In addition obsolete debug ifdefs were removed.
Signed-off-by: Marc
Hi Dan,
I offered Greg to have an eye on the patches, that were submitted. He asked
me to reply to those patches, I had a look for, with the Reviewed-by tag.
Now I am a bit unsure, what I should do.
Since I am interested in, I for sure will read every patch. It's just a little
thing, to reply wi
Reviewed-by: Marcus Wolf
Maybe tx_buffer is a bit more clearly then buffer.
Thanks,
Marcus
Am Mo, 31.07.2017, 10:57 schrieb Arnd Bergmann:
> Putting a 900 byte array on the stack is a clearly too much in the
> kernel, and sometimes results in warnings like:
>
> drivers/staging/pi433/pi433_if.c
Reviewed-by: Marcus Wolf
Thank you :-)
Am Di, 1.08.2017, 07:09 schrieb Rishabh Hardas:
> From: Rishabh Hardas
>
> Solved a few coding style issues, used BIT macro to set MINORBITS.
>
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/pi433_if.c | 24 ++--
> 1 fi
Reviewed-by: Marcus Wolf
Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas:
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/rf69_enum.h | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69_enum.h
> b/drivers/staging/pi4
Reviewed-by: Marcus Wolf
Maybe lnaGain should move to lna_gain instead of lnagain (also applies to the
headers...)
Marcus
Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas:
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/rf69.c | 26 +-
> 1 file changed, 13
Reviewed-by: Marcus Wolf
Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas:
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/rf69.h | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi43
Reviewed-by: Marcus Wolf
Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas:
> Signed-off-by: Rishabh Hardas
> ---
> drivers/staging/pi433/pi433_if.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c
> b/drivers/staging/pi433/pi433_if.c
>
Reviewed-by: Marcus Wolf
Just reviewed, not tested.
As far as I can see, there is no technical issue with this patch.
I prefer the names of the enumerations in camel case, because then they are a
bit shorter.
If camel case is unwanted, for sure we need that change.
Please mind the allignment.
Reviewed-by: Marcus Wolf
Thank you Rishabh!
Marcus
Am Mo, 31.07.2017, 12:21 schrieb RishabhHardas:
> From: RishabhHardas
>
> Solved a few coding style issues, used BIT macro to set MINORBITS.
>
> Signed-off-by: RishabhHardas
> ---
> drivers/staging/pi433/pi433_if.c | 24 ++---
Reviewed-by: Marcus Wolf
Am Do, 20.07.2017, 01:58 schrieb Randy Dunlap:
> From: Randy Dunlap
>
> The pi433 driver uses SPI interfaces so it should depend on SPI.
> Also, the "default n" can be removed since that is already the
> default.
>
> Fixes these build errors when SPI is not enabled:
>
>
Reviewed-by: Marcus Wolf
Tested-by: Marcus Wolf
Am So, 16.07.2017, 16:48 schrieb Joseph Wright:
> Error should be checked with IS_ERR after calling kthread_run()
> instead of comparing the returned pointer to an int.
>
> Found by sparse warning:
>
> incompatible types for operation (<)
> lef
Reviewed-by: Marcus Wolf
Am So, 16.07.2017, 16:48 schrieb Joseph Wright:
> Declare functions static to fix sparse warnings:
>
> warning: symbol 'pi433_receive' was not declared. Should it be static?
> warning: symbol 'pi433_tx_thread' was not declared. Should it be static?
>
> Signed-off-by: Jose
Reviewed-by: Marcus Wolf
Am Di, 18.07.2017, 15:03 schrieb Colin King:
> From: Colin Ian King
>
> The function rf69_set_bandwidth_intern is local to the source
> and do not need to be in global scope, so make it static. Also
> break overly wide line.
>
> Cleans up sparse warning:
> symbol 'update
Reviewed-by: Marcus Wolf
Am Di, 18.07.2017, 15:03 schrieb Colin King:
> From: Colin Ian King
>
> The functions pi433_receive and pi433_tx_thread are local to the source
> and do not need to be in global scope, so make them static
>
> Cleans up sparse warnings:
> symbol 'pi433_receive' was not de
Reviewed-by: Marcus Wolf
Tested-by: Marcus Wolf
Am Di, 18.07.2017, 15:04 schrieb Colin King:
> From: Colin Ian King
>
> The check for thread_run failure is incorrect, use IS_ERR instead.
>
> Cleans up sparse error message:
> "error: incompatible types for operation (<)"
>
> Fixes: 874bcba65f9a
Declare rf69_set_dc_cut_off_frequency_intern as static since it
is used internaly only
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Marcus Wolf
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/p
Bugfixes for rf69_set_modulation, rf69_set_deviation, rf69_set_lna_gain and
rf69_get_lna_gain
The fixes are cross-checked with the datasheet of the rfm69cw
Fixes: 874bcba65f9a ("staging: pi433: New driver")
Signed-off-by: Marcus Wolf
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/p
Pi433 is a 433MHz radio module for the Raspberry Pi.
+ * It is based on the HopeRf Module RFM69CW. Therefore inside of this
+ * driver, you'll find an abstraction of the rf69 chip.
+ *
+ * If needed, this driver could be extended, to also support other
+ * devices, basing on HopeRfs rf69.
+ *
file mode 100644
index 000..57edf91
--- /dev/null
+++ b/drivers/staging/pi433/pi433_if.c
@@ -0,0 +1,1315 @@
+/*
+ * userspace interface for pi433 radio module
+ *
+ * Pi433 is a 433MHz radio module for the Raspberry Pi.
+ * It is based on the HopeRf Module RFM69CW. Therefore inside of this
+ * driv
22 matches
Mail list logo
