I lost interest in this driver years ago because I could't keep up with
testing the incoming janitorial patches. So, drop me from CC.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ks7010/TODO b/drivers/st
Hi Peter,
> Similar things go on in:
>
> drivers/hwmon/lm90.c
> drivers/leds/leds-is31fl319x.c
> drivers/of/unittest.c
Right. I'll fix them, too.
> And drivers/rtc/rtc-fm3130.c has a couple of these:
These are fixed in patch 26 of this series.
Thanks and happy hacking,
Wolfram
signature
We have a dedicated pointer for that, so use it. Much easier to read and
less computation involved.
Signed-off-by: Wolfram Sang
---
Please apply to your subsystem tree.
drivers/staging/media/soc_camera/imx074.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
We have a dedicated pointer for that, so use it. Much easier to read and
less computation involved.
Signed-off-by: Wolfram Sang
---
Please apply to your subsystem tree.
drivers/staging/media/soc_camera/mt9t031.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
series is only build tested.
A branch can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/no_to_adapter
Please apply the patches to the individual subsystem trees. There are no
dependencies.
Thanks and kind regards,
Wolfram
Wolfram Sang (34):
clk: clk-cdc
We have a dedicated pointer for that, so use it. Much easier to read and
less computation involved.
Signed-off-by: Wolfram Sang
---
Please apply to your subsystem tree.
drivers/staging/media/soc_camera/soc_mt9v022.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
ently located at
> Documentation/firmware-guide/acpi/enumeration.rst.
>
>
> Method 2: Instantiate the devices explicitly
For this I2C part:
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
___
devel mailing list
de.
We should get 'driver_data' from 'struct device' directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy.
drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++
1 file changed, 2 insert
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/staging/iio/adc/ad7606_par.c | 6 ++
1 file changed, 2 insertions(+), 4
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/staging/greybus/arche-platform.c | 3 +--
1 file changed, 1 insertion(+), 2
ptr =
- platform_get_drvdata(pdev)
+ dev_get_drvdata(d)
<... when != pdev
- &pdev->dev
+ d
...>
Kind regards,
Wolfram
Wolfram Sang (61):
ARM: plat-samsung: simplify getting .drvdata
ata: simplify getting .drvdata
auxdisplay: simplify getting .drvda
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/staging/nvec/nvec.c | 6 ++
1 file changed, 2 insertions(+), 4
On Tue, Apr 17, 2018 at 07:49:07PM +0200, Geert Uytterhoeven wrote:
> Remove dependencies on HAS_DMA where a Kconfig symbol depends on another
> symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
> In most cases this other symbol is an architecture or platform specific
> symbol, or
> To play it safe, you want to postpone the subsystem patches until the core
> part has landed upstream. I will rebase and resubmit after v4.17-rc1.
Thanks for the heads up. I'll wait for the rebased patch then and apply
it after rc1 for 4.17.
signature.asc
Description: PGP signature
_
> To avoid allmodconfig/allyesconfig regressions on NO_DMA=y platforms,
> this (drivers) series should be applied after the previous (core)
> series (but not many people may notice/care ;-)
I still don't get if there is a dependency on the core patches. I.e.
shall I apply the subsystem patch now
Tobin,
> My question is should I be digging further into the MMC code or be doing
> something else with the driver code?
So, you haven't found any branch that worked? No plain v4.9 or the
gen3-sdio branch from my tree?
Regards,
Wolfram
signature.asc
Description: PGP signature
Hi Tobin,
> I began testing the card you sent today. I'm getting a firmware load
> error like you mentioned.
Nice. Firstly, that means the card is alive and survived the mailing.
> I checked out code from when you originally merged into staging,
> however I built the module in a 4.9 kernel.
I t
On Fri, Apr 28, 2017 at 04:41:33PM +0300, Dan Carpenter wrote:
Adding Tobin to CC, he is way more into the driver than I am these
days...
> Hello Wolfram Sang,
>
> The patch 13a9930d15b4: "staging: ks7010: add driver from Nanonote
> extra-repository" from May 31, 2016,
Hi Tobin,
> over this last month :). This is the reason for this email. Can I
> please take you up on the offer of the SDW-823 card, if you can find
> it?
Sure, I have it here. Just mail me (privately) the address to send it
to and I'll ship right away.
> Secondly, I think I should spend some ti
> I think we can call this question resolved. Remove the comment and
> change the hostif_hdr description to
>
> struct hostif_hdr {
> __be16 size;
> __be16 event;
> } __packed;
>
> Are you happy with this?
Yes, I trust you.
signature.asc
Description: PGP signature
___
Hi,
> The card I have is a Spectec FCC ID: S2Y-WLAN-11B-G which I believe is
> a SDW-823 and should use the ks7010 driver.
Sorry, likely not. It is an early SDW-821 and has a MediaTek chipset for
which no driver is known:
https://wikidevi.com/wiki/Spectec_SDW-821_%28MediaTek%29
For SDW-821 (SD s
> The code is untested, I have hardware in the mail.
Cool!
> If any one is interested and has any comments I would really like to
> hear them. I am open to all suggestions (even down to trivial coding
> style issues).
I'll just repeat that the key move to get this driver out of staging is
to ge
Hi,
> Is there some technical reason why module ks7010 includes a
> implementation of Michael MIC instead of using the implementation in
> crypto/?
>
> Or is this covered by the statement from the TODO
>
> - check what other upstream wireless mechanisms can be used instead of the
> custom ones
On Wed, Mar 15, 2017 at 01:57:32PM +1100, Tobin C. Harding wrote:
> Driver has dead code compiled out using preprocessor directives. TODO
> file asks for these not to be removed - ignore this.
Why?
signature.asc
Description: PGP signature
___
devel ma
On Thu, Aug 11, 2016 at 07:17:12AM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
>
> Further update suggestions were taken into account
Which ones? Please describe them to ease review.
> after a patch was applied from static source code analysis.
I added some Acked- and Reviewed-by ta
> Nothing what I would find noteworthy for increasing the usage of a function
> like "dev_err".
>
> Are you on "a mission" to improve software around logging calls a bit more?
I have two of those cards and I would like to know which one caused an
error. dev_err helps with exactly that.
signat
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/staging/media/lirc/lirc_sasem.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_sasem.c
b/drivers/staging/media/lirc/lirc_sasem.c
index 2218d0042030ed
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/staging/media/lirc/lirc_imon.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_imon.c
b/drivers/staging/media/lirc/lirc_imon.c
index
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/staging/vt6656/main_usb.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/vt6656/main_usb.c
b/drivers/staging/vt6656/main_usb.c
index
when we talked about it at LCJ in
Tokyo a few weeks ago.
Wolfram Sang (6):
staging: comedi: drivers: usbduxfast: don't print error when
allocating urb fails
staging: media: lirc: lirc_imon: don't print error when allocating urb
fails
staging: media: lirc: lirc_sasem: don'
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/staging/most/hdm-usb/hdm_usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c
b/drivers/staging/most/hdm-usb/hdm_usb.c
index
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/staging/comedi/drivers/usbduxfast.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usbduxfast.c
b/drivers/staging/comedi/drivers/usbduxfast.c
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/staging/rtl8192u/r8192U_core.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r8192U_core.c
index
On Wed, Aug 10, 2016 at 09:41:37PM +0200, SF Markus Elfring wrote:
> >> Please and and use pr_fmt
> >
> > Can't we use dev_* on the SDIO device?
>
> How should a connection be constructed from the data structure
> "sdio_device_id"
> to the corresponding device information for such an use case?
On Tue, Jul 26, 2016 at 06:48:00AM +, Nicholas Mc Guire wrote:
> On Mon, Jul 25, 2016 at 11:04:18PM +0200, Wolfram Sang wrote:
> > On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote:
> > > Private functions in ks_hostif.c can be declared static.
> > >
On Mon, Jul 25, 2016 at 09:22:27PM +0200, Nicholas Mc Guire wrote:
> Private functions in ks_hostif.c can be declared static.
>
> Fixes: 13a9930d15b4 ("staging: ks7010: add driver from Nanonote
> extra-repository")
>
> Signed-off-by: Nicholas Mc Guire
Reviewe
On Mon, Jul 25, 2016 at 09:21:50PM +0200, Nicholas Mc Guire wrote:
> wait_for_completion_interruptible_timeout return 0 on timeout and
> -ERESTARTSYS if interrupted. The check for
> !wait_for_completion_interruptible_timeout() would report an interrupt
> as timeout. Further, while HZ/50 will work
On Fri, Jul 22, 2016 at 09:36:53AM +0200, SF Markus Elfring wrote:
> >> I guess that further clarification might be needed for affected
> >> implementation details.
> >
> > That's OK, too.
> >
> > Acked-by: Wolfram Sang
>
> Does this
> Do you find such a source code transformation useful?
No. I already gave that answer by agreeing to Julia's viewpoint.
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.
On Tue, Jul 19, 2016 at 09:51:06AM +0800, Bing Sun wrote:
> Fixed coding style issue:
> Enclose multiple statements macros definition in a do while loop.
> Use one space around binary operators.
>
> Signed-off-by: Bing Sun
Reviewed-b
On Thu, Jul 21, 2016 at 03:35:03PM +0200, SF Markus Elfring wrote:
> > if (atomic_read(&priv->sleepstatus.status) == 0) {
> > rw_data = GCR_B_DOZE;
> > - retval =
> > - ks7010_sdio_write(priv, GCR_B, &rw_data,
> > sizeof(r
> > * Do you really want to assign every return value from a function call
> > to an extra variable before it is used again?
>
> If it's a choice between 1) function call on many lines, 2) function call
> over 80 characters, and 3) extra variable, I definitely prefer the extra
> variable.
+1
On Thu, Jul 21, 2016 at 09:26:33AM +0200, Julia Lawall wrote:
>
>
> On Thu, 21 Jul 2016, Wolfram Sang wrote:
>
> >
> > > >>> if (atomic_read(&priv->sleepstatus.status) == 0) {
> > > >>>
> >>> if (atomic_read(&priv->sleepstatus.status) == 0) {
> >>> rw_data = GCR_B_DOZE;
> >>> - retval =
> >>> - ks7010_sdio_write(priv, GCR_B, &rw_data, sizeof(rw_data));
> >>> - if (retval) {
> >>> + if (ks7010_sdio_write(priv,
> >>> +
the function has such strange error values...
> >
> > Agreed. Markus, can you check if we can use -ENOMEM in those places.
>
> I find that I do not know this software good enough at the moment
> so that I could safely decide on the shown special error values.
> I
Thank you very much for the heads up, Jean!
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Sun, Jul 17, 2016 at 08:51:39PM +0200, Julia Lawall wrote:
>
>
> On Sun, 17 Jul 2016, SF Markus Elfring wrote:
>
> > From: Markus Elfring
> > Date: Sun, 17 Jul 2016 19:40:47 +0200
> >
> > Three variables will be set to an appropriate value a bit later.
> > Thus omit the explicit initialisati
On Tue, Jul 19, 2016 at 09:51:06AM +0800, Bing Sun wrote:
> Fixed coding style issue:
> Enclose multiple statements macros definition in a do while loop.
> Use one space around binary operators.
>
> Signed-off-by: Bing Sun
Looks good for what it is. One comment below. I will test this tomorrow.
On Sun, Jul 17, 2016 at 08:55:41PM +0200, Julia Lawall wrote:
>
>
> On Sun, 17 Jul 2016, SF Markus Elfring wrote:
>
> > From: Markus Elfring
> > Date: Sun, 17 Jul 2016 18:39:03 +0200
> >
> > Do not use curly brackets at some source code places
> > where a single statement should be sufficient.
On Sun, Jul 17, 2016 at 08:20:12PM +0200, SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 17 Jul 2016 16:26:18 +0200
>
> Adjust jump targets according to the Linux coding style convention.
Really? Is that documented somewhere?
Quoting Jean Delvare:
"> It is generally accepted to i
On Sun, Jul 17, 2016 at 01:26:03PM -0700, Joe Perches wrote:
> On Sun, 2016-07-17 at 20:27 +0200, SF Markus Elfring wrote:
> > From: Markus Elfring
> > Date: Sun, 17 Jul 2016 19:12:27 +0200
> >
> > Prefer usage of the macro "pr_err" over the interface "printk".
> > Fix a typo in an error message.
t;
> The local variable "rc" was assigned a zero at one place.
> But it was not read within this function. Thus delete it.
>
> Signed-off-by: Markus Elfring
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Sun, Jul 17, 2016 at 08:56:59PM +0200, Julia Lawall wrote:
>
>
> On Sun, 17 Jul 2016, SF Markus Elfring wrote:
>
> > From: Markus Elfring
> > Date: Sun, 17 Jul 2016 18:15:23 +0200
> >
> > Some return values can also be directly used for various condition checks.
> > Thus remove a local varia
On Sun, Jul 17, 2016 at 08:58:14PM +0200, Julia Lawall wrote:
>
>
> On Sun, 17 Jul 2016, SF Markus Elfring wrote:
>
> > From: Markus Elfring
> > Date: Sun, 17 Jul 2016 15:55:02 +0200
> >
> > Return directly after a memory allocation failed at the beginning.
> >
> > Signed-off-by: Markus Elfring
; Thus remove such unnecessary assignments.
>
> Signed-off-by: Markus Elfring
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
is issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverp
Move read/write functions to the top and driver struct to the end, so we
can remove all forward declarations.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 100 ---
1 file changed, 46 insertions(+), 54 deletions(-)
diff --git a/drivers
We are upstream now, we don't need seperate driver versioning.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.h | 1 -
drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +-
drivers/staging/ks7010/ks_wlan_net.c | 15 +--
3 files changed, 2 insertions(+
No 79xx anymore, this is confusing. Add a comment saying that old
versions were probably named 7910/79xx.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 28 ++--
drivers/staging/ks7010/ks7010_sdio.h | 1 +
2 files changed, 15 insertions(+), 14
There is no need to continue then. Also, this enables us to remove an
ugly static variable.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 3 ---
drivers/staging/ks7010/ks_wlan.h | 3 +++
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010/ks7010_sdio.c
index d4cce78106a736
So the module will be loaded automatically on card insertion. Rename the
array while here.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010
Until we switch to cfg80211 (if ever), we must do this manually.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.c
b/drivers/staging/ks7010/ks7010_sdio.c
index
example config file. The only useful action,
initialization of the configuration struct, is now moved to the sdio
main file.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/Makefile| 3 +-
drivers/staging/ks7010/TODO| 1 -
drivers/staging/ks7
/linux.git staging/ks7010
Thanks,
Wolfram
Wolfram Sang (9):
staging: ks7010: remove cfg file handling
staging: ks7010: function declaration should be in a header file
staging: ks7010: collect all includes and sort them
staging: ks7010: export sdio ids
staging: ks7010: unify naming to
Includes probably need a driver-wide clean up, but for now let's at
least group all includes from the sdio file together.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/k
On Wed, Jun 15, 2016 at 11:53:11PM +0200, Arnd Bergmann wrote:
> The recently-added ks7010 driver produces an annoying build warning:
>
> drivers/staging/ks7010/ks7010_config.c: In function
> 'ks_wlan_read_config_file':
> drivers/staging/ks7010/ks7010_config.c:263:8: error: assignment discards
>
On Tue, Jun 14, 2016 at 02:16:30PM +0300, Dan Carpenter wrote:
> The check for the NUL terminator is wrong so it looks like this could
> read beyond the end of the buffer.
>
> Signed-off-by: Dan Carpenter
Thanks, however I have a patch very soon to be submitted which removes
the config.c file co
From: Wolfram Sang
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks_hostif.c | 1960
1 file changed, 1080 insertions(+), 880 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
index 497b8aaf6daef8
From: Wolfram Sang
trans_start is gone from netdevice, so use the new helper function to
set the mark.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks_wlan_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_wlan_net.c
b/drivers
From: Wolfram Sang
They were counted but never really used anywhere. Also change the printk
to a debug print, since it mostly shows on the expected -ENOMEDIUM on
card removal.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 20 ++--
drivers/staging
From: Wolfram Sang
Unlike the previous patches which are plain indent outcomes, this has
some manual fixups to be not overly strict with the 80 char limit.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 807 ---
1 file changed, 460
From: Wolfram Sang
The printouts are not needed, the driver core has enough debug output
for this if wanted. So, use a helper to save boilerplate code.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 25 +
1 file changed, 1 insertion(+), 24
From: Wolfram Sang
List all authors, beautify description, match license to what is stated
in file headers, add firmware information.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers
From: Wolfram Sang
There is only this card supported, no need to iterate over the table.
The resulting firmware filename wasn't used anyway, but came from the
config file or hardcoded default.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.c
From: Wolfram Sang
Remove svn-ids and fix typos in the licence declaration. Add my
copyright to the sdio code which I worked on mainly.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/eap_packet.h| 6 --
drivers/staging/ks7010/ks7010_sdio.c | 8 +++-
drivers/staging
From: Wolfram Sang
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_config.c | 353 +
1 file changed, 184 insertions(+), 169 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_config.c
b/drivers/staging/ks7010/ks7010_config.c
index
From: Wolfram Sang
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks_wlan_ioctl.h | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h
b/drivers/staging/ks7010/ks_wlan_ioctl.h
index e7469f7338f7af..cc4669eddcc1f7 100644
From: Wolfram Sang
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_sdio.h | 64 +---
1 file changed, 30 insertions(+), 34 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_sdio.h
b/drivers/staging/ks7010/ks7010_sdio.h
index 1d16673e5dae02
From: Wolfram Sang
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks_wlan.h | 246 +++
1 file changed, 121 insertions(+), 125 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 58e3a5a6b44472
From: Wolfram Sang
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks_hostif.h | 525 ++---
1 file changed, 262 insertions(+), 263 deletions(-)
diff --git a/drivers/staging/ks7010/ks_hostif.h
b/drivers/staging/ks7010/ks_hostif.h
index c333ce1a4baa6e
From: Wolfram Sang
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/eap_packet.h | 49 ++---
1 file changed, 24 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/ks7010/eap_packet.h
b/drivers/staging/ks7010/eap_packet.h
index b664bdd8c961db
From: Wolfram Sang
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/michael_mic.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/ks7010/michael_mic.h
b/drivers/staging/ks7010/michael_mic.h
index f14f160ad46549..57ecbe34153202 100644
From: Wolfram Sang
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/michael_mic.c | 43 ++--
1 file changed, 21 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/ks7010/michael_mic.c
b/drivers/staging/ks7010/michael_mic.c
index ec8769a974427a
From: Wolfram Sang
Let's simply specify the struct to keep in sync with kernel coding
style.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_config.c | 4 +-
drivers/staging/ks7010/ks7010_sdio.c | 44 -
drivers/staging/ks7010/ks7010_sdio.h | 2 +-
dr
From: Wolfram Sang
We are by far newer than that anyhow.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks_hostif.c | 23 ---
drivers/staging/ks7010/ks_wlan_net.c | 14 --
2 files changed, 37 deletions(-)
diff --git a/drivers/staging/ks7010
From: Wolfram Sang
No need for an open coded one.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/Makefile | 2 +-
drivers/staging/ks7010/ks7010_sdio.c | 9 +
drivers/staging/ks7010/ks_debug.c| 30 --
drivers/staging/ks7010/ks_debug.h
From: Wolfram Sang
The loop variable was defined but not really used. Fix this.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks_hostif.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ks7010/ks_hostif.c
b/drivers/staging/ks7010/ks_hostif.c
From: Wolfram Sang
We want to remove it, but to do so properly, it is good to have a
working example. Needs to be copied to /lib/firmware in order to be
used.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks79xx.cfg | 116 ++
1 file changed, 116
From: Wolfram Sang
We have sane defaults, so we don't need to bail out if there is no
config file. Note that the config file should go away completely in
favour of configuration mechanisms already upstream.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_config.c | 8 +++---
From: Wolfram Sang
Move the one debug macro to the generic wlan header.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_config.c | 1 -
drivers/staging/ks7010/ks7010_sdio.c | 1 -
drivers/staging/ks7010/ks_debug.h | 28
drivers/staging
From: Wolfram Sang
Use proper type for size_t.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_config.c | 2 +-
drivers/staging/ks7010/ks7010_sdio.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ks7010/ks7010_config.c
b/drivers/staging
From: Wolfram Sang
I had a problem connecting to a network with a short preamble, so let's
make the safer option the default.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks7010_config.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/k
From: Wolfram Sang
My Spectec SDW823 card oopsed when it was already inserted during boot.
When debugging this, I noticed that the card init was done in a seperate
workqueue which was only activated once in probe. After removing the
workqueue and calling the card init directly from probe, the
From: Wolfram Sang
No need to be backwards compatible.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/ks_hostif.c | 9 -
drivers/staging/ks7010/ks_wlan.h | 28 +---
drivers/staging/ks7010/ks_wlan_net.c | 3 ---
3 files changed, 1 insertion
From: Wolfram Sang
FW_LOADER works fine, no need for a open coded fallback.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/Kconfig | 1 +
drivers/staging/ks7010/ks7010_config.c | 62 --
drivers/staging/ks7010/ks7010_sdio.c | 56
From: Wolfram Sang
I couldn't find any trace of code or even products using ks7010 with
something else than SDIO. So, remove the conditionals.
Signed-off-by: Wolfram Sang
---
drivers/staging/ks7010/Makefile| 2 +-
drivers/staging/ks7010/ks7010_config.c | 6 ---
drivers/st
nks,
Wolfram
Wolfram Sang (31):
staging: ks7010: add driver from Nanonote extra-repository
staging: ks7010: remove non-SDIO code and #ifdefs
staging: ks7010: remove custom firmware loader
staging: ks7010: remove checks for WIRELESS_EXT version
staging: ks7010: remove code for old kernel versi
Hi Greg,
> An add-on patch is probably easiest for everyone involved here.
Any chance for the new-driver-rule for this one?
Thanks,
Wolfram
signature.asc
Description: PGP signature
___
devel mailing list
de...@linuxdriverproject.org
http://drive
From: Wolfram Sang
trans_start is gone from netdevice, so use the new helper function to
set the mark.
Signed-off-by: Wolfram Sang
---
This fixup is needed to build with linux/next because it contains a patch
dropping trans_start. But the new helper is not there in current linux master
1 - 100 of 143 matches
Mail list logo