[PATCH -next] staging: regulator: hi6421v600-regulator: Remove unused including

2020-09-10 Thread YueHaibing
Remove including that don't need it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/hikey9xx/hi6421v600-regulator.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/hikey9xx/hi6421v600-regulator.c b/drivers/staging/hikey9xx/hi6421v600-regulator.c

[PATCH -next] media: rkvdec: Remove redundant platform_get_irq error message

2020-09-09 Thread YueHaibing
platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/media/rkvdec/rkvdec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers

[PATCH -next] staging: spmi: hisi-spmi-controller: Use proper format in call to dev_err()

2020-08-31 Thread YueHaibing
The correct format string for a size_t argument should be %zu. Signed-off-by: YueHaibing --- drivers/staging/hikey9xx/hisi-spmi-controller.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/hikey9xx/hisi-spmi-controller.c b/drivers/staging/hikey9xx

[PATCH -next] staging: rtl8723bs: os_dep: return errcode in cfg80211_rtw_leave_ibss()

2020-08-29 Thread YueHaibing
We should return error to caller in cfg80211_rtw_leave_ibss(). Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs

[PATCH v2 -next] media: staging: tegra-vde: Mark tegra_vde_runtime_suspend/resume as __maybe_unused

2020-08-03 Thread YueHaibing
If CONFIG_PM is not set, gcc warns: drivers/staging/media/tegra-vde/vde.c:916:12: warning: 'tegra_vde_runtime_suspend' defined but not used [-Wunused-function] Make it __maybe_unused to fix this. Signed-off-by: YueHaibing --- v2: both suspend and resume functions marked --- drivers/staging

Re: [PATCH -next] media: staging: tegra-vde: Mark tegra_vde_runtime_suspend as __maybe_unused

2020-08-03 Thread Yuehaibing
On 2020/8/3 22:11, Dmitry Osipenko wrote: > 03.08.2020 16:00, Yuehaibing пишет: >> On 2020/8/3 20:51, Dmitry Osipenko wrote: >>> 03.08.2020 14:59, YueHaibing пишет: >>>> If CONFIG_PM is not set, gcc warns: >>>> >>>> drive

Re: [PATCH -next] media: staging: tegra-vde: Mark tegra_vde_runtime_suspend as __maybe_unused

2020-08-03 Thread Yuehaibing
On 2020/8/3 20:51, Dmitry Osipenko wrote: > 03.08.2020 14:59, YueHaibing пишет: >> If CONFIG_PM is not set, gcc warns: >> >> drivers/staging/media/tegra-vde/vde.c:916:12: >> warning: 'tegra_vde_runtime_suspend' defined but not used >> [-Wunused-function] &g

[PATCH -next] media: staging: tegra-vde: Mark tegra_vde_runtime_suspend as __maybe_unused

2020-08-03 Thread YueHaibing
If CONFIG_PM is not set, gcc warns: drivers/staging/media/tegra-vde/vde.c:916:12: warning: 'tegra_vde_runtime_suspend' defined but not used [-Wunused-function] Make it __maybe_unused to fix this. Signed-off-by: YueHaibing --- drivers/staging/media/tegra-vde/vde.c | 2 +- 1 file changed, 1

[PATCH -next] staging: rtl8723bs: remove unused variable 'pregistrypriv'

2020-04-20 Thread YueHaibing
drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function HalRxAggr8723BSdio: drivers/staging/rtl8723bs/hal/sdio_halinit.c:547:24: warning: variable pregistrypriv set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/hal

[PATCH -next] staging: media: usbvision: Add missing MEDIA_USB_SUPPORT dependency

2020-03-03 Thread YueHaibing
VIDEO_USBVISION driver depends on MEDIA_USB_SUPPORT Reported-by: Hulk Robot Fixes: 8fb12ce2ec9d ("media: usbvision: deprecate driver") Signed-off-by: YueHaibing --- drivers/staging/media/usbvision/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/sta

[PATCH -next] staging: wfx: remove set but not used variable 'tx_priv'

2020-02-11 Thread YueHaibing
Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/wfx/queue.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index 0bcc61f..c73d158 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -481,7 +481,6 @@ stru

Re: [PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc'

2020-02-11 Thread Yuehaibing
On 2020/2/11 22:24, Dan Carpenter wrote: > On Tue, Feb 11, 2020 at 09:43:56PM +0800, YueHaibing wrote: >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c: In function >> vchiq_use_internal: >> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

[PATCH -next] staging: vc04_services: remove set but unused variable 'local_entity_uc'

2020-02-11 Thread YueHaibing
: Get of even more suspend/resume states") left behind this unused variable. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/vc0

[PATCH -next] staging: exfat: remove two unused functions

2019-11-14 Thread YueHaibing
in tree, so remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/exfat/exfat_core.c | 35 --- 1 file changed, 35 deletions(-) diff --git a/drivers/staging/exfat/exfat_core.c b/drivers/staging/exfat/exfat_core.c index 1638ed2..d2d3447

[PATCH -next] staging: hp100: Fix build error without ETHERNET

2019-11-12 Thread YueHaibing
nyLAN driver to staging") Signed-off-by: YueHaibing --- drivers/staging/hp/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/hp/Kconfig b/drivers/staging/hp/Kconfig index fb395cf..f20ab21 100644 --- a/drivers/staging/hp/Kconfig +++ b/drivers/staging/hp/Kconfig @@

[PATCH -next] staging: hp100: Use match_string() helper to simplify the code

2019-11-07 Thread YueHaibing
match_string() returns the array index of a matching string. Use it instead of the open-coded implementation. Signed-off-by: YueHaibing --- drivers/staging/hp/hp100.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/hp/hp100.c b/drivers/staging/hp

[PATCH -next] staging: vboxsf: Remove unused including

2019-11-06 Thread YueHaibing
Remove including that don't need it. Signed-off-by: YueHaibing --- drivers/staging/vboxsf/vfsmod.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/vboxsf/vfsmod.h b/drivers/staging/vboxsf/vfsmod.h index de650d65fbe4..18f95b00fc33 100644 --- a/drivers/staging/vboxsf/vfsmod.h

[PATCH -next] staging: comedi: remove unused variable 'route_table_size'

2019-10-23 Thread YueHaibing
drivers/staging/comedi/drivers/ni_routes.c:52:21: warning: route_table_size defined but not used [-Wunused-const-variable=] It is never used since introduction. Signed-off-by: YueHaibing --- drivers/staging/comedi/drivers/ni_routes.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH -next] staging: comedi: dt2814: remove set but not used variables 'data'

2019-10-23 Thread YueHaibing
drivers/staging/comedi/drivers/dt2814.c:193:6: warning: variable data set but not used [-Wunused-but-set-variable] It is never used, so can be removed. Signed-off-by: YueHaibing --- drivers/staging/comedi/drivers/dt2814.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff

[PATCH -next] staging: ralink-gdma: use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/ralink-gdma/ralink-gdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers

[PATCH -next] staging: netlogic: use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/netlogic/xlr_net.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic

[PATCH -next] staging: mt7621-dma: use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/mt7621-dma/mtk-hsdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging

[PATCH -next] staging: media: cedrus: use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c b

[PATCH -next] staging: media: omap4iss: use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/media/omap4iss/iss.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging

[PATCH -next] staging: fieldbus: arcx-anybus:use devm_platform_ioremap_resource() to simplify code

2019-10-16 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/fieldbus/anybuss/arcx-anybus.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/staging/fieldbus/anybuss/arcx

[PATCH v2 -next] staging: rtl8723bs: remove unnecessary null check

2019-10-15 Thread YueHaibing
Null check before kfree is redundant, so remove it. This is detected by coccinelle. Signed-off-by: YueHaibing --- v2: remove unnecessary 'hwxmits' --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core

[PATCH -next] staging: rtl8723bs: remove unnecessary null check

2019-10-15 Thread YueHaibing
Null check before kfree is redundant, so remove it. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging

[PATCH -next] staging: rtl8723bs: Remove unnecessary null check

2019-10-10 Thread YueHaibing
Null check before kfree is redundant, so remove it. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging

[PATCH -next] staging: emxx_udc: use devm_platform_ioremap_resource() to simplify code

2019-10-09 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/emxx_udc/emxx_udc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging

[PATCH -next] staging: clocking-wizard: use devm_platform_ioremap_resource() to simplify code

2019-10-09 Thread YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/clocking-wizard/clk-xlnx

Re: [PATCH] media: staging: tegra-vde: Disable building with COMPILE_TEST

2019-09-06 Thread Yuehaibing
rote: >>>>> On 8/26/19 3:31 PM, YueHaibing wrote: >>>>>> If COMPILE_TEST is y and IOMMU_SUPPORT is n, selecting TEGRA_VDE >>>>>> to m will set IOMMU_IOVA to m, this fails the building of >>>>>> TEGRA_HOST1X and DRM_TEGRA which is y like

[PATCH -next] staging: exfat: Use kmemdup in exfat_symlink()

2019-09-04 Thread YueHaibing
Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- drivers/staging/exfat/exfat_super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 5b5c2ca8c9aa

[PATCH -next] staging: exfat: remove unused including

2019-09-04 Thread YueHaibing
Remove including that don't need it. Signed-off-by: YueHaibing --- drivers/staging/exfat/exfat_super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 5b5c2ca8c9aa..cb43a39864af 100644 --- a/drivers/staging

[PATCH -next] staging: exfat: remove duplicated include from exfat_super.c

2019-09-04 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/staging/exfat/exfat_super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c index 5b5c2ca8c9aa..f202a6588dc3 100644 --- a/drivers/staging/exfat

[PATCH -next] media: imx: remove unused including

2019-08-28 Thread YueHaibing
Remove including that don't need it. Signed-off-by: YueHaibing --- drivers/staging/media/imx/imx-media-csc-scaler.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/imx/imx-media-csc-scaler.c b/drivers/staging/media/imx/imx-media-csc-scaler.c index de599af59ffc

[PATCH] staging: most: sound: Fix error path of audio_init

2019-08-27 Thread YueHaibing
If most_register_configfs_subsys() fails, we should call most_deregister_component() do cleanup. Reported-by: Hulk Robot Fixes: 919c03ae11b9 ("staging: most: enable configfs support") Signed-off-by: YueHaibing --- drivers/staging/most/sound/sound.c | 5 - 1 file changed, 4 insert

[PATCH] media: staging: tegra-vde: Disable building with COMPILE_TEST

2019-08-26 Thread YueHaibing
aging: tegra-vde: Fix build error") Fixes: b301f8de1925 ("media: staging: media: tegra-vde: Add IOMMU support") Signed-off-by: YueHaibing --- drivers/staging/media/tegra-vde/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/tegra-vd

[PATCH -next] staging: rtl8192e: remove set but not used variable 'data_len'

2019-08-21 Thread YueHaibing
8192e: rtllib_crypt_ccmp.c: Use crypto API ccm(aes)") Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging/rtl8192e/rtllib_cr

[PATCH -next] staging: rtl8192e: remove two set but not used variables

2019-08-21 Thread YueHaibing
/staging/rtl8192e/rtl8192e/rtl_dm.c:1904:32: warning: variable 'cck_rx_ver2_min_index' set but not used [-Wunused-but-set-variable] They are never used, so can be removed. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 12 +++- 1 file

[PATCH -next] staging: rtl8192u: ieee80211: remove set but not used variable 'data_len'

2019-08-21 Thread YueHaibing
since commit eb0e7bf3ca94 ("staging: rtl8192u: ieee80211: ieee80211_crypt_ccmp.c: Use crypto API ccm(aes)") Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH] staging: wusbcore: Fix build error without CONFIG_USB

2019-08-09 Thread YueHaibing
aging as it is obsolete") Signed-off-by: YueHaibing --- drivers/staging/wusbcore/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wusbcore/Kconfig b/drivers/staging/wusbcore/Kconfig index 056c60b..a559d02 100644 --- a/drivers/staging/wusbcore/Kconfig +++

[PATCH -next] staging: rtl8723bs: remove set but not used variable 'bEEPROMCheck'

2019-07-31 Thread YueHaibing
-off-by: YueHaibing --- drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c index a733046..95edd14 100644 --- a/drivers/staging/rtl8723bs/hal

[PATCH -next] staging: rtl8723bs: remove set but not used variable 'FirstConnect'

2019-07-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8723bs/hal/odm.c: In function 'odm_RSSIMonitorCheckCE': drivers/staging/rtl8723bs/hal/odm.c:1258:7: warning: variable 'FirstConnect' set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: YueHaibing

[PATCH -next] staging: rtl8723bs: remove set but not used variables 'prspbuf' and 'auth'

2019-07-31 Thread YueHaibing
rtw_joinbss_cmd: drivers/staging/rtl8723bs/core/rtw_cmd.c:771:6: warning: variable auth set but not used [-Wunused-but-set-variable] They are never used, so can be removed. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 ++ 1 file changed, 2

[PATCH] staging/octeon: Fix build error without CONFIG_NETDEVICES

2019-07-30 Thread YueHaibing
[=n] || COMPILE_TEST [=y]) Reported-by: Hulk Robot Fixes: 171a9bae68c7 ("staging/octeon: Allow test build on !MIPS") Signed-off-by: YueHaibing --- drivers/staging/octeon/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/octeon/Kconfig b/drivers/st

[PATCH v3 -next] staging: vc04_services: fix unused-but-set-variable warning

2019-07-26 Thread YueHaibing
/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning: variable local_uc set but not used [-Wunused-but-set-variable] Remove the unused variables 'local_entity_uc' and 'local_uc' Reported-by: Hulk Robot Signed-off-by: YueHaibing Acked-by: Stefan Wahren --- v3: fix patch title

Re: [PATCH v2 -next] staging: vc04_services: fix used-but-set-variable warning

2019-07-26 Thread Yuehaibing
On 2019/7/26 23:57, Stefan Wahren wrote: > Hi Yue, > > Am 26.07.19 um 11:26 schrieb YueHaibing: >> Fix gcc used-but-set-variable warning: > > just a nit. It is call "unused-but-set-variable" Oh, yes, thanks! > > Acked-by: Stefan Wahren > >&

[PATCH 06/10] staging: rtl8723bs: os_dep: remove two set but not used variables

2019-07-26 Thread YueHaibing
/ioctl_linux.c: In function 'rtw_ioctl_wext_private': drivers/staging/rtl8723bs//os_dep/ioctl_linux.c:4915:6: warning: variable 'num_priv' set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 2

[PATCH -next] staging: rtl8723bs: remove set but not used variable 'pszBBRegMpFile'

2019-07-26 Thread YueHaibing
be removed. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c index

[PATCH -next] staging: rtl8723bs: remove set but not used variable 'bWifiBusy'

2019-07-26 Thread YueHaibing
Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c b/drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c index 8e4caee..dd349c5 100644 --- a/drivers/staging/rtl8723bs/hal

[PATCH v2 -next] staging: vc04_services: fix used-but-set-variable warning

2019-07-26 Thread YueHaibing
/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning: variable local_uc set but not used [-Wunused-but-set-variable] Remove the unused variables 'local_entity_uc' and 'local_uc' Reported-by: Hulk Robot Signed-off-by: YueHaibing --- v2: remove the unused variable --- drivers

Re: [PATCH -next] staging: vc04_services: fix used-but-set-variable warning

2019-07-26 Thread Yuehaibing
On 2019/7/25 22:49, Greg KH wrote: > On Thu, Jul 25, 2019 at 10:27:16PM +0800, YueHaibing wrote: >> use variables 'local_entity_uc' and 'local_uc', >> mute gcc used-but-set-variable warning: >> >> drivers/staging/vc04_services/interface/vchiq_a

[PATCH -next] staging: vc04_services: fix used-but-set-variable warning

2019-07-25 Thread YueHaibing
but not used [-Wunused-but-set-variable] drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c:2827:6: warning: variable local_uc set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/vc04_services/interface/vchiq_arm

[PATCH] media: staging: tegra-vde: Fix build error

2019-07-24 Thread YueHaibing
' Select IOMMU_IOVA while COMPILE_TEST is set to fix this. Reported-by: Hulk Robot Suggested-by: Dmitry Osipenko Fixes: b301f8de1925 ("media: staging: media: tegra-vde: Add IOMMU support") Signed-off-by: YueHaibing --- drivers/staging/media/tegra-vde/Kconfig | 2 +- 1 file changed, 1

Re: [PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

2019-07-24 Thread Yuehaibing
On 2019/7/24 21:49, Robin Murphy wrote: > On 24/07/2019 11:30, Sakari Ailus wrote: >> Hi Yue, >> >> On Mon, Jul 22, 2019 at 09:47:49PM +0800, YueHaibing wrote: >>> If IOMMU_SUPPORT is not set, ipu3 driver may select IOMMU_IOVA to m. >>> But for ma

[PATCH] qlge: Fix build error without CONFIG_ETHERNET

2019-07-24 Thread YueHaibing
logic/qlge/ to drivers/staging/qlge/") Signed-off-by: YueHaibing --- drivers/staging/qlge/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/Kconfig b/drivers/staging/qlge/Kconfig index ae9ed2c..a3cb25a3 100644 --- a/drivers/staging/qlge/Kconfig +++

[PATCH] media: staging: ipu3: Enable IOVA API only when IOMMU support is enabled

2019-07-22 Thread YueHaibing
de/iommu.o: In function `tegra_vde_iommu_map': iommu.c:(.text+0x41): undefined reference to `alloc_iova' iommu.c:(.text+0x56): undefined reference to `__free_iova' Reported-by: Hulk Robot Fixes: 7fc7af649ca7 ("media: staging/intel-ipu3: Add imgu top level pci device driver") Signe

[PATCH] staging: rtl8192e: remove set but not used variable 'payload '

2019-07-17 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/rtl8192e/rtllib_rx.c: In function rtllib_rx_InfraAdhoc: drivers/staging/rtl8192e/rtllib_rx.c:1303:6: warning: variable payload set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: YueHaibing

[PATCH] staging: rtl8723bs: remove set but not used variable 'cck_highpwr'

2019-07-17 Thread YueHaibing
be removed. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c index 49fa81406..71919a3 100644

[PATCH -next] staging: kpc2000: kpc_spi: Remove unnecessary null check before kfree

2019-07-11 Thread YueHaibing
A null check before a kfree is redundant, so remove it. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/staging/kpc2000/kpc2000_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000_spi.c b/drivers/staging/kpc2000

[PATCH] staging: most: Fix error path of audio_init

2019-06-21 Thread YueHaibing
If most_register_configfs_subsys fails, call most_deregister_component to clean up. Fixes: 919c03ae11b9 ("staging: most: enable configfs support") Signed-off-by: YueHaibing --- drivers/staging/most/sound/sound.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

[PATCH v2] staging: ks7010: Fix build error

2019-06-21 Thread YueHaibing
to fix this. Reported-by: Hulk Robot Fixes: 8b523f20417d ("staging: ks7010: removed custom Michael MIC implementation.") Signed-off-by: YueHaibing --- v2: use 'depends on' instead of 'select' --- drivers/staging/ks7010/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

[PATCH] staging: ks7010: Fix build error

2019-06-20 Thread YueHaibing
this. Reported-by: Hulk Robot Fixes: 8b523f20417d ("staging: ks7010: removed custom Michael MIC implementation.") Signed-off-by: YueHaibing --- drivers/staging/ks7010/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ks7010/Kconfig b/drivers/staging/ks7010/Kco

[PATCH -next] Staging: kpc2000: kpc_dma: Fix platform_no_drv_owner.cocci warnings

2019-06-20 Thread YueHaibing
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: YueHaibing --- drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc_dma

Re: [PATCH] staging: iio: adt7316: Add missing include files

2019-06-16 Thread Yuehaibing
On 2019/6/16 21:11, Jonathan Cameron wrote: > On Fri, 14 Jun 2019 23:28:46 +0800 > YueHaibing wrote: > >> Fix build error: >> >> drivers/staging/iio/addac/adt7316.c: In function adt7316_store_update_DAC: >> drivers/staging/iio/addac/adt7316.c:949:3: error: imp

[PATCH] staging: iio: adt7316: Add missing include files

2019-06-14 Thread YueHaibing
ype(irq_get_irq_data(chip->bus.irq)); Reported-by: Hulk Robot Fixes: 7f6b6d553df7 ("Staging: iio: adt7316: Add all irq related code in adt7316_irq_setup()") Fixes: c63460c4298f ("Staging: iio: adt7316: Use device tree data to set ldac_pin") Signed-off-by: YueHaibing ---

[PATCH -next] media: meson: vdec: Add missing kthread.h

2019-06-12 Thread YueHaibing
Robot Fixes: 3e7f51bd9607 ("media: meson: add v4l2 m2m video decoder driver") Signed-off-by: YueHaibing --- drivers/staging/media/meson/vdec/vdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/meson/vdec/vdec.c b/drivers/staging/media/meson/vdec/vdec.c ind

[PATCH -next] Staging: kpc2000: kpc_dma: Make some symbols static

2019-06-11 Thread YueHaibing
-by: YueHaibing --- drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c b/drivers/staging/kpc2000/kpc_dma/kpc_dma_driver.c index 9acf1ea..ca76073 100644 --- a/drivers/staging/kpc2000

Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
On 2019/5/28 22:35, Sven Van Asbroeck wrote: > On Tue, May 28, 2019 at 10:31 AM YueHaibing wrote: >> >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set >> > > checkpatch.pl errors remain: > > $ ./scripts/checkpatch.pl < ~/Downloads/YueHaibing.eml &

Re: [PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
Sorry, this is broken, Pls igore this. On 2019/5/28 22:29, YueHaibing wrote: > Fix gcc build error while CONFIG_REGMAP_MMIO is not set > > drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function > `controller_probe': > arcx-anybus.c: undefined reference to `__devm_regma

[PATCH v2 -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
aging: fieldbus: arcx-anybus: change custom -> mmio regmap") Signed-off-by: YueHaibing --- v2: fix patch style warning --- drivers/staging/fieldbus/anybuss/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/fieldbus/anybuss/Kconfig b/drivers/staging/fieldbus/anybuss/

Re: [PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
On 2019/5/28 21:41, Sven Van Asbroeck wrote: > Hello YueHaibing, > > On Tue, May 28, 2019 at 9:33 AM YueHaibing wrote: >> >> Fix gcc build error while CONFIG_REGMAP_MMIO is not set >> >> drivers/staging/fieldbus/anybuss/arcx-anybus.o: In function >> `con

[PATCH -next] staging: fieldbus: Fix build error without CONFIG_REGMAP_MMIO

2019-05-28 Thread YueHaibing
("staging: fieldbus: arcx-anybus: change custom -> mmio regmap") Signed-off-by: YueHaibing --- drivers/staging/fieldbus/anybuss/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/fieldbus/anybuss/Kconfig b/drivers/staging/fieldbus/anybuss/Kconfig index 8bc

[PATCH -next] staging: rtl8723bs: hal: Remove set but not used variable 'no_res' and 'phal'

2019-05-25 Thread YueHaibing
: In function rtl8723bs_free_xmit_priv: drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c:640:23: warning: variable phal set but not used [-Wunused-but-set-variable] They are never used and can be removed. Signed-off-by: YueHaibing --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 5 + 1

[PATCH -next] staging: kpc2000: remove unused function kp2000_cdev_write

2019-05-12 Thread YueHaibing
There is no callers in tree, so can be removed. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/staging/kpc2000/kpc2000/fileops.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/kpc2000/kpc2000/fileops.c b/drivers/staging/kpc2000/kpc2000/fileops.c

[PATCH] staging: kpc2000: Fix build error without CONFIG_UIO

2019-05-10 Thread YueHaibing
y: Hulk Robot Fixes: 7dc7967fc39a ("staging: kpc2000: add initial set of Daktronics drivers") Signed-off-by: YueHaibing --- drivers/staging/kpc2000/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/kpc2000/Kconfig b/drivers/staging/kpc2000/Kconfig index fb59229

[PATCH -next] staging: kpc2000: fix platform_no_drv_owner.cocci warnings

2019-04-23 Thread YueHaibing
Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: YueHaibing --- drivers/staging/kpc2000/kpc_spi/spi_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc_spi

[PATCH -next] staging: kpc2000: remove duplicated include from kp2000_module.c

2019-04-23 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/staging/kpc2000/kpc2000/kp2000_module.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/kpc2000/kpc2000/kp2000_module.c b/drivers/staging/kpc2000/kpc2000/kp2000_module.c index 661b0b74ed66..fa3bd266ba54 100644

[PATCH -next] staging: rtlwifi: base: Remove set but not used variables

2019-04-05 Thread YueHaibing
'ht_cap_len' set but not used [-Wunused-but-set-variable] They are never used and can be removed. Signed-off-by: YueHaibing --- drivers/staging/rtlwifi/base.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi

[PATCH -next] staging: rtl8192e: Remove set but not used variable 'VenderID'

2019-04-05 Thread YueHaibing
and can be removed. Signed-off-by: YueHaibing --- drivers/staging/rtl8192e/rtl8192e/rtl_pci.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c b/drivers/staging/rtl8192e/rtl8192e/rtl_pci.c index bab41ab7c0a5..1d992d5c4e17 100644 --- a/drivers/staging

[PATCH -next] staging: rtlwifi: rtl8822be: Remove set but not used variable 'curtxbw_40mhz'

2019-04-05 Thread YueHaibing
. Signed-off-by: YueHaibing --- drivers/staging/rtlwifi/rtl8822be/hw.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtlwifi/rtl8822be/hw.c b/drivers/staging/rtlwifi/rtl8822be/hw.c index dac22c21f821..1de4e903a4de 100644 --- a/drivers/staging/rtlwifi

[PATCH -next] staging: comedi: dyna_pci10xx: remove set but not used variables 'chan' and range'

2019-04-05 Thread YueHaibing
; drivers/staging/comedi/drivers/dyna_pci10xx.c:109:15: warning: variable 'chan' set but not used [-Wunused-but-set-variable] unsigned int chan, range; They are never used since introduction in commit 16a7373a8e14 ("Staging: comedi: add dyna_pci10xx driver") Signed-off-by: YueHaibing --

Re: [PATCH] staging: rtl8192u: ieee80211: add space around '==' and before '('

2019-04-04 Thread YueHaibing
On 2019/4/5 9:56, Caio Salvador Rohwedder wrote: > Fix checkpatch coding style errors on rtl819x_TSProc.c > - space required before the open parenthesis '(' > - spaces required around that '==' > > Signed-off-by: Caio Salvador Rohwedder > --- >

[PATCH -next] staging: rtlwifi: Remove set but not used variables 'dataempty, hoffset'

2019-02-18 Thread YueHaibing
'efuse_get_current_size': drivers/staging/rtlwifi/efuse.c:1185:5: warning: variable 'hoffset' set but not used [-Wunused-but-set-variable] They're never used and can be removed. Signed-off-by: YueHaibing --- drivers/staging/rtlwifi/efuse.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH v2 -next] staging: rtl8192e: Remove set but not used variables 'broad_addr, stype'

2019-02-18 Thread YueHaibing
:1731:24: warning: variable 'stype' set but not used [-Wunused-but-set-variable] This remove unnessesary bool variable 'multi_addr, broad_addr, uni_addr' Also 'stype' never used and can be removed. Signed-off-by: YueHaibing --- v2: remove unnessesary bool variable 'multi_addr,uni_addr

Re: [PATCH -next] staging: rtl8192e: Remove set but not used variables 'broad_addr, stype'

2019-02-18 Thread YueHaibing
On 2019/2/18 22:31, Dan Carpenter wrote: > On Mon, Feb 18, 2019 at 12:33:59PM +0000, YueHaibing wrote: >> @@ -1747,11 +1747,10 @@ static short _rtl92e_tx(struct net_device *dev, >> struct sk_buff *skb) >> header = (struct rtllib_hdr_1addr *)(((u8 *)skb->data) +

[PATCH -next] staging: rtl8192e: Remove set but not used variables 'broad_addr, stype'

2019-02-18 Thread YueHaibing
:1731:24: warning: variable 'stype' set but not used [-Wunused-but-set-variable] They're never used and can be removed. Signed-off-by: YueHaibing --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e

[PATCH -next] staging: mt7621-mmc: Remove unused including

2019-02-18 Thread YueHaibing
Remove including that don't need it. Signed-off-by: YueHaibing --- drivers/staging/mt7621-mmc/dbg.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/mt7621-mmc/dbg.c b/drivers/staging/mt7621-mmc/dbg.c index eabe0595978b..c7c091fa1da0 100644 --- a/drivers/staging/mt7621-mmc

[PATCH -next] staging: gasket: interrupt: remove unused including

2019-01-21 Thread YueHaibing
From: Yue Haibing Remove including that don't need it. Signed-off-by: Yue Haibing --- drivers/staging/gasket/gasket_interrupt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c index 1cfbc12..176ac2a

[PATCH -next] staging: rtl8712: drop pointless static qualifier in r8712_efuse_pg_packet_write()

2019-01-20 Thread YueHaibing
There is no need to have the 'intrepeat_times' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/staging/rtl8712/rtl8712_efuse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b

[PATCH -next] staging: wilc1000: remove set but not used variable 'msa'

2019-01-09 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/staging/wilc1000/host_interface.c: In function 'wilc_parse_network_info': drivers/staging/wilc1000/host_interface.c:748:16: warning: variable 'msa' set but not used [-Wunused-but-set-variable] Signed-off-by: YueHaibing --- drivers

[PATCH -next] media: staging/intel-ipu3: Fix err handle of ipu3_css_find_binary

2018-12-28 Thread YueHaibing
'bindex' is unsigned, it never less than zero. This patch bring int 'binary' back to handle the err condition. Fixes: 51abe041c5ed ("media: staging/intel-ipu3: Add dual pipe support") Signed-off-by: YueHaibing --- drivers/staging/media/ipu3/ipu3-css.c | 8 1 file changed, 4

[PATCH v3 -next] staging: fbtft: fix strncmp() size warning

2018-12-18 Thread YueHaibing
that the following warning is reported by smatch: drivers/staging/fbtft/fbtft_device.c:1458 fbtft_device_init() error: strncmp() '"list"' too small (5 vs 32) Signed-off-by: YueHaibing --- v2-v3: fix messed patch title --- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 inser

Re: [PATCH v2 -next] staging: fbtft: use strcmp() instead of strncmp() for

2018-12-18 Thread YueHaibing
On 2018/12/18 21:37, Dan Carpenter wrote: > On Tue, Dec 18, 2018 at 09:25:08PM +0800, YueHaibing wrote: >> strncmp() stops comparing when either the end of one of the first two >> arguments is reached or when 'n' characters have been compared, whichever >> comes first.That

[PATCH v2 -next] staging: fbtft: use strcmp() instead of strncmp() for

2018-12-18 Thread YueHaibing
that the following warning is reported by smatch: drivers/staging/fbtft/fbtft_device.c:1458 fbtft_device_init() error: strncmp() '"list"' too small (5 vs 32) Signed-off-by: YueHaibing --- v2: fix patch title --- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 inser

Re: [PATCH -next] staging: fbtft: use strcmp() instead of strncmp() for subsystem lookup

2018-12-18 Thread YueHaibing
sorry, Pls ignore this. The title need fix. On 2018/12/18 21:09, YueHaibing wrote: > strncmp() stops comparing when either the end of one of the first two > arguments is reached or when 'n' characters have been compared, whichever > comes first.That means that strncmp(s1, s2, n) is e

[PATCH -next] staging: fbtft: use strcmp() instead of strncmp() for subsystem lookup

2018-12-18 Thread YueHaibing
that the following warning is reported by smatch: drivers/staging/fbtft/fbtft_device.c:1458 fbtft_device_init() error: strncmp() '"list"' too small (5 vs 32) Signed-off-by: YueHaibing --- drivers/staging/fbtft/fbtft_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH -next] media: rockchip/vpu: remove set but not used variables 'luma_qtable_p, chroma_qtable_p'

2018-12-08 Thread YueHaibing
' set but not used [-Wunused-but-set-variable] It never used since introduction in commit 775fec69008d ("media: add Rockchip VPU JPEG encoder driver") Signed-off-by: YueHaibing --- drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 5 - drivers/staging/media/ro

[PATCH -next] staging: axis-fifo: remove duplicated include from axis-fifo.c

2018-10-05 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/staging/axis-fifo/axis-fifo.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c index 63c8efd..48a9877 100644 --- a/drivers/staging/axis-fifo/axis

[PATCH -next] [media] media: drop pointless static qualifier in vpfe_ipipeif_init()

2018-10-05 Thread YueHaibing
There is no need to have the 'resource_size_t res_len' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/staging/media/davinci_vpfe/dm365_ipipeif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media

  1   2   >