On 2/13/19 2:36 PM, Chao Yu wrote:
On 2019/2/12 11:24, Chengguang Xu wrote:
unlikely has already included in IS_ERR(),
so just remove it.
Signed-off-by: Chengguang Xu
It looks like we don't need to send two patch to fix two similar
issues, if you can merge them, it will be better.
I agree
Hi Chengguang,
Good question! It's in the final stage of preparation to open source erofs-mkfs
(actually they are now struggle at how to properly spilt
into reasonable patches this week), hopefully the implementation could be
released at the next week. (sorry I didn't mean to delay,
I have
On 9/19/18 11:22 PM, Gao Xiang wrote:
Hi Chengguang,
On 2018/9/19 22:53, Chengguang Xu wrote:
Hi Greg, Xiang
I rebased code on latest erofs-master branch and that branch
has already merged the first patch in my previous patchset,
so this time I only post rest 3 patches.
Great, at the most
On 09/18/2018 03:07 PM, Gao Xiang wrote:
Hi Chengguang,
On 2018/9/17 23:34, Chengguang Xu wrote:
Define a dummpy function of erofs_build_fault_attr() when macro
CONFIG_EROFS_FAULT_INJECTION is disabled, so that we don't have to
check the macro in calling place. Based on above adjustment,
do
On 09/14/2018 11:22 PM, Chao Yu wrote:
On 2018/9/13 13:46, cgxu519 wrote:
On 09/13/2018 10:15 AM, Chao Yu wrote:
On 2018/9/12 13:10, Chengguang Xu wrote:
Define a dummpy function of erofs_build_fault_attr() when macro
CONFIG_EROFS_FAULT_INJECTION is disabled, so that we don't have to
check
On 09/13/2018 10:15 AM, Chao Yu wrote:
On 2018/9/12 13:10, Chengguang Xu wrote:
Define a dummpy function of erofs_build_fault_attr() when macro
CONFIG_EROFS_FAULT_INJECTION is disabled, so that we don't have to
check the macro in calling place. Based on above adjustment,
do proper code cleanup
On 09/13/2018 10:04 AM, Chao Yu wrote:
On 2018/9/12 13:10, Chengguang Xu wrote:
Define a dummy function of time_to_inject(), so that we don't
have to check macro CONFIG_EROFS_FAULT_INJECTION in calling place.
Base on above adjustment, do proper code cleanup for erofs_kmalloc().
Signed-off-by:
On 09/12/2018 10:50 PM, Gao Xiang wrote:
On 2018/9/12 22:23, cgxu519 wrote:
On 09/12/2018 07:22 PM, Gao Xiang wrote:
Hi Chengguang,
On 2018/9/12 13:10, Chengguang Xu wrote:
Introduce a new helper __erofs_build_fault_attr() to handle set/clear
erofs_fault_info, we need this funciton
On 09/12/2018 10:25 PM, Dan Carpenter wrote:
On Wed, Sep 12, 2018 at 10:05:26PM +0800, cgxu519 wrote:
On 09/12/2018 05:16 PM, Dan Carpenter wrote:
On Wed, Sep 12, 2018 at 01:10:31PM +0800, Chengguang Xu wrote:
Set fault rate to 0 is useless and confusable, so add check to
avoid it.
I would
On 09/12/2018 07:22 PM, Gao Xiang wrote:
Hi Chengguang,
On 2018/9/12 13:10, Chengguang Xu wrote:
Introduce a new helper __erofs_build_fault_attr() to handle set/clear
erofs_fault_info, we need this funciton for internal use case.
for example, reset fault_injection option in remount.
On 09/12/2018 05:16 PM, Dan Carpenter wrote:
On Wed, Sep 12, 2018 at 01:10:31PM +0800, Chengguang Xu wrote:
Set fault rate to 0 is useless and confusable, so add check to
avoid it.
I would have assumed setting rate to zero just disabled it.
I think currently it is useless because we have
On 09/11/2018 07:08 PM, Gao Xiang wrote:
Hi Chengguang,
Thanks for your patch.
The patch title should be "staging: erofs: " since erofs is still in staging.
Hi Xiang,
Thanks for your review. I'll add the tag from next version.
The same as your previous patch "erofs: surround
12 matches
Mail list logo
