Re: [RFC PATCH 0/5] unisys: kthread cleanup

2015-01-25 Thread devendra.aaru
On Wed, Jan 21, 2015 at 1:12 PM, Romer, Benjamin M wrote: > Hi, > > I've built and tested your set of patches on an s-Par guest, and with > the changes I get a kernel oops during boot, but I haven't determined > the cause yet. I'll let you know what I find. :) > > -- Ben > Hello, Sorry for the l

Re: [RFC PATCH 0/5] unisys: kthread cleanup

2015-01-21 Thread devendra.aaru
Oops, I have forgotten the RFC before the patches from 1 to 5 also i have missed two email addresses (i have added them now). I will resend the whole series again with RFC tag before each PATCH and also proper cc's. Sorry On Wed, Jan 21, 2015 at 3:55 AM, Devendra Naga wrote: > The 1st patch (rep

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread devendra.aaru
>>> you are addressing the memory leak which is not mentioned in change-log. >> >> i am pasting part of commit log here: >> >> commit log: "added the check and the failure path". >> >> Is this not enough to understand ? > > you should have mentioned that memory is never released in previous > secti

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread devendra.aaru
On Mon, Jan 5, 2015 at 1:21 AM, sanjeev sharma wrote: > On Mon, Jan 5, 2015 at 11:41 AM, devendra.aaru > wrote: >> On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma >> wrote: >>> On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga >>> wrote: >>>>

Re: [PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device

2015-01-04 Thread devendra.aaru
On Sun, Jan 4, 2015 at 6:06 AM, Jonathan Cameron wrote: > On 02/01/15 09:02, Devendra Naga wrote: >> This patch adds the error handling for the value returned from >> ade7754_spi_read_reg_8. With this patch, the following randconfig >> warnings get fixed automatically. >> >> drivers/staging/iio/me

Re: [PATCH] cptm1217: check if interrupts are masked at probe

2015-01-04 Thread devendra.aaru
On Mon, Jan 5, 2015 at 1:04 AM, sanjeev sharma wrote: > On Fri, Jan 2, 2015 at 11:47 PM, Devendra Naga > wrote: >> the function cp_tm1217_mask_interrupt can return failure. >> added the check and the failure path. >> >> Cc: Ramesh Agarwal >> Signed-off-by: Devendra Naga >> --- >> >> build tes

Re: randconfig build warnings in staging/iio/meter/

2014-12-15 Thread devendra.aaru
> Hi, > > Thanks for reporting! We are working on IIO cleanup project [1] > and we can take care of fixing this. > Thanks for a very quick response. I did fix those warnings. Let me know if i need to send patches to iio ml. --Devendra ___ devel mailing

randconfig build warnings in staging/iio/meter/

2014-12-15 Thread devendra.aaru
Hello, With next-20141215, i have got the following build warnings: drivers/staging/iio/meter/ade7754.c:222:6: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/staging/iio/meter/ade7754.c:368:6: warning: ‘val’ may be used uninitialized in this function [-

Re: [PATCH 09/69] staging: unisys: refactor create_bus()

2014-12-06 Thread devendra.aaru
On Sat, Dec 6, 2014 at 9:18 AM, Ben Romer wrote: > devendra.aaru wrote: > >> You might consider not using camel case letters.. > > The purpose of patch 8 is to fix spacing errors across the entire file. The > camelcase names are fixed in later patches. > Y

Re: [PATCH 09/69] staging: unisys: refactor create_bus()

2014-12-05 Thread devendra.aaru
On Fri, Dec 5, 2014 at 5:08 PM, Benjamin Romer wrote: > Fix the missing braces and logical continuation problems in create_bus(). > > Signed-off-by: Ken Depro > Signed-off-by: Benjamin Romer > --- > drivers/staging/unisys/uislib/uislib.c | 14 -- > 1 file changed, 8 insertions(+), 6

Re: [PATCH 29/69] staging: unisys: rename Initialize_incoming_thread()

2014-12-05 Thread devendra.aaru
> static BOOL > -Initialize_incoming_thread(void) > +initialize_incoming_thread(void) > { > if (incoming_started) > return TRUE; > if (!uisthread_start(&incoming_ti, > &process_incoming, NULL, "dev_incoming")) { > - LOGERR