There is an allocation for priv->rx_urb[16] has no null check,
which may lead to a null pointer dereference.
Signed-off-by: Dinghao Liu
---
drivers/staging/rtl8192u/r8192U_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/stag
When fw_core_add_address_handler() fails, we need to destroy
the port by tty_port_destroy(). Also we need to unregister
the address handler by fw_core_remove_address_handler() on
failure.
Signed-off-by: Dinghao Liu
---
drivers/staging/fwserial/fwserial.c | 2 ++
1 file changed, 2 insertions
When we encounter invalid data width or address space,
entry should be freed just like what we've done in the
previous error paths.
Signed-off-by: Dinghao Liu
---
drivers/vme/bridges/vme_ca91cx42.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/vme/bridges
When aspect_ratio_crop_init() fails, curr_stream needs
to be freed just like what we've done in the following
error paths. However, current code is returning directly
and ends up leaking memory.
Signed-off-by: Dinghao Liu
---
drivers/staging/media/atomisp/pci/sh_css.c | 2 +-
1 file changed, 1
river - part 4")
Co-developed-by: Dan Carpenter
Signed-off-by: Dan Carpenter
Signed-off-by: Dinghao Liu
---
Changelog:
v2: - Move the initialization after 'else' statement.
Refine commit message.
---
drivers/staging/rtl8188eu/core/rtw_mlme.c | 4 +++-
1 file changed, 3 insert
> I review things in the order that they appear in my inbox so I hadn't
> seen Greg and Larry's comments. You've now stumbled into an area of
> politics where you have conflicting reviews... :P Fortunately, we're
> all of us reasonable people.
>
> I think your patch is correct in that it is
>
> Yes, in this routine, it would be possible for authmode to not be set;
> however,
> later code only compares it to either _WPA_IE_ID_ or _WPA2_IE_ID_. It is
> never
> used in a way that an unset value could make the program flow be different by
> arbitrarily setting the value to zero.
The variable authmode will keep uninitialized if neither if
statements used to initialize this variable are not triggered.
Then authmode may contain a garbage value and influence the
execution flow of this function.
Fix this by initializing it to zero.
Signed-off-by: Dinghao Liu
---
drivers
Sorry, I misunderstood your idea before. A new function is
the best solution for this problem.
Regards,
Dinghao
Dan Carpenter dan.carpen...@oracle.com写道：
> On Thu, May 21, 2020 at 07:42:56PM +0800, dinghao@zju.edu.cn wrote:
> > We need to make sure if pm_runtime_get_sync() is designed with
Carpenter dan.carpen...@oracle.com写道：
> On Thu, May 21, 2020 at 02:27:45PM +0800, Dinghao Liu wrote:
> > pm_runtime_get_sync() increments the runtime PM usage counter even
> > the call returns an error code. Thus a pairing decrement is needed
> > on the error handling path to keep
pm_runtime_get_sync() increments the runtime PM usage counter even
the call returns an error code. Thus a pairing decrement is needed
on the error handling path to keep the counter balanced.
Signed-off-by: Dinghao Liu
---
Changelog:
v2: - Remove unused label 'unlock'
---
drivers/staging/media
rote:
> > 20.05.2020 12:51, Dinghao Liu пишет:
> > > pm_runtime_get_sync() increments the runtime PM usage counter even
> > > it returns an error code. Thus a pairing decrement is needed on
> > > the error handling path to keep the counter balanced.
> > >
&
pm_runtime_get_sync() increments the runtime PM usage counter even
it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.
Signed-off-by: Dinghao Liu
---
drivers/staging/media/tegra-vde/vde.c | 2 +-
1 file changed, 1 insertion(+), 1
13 matches
Mail list logo
