Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread g...@kroah.com
On Mon, Nov 27, 2017 at 05:51:56PM +, Hartley Sweeten wrote: > On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: > >> + const struct comedi_lrange *lrange; > > > > NAK. The following lines of source code allocate memory

Re: [Patch v4 1/2] staging/lustre: add parenthesis to macro argument

2017-04-28 Thread g...@kroah.com
On Wed, Apr 19, 2017 at 03:50:05PM +, Rishiraj Manwatkar wrote: > Add parenthesis to cl_io_for_each() macro to avoid potential issues with > unexpected argument expansion in CPP. > > Signed-off-by: Rishiraj Manwatkar > --- > v1 -> v2: Added mailing list in cc. > v2

Re: [Patch v3 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues

2017-04-18 Thread g...@kroah.com
On Sat, Apr 15, 2017 at 01:50:42PM +, Rishiraj Manwatkar wrote: > Parantheses are added for Macro argument, to avoid precedence issues. > > Signed-off-by: Rishiraj Manwatkar > --- > v1 -> v2: Added mailing list in cc. > v2 -> v3: Changed From: to be same as

Re: [Patch v2 2/2] lustre: fix coding style issue

2017-04-15 Thread g...@kroah.com
On Sat, Apr 15, 2017 at 11:25:11AM +, Rishiraj Manwatkar wrote: > Comparison should have the CONSTANT on the right side of the test Your subject needs to be better :( thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.org

Re: [Patch v2 1/2] lustre: Parantheses added for Macro argument to avoid precedence issues

2017-04-15 Thread g...@kroah.com
On Sat, Apr 15, 2017 at 11:25:00AM +, Rishiraj Manwatkar wrote: > From: RishirajAM > > Parantheses are added for Macro argument, to avoid precedence issues. > > Signed-off-by: Rishiraj Manwatkar > --- >

Re: system hang

2014-04-10 Thread g...@kroah.com
On Thu, Apr 10, 2014 at 07:59:38AM +, Narasimharao Bolisetti wrote: Hi, I have checked the same in the recent kernel versions also. Issue is still remain. What versions have you tried, and what are the logs from those versions? ::DISCLAIMER::