a rule of thumb include only one type of change per patch.
> This is worth to keep in mind for future submissions.
>
> It it then also good to present the trivial changes first(*), and the
> less trivial changes later.
>
> (*) Like whitespace to tabs, spellign errors etc.
>
>
: Javier Martinez Canillas
---
drivers/staging/media/imx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/imx/Kconfig
b/drivers/staging/media/imx/Kconfig
index 36b276ea2ec..5045e24c470 100644
--- a/drivers/staging/media/imx/Kconfig
+++ b/drivers
Removal of a comment that was not needed at all.
We can clearly see that they are include/header files.
Signed-off-by: Javier Martinez
---
drivers/staging/comedi/drivers/ssv_dnp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c
b/drivers/staging
Removed massive boiler plate text at top of the file and instead
replaced it with a simple SPDX license identifier.
Signed-off-by: Javier Martinez
---
drivers/staging/octeon-usb/octeon-hcd.c | 47 ++---
1 file changed, 2 insertions(+), 45 deletions(-)
diff --git a/drivers
Checkpatch.pl issued a warning in the top of the commment within
octeon-hcd.c. This is a simple style fix for that.
Signed-off-by: Javier Martinez
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon
Fixed style line length warning detected by checkpatch.pl in the file
ssv_dnp.c.
Signed-off-by: Javier Martinez
---
drivers/staging/comedi/drivers/ssv_dnp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c
b/drivers/staging/comedi
Fixed style line length warning detected by checkpatch.pl in the file
ssv_dnp.c.
Signed-off-by: Javier Martinez
---
drivers/staging/comedi/drivers/ssv_dnp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ssv_dnp.c
b/drivers/staging/comedi
LE() macro.
Before this patch:
$ modinfo drivers/staging/typec/fusb302/fusb302.ko | grep alias
$
After this patch:
$ modinfo drivers/staging/typec/fusb302/fusb302.ko | grep alias
alias: of:N*T*Cfcs,fusb302C*
alias: of:N*T*Cfcs,fusb302
alias: i2c:typec_fusb302
Signed-off-
4/12/983
[1]: https://hastebin.com/kadagidino.diff
[2]: https://patchwork.kernel.org/patch/9472623/
Best regards,
Javier
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
assignment
(different base types)
drivers/staging/gdm724x/gdm_lte.c:311:39:expected restricted __sum16
[addressable] [assigned] [usertype] icmp6_cksum
drivers/staging/gdm724x/gdm_lte.c:311:39:got int
Signed-off-by: Javier Rodriguez
---
drivers/staging/gdm724x/gdm_lte.c | 15
El 14/02/17 a las 10:24, maomao xu escribió:
drivers/staging/gdm724x/gdm_lte.c:311:39: warning: incorrect type in assignment
(different base types)
drivers/staging/gdm724x/gdm_lte.c:311:39:expected restricted __sum16
[addressable] [assigned] [usertype] icmp6_cksum
drivers/staging/gdm724x/gd
restricted __be16 [usertype]
payload_len
Signed-off-by: Javier Rodriguez
---
drivers/staging/gdm724x/gdm_lte.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b/drivers/staging/gdm724x/gdm_lte.c
index a182757..6792a1d 100644
--- a/drivers/staging
-by: Javier Rodriguez
---
drivers/staging/gdm724x/gdm_lte.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm724x/gdm_lte.c
b/drivers/staging/gdm724x/gdm_lte.c
index a182757..86b2b4f 100644
--- a/drivers/staging/gdm724x/gdm_lte.c
+++ b/drivers/staging
a module...
> +
> +static const struct of_device_id vidsw_dt_ids[] = {
> + { .compatible = "video-multiplexer", },
> + { /* sentinel */ }
> +};
> +
... so you need a MODULE_DEVICE_TABLE(of, vidsw_dt_ids) here or
o
Remove one unnecessary white line.
Signed-off-by: Javier Rodriguez
---
drivers/staging/rtl8192u/r8180_93cx6.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h
b/drivers/staging/rtl8192u/r8180_93cx6.h
index 8e48b24..643d465 100644
--- a/drivers/staging
Correct code style error. Add a character in every line of the
comment block.
Signed-off-by: Javier Rodriguez
---
drivers/staging/rtl8192u/r8180_93cx6.h | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8180_93cx6.h
b
Add character '*' in all lines of the block comments.
Also remove one unnecessary line.
Signed-off-by: Javier Rodriguez
---
drivers/staging/rtl8192u/r8180_93cx6.h | 27 +--
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/drivers/stagin
El 03/01/17 a las 16:20, Greg KH escribió:
On Thu, Dec 22, 2016 at 11:32:16PM +0100, Javier Rodriguez wrote:
Some lines with more than 80 characters has been corrected.
Also, some printk() functions has been changed with their proper
print functions suggested by checkpatch.pl script as well as
-off-by: Javier Rodriguez
---
drivers/staging/i4l/pcbit/module.c | 40 --
1 file changed, 17 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/i4l/pcbit/module.c
b/drivers/staging/i4l/pcbit/module.c
index 0a59bd0..c4450fc 100644
--- a/drivers/staging
$ modinfo drivers/staging/fbtft/flexfb.ko | grep alias
$
After this patch:
$ modinfo drivers/staging/fbtft/flexfb.ko | grep alias
alias: platform:flexpfb
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/fbtft/flexfb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drive
$ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
$
After this patch:
$ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
alias: of:N*T*Cst,stih-cecC*
alias: of:N*T*Cst,stih-cec
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/media/st-cec/
$ modinfo drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias
$
After this patch:
$ modinfo drivers/staging/media/s5p-cec/s5p-cec.ko | grep alias
alias: of:N*T*Csamsung,s5p-cecC*
alias: of:N*T*Csamsung,s5p-cec
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/med
Hello Mauro,
I noticed that module autoload won't be working in a bunch of media
platform drivers because the module alias information is not filled
in the modules. This patch series contains the fixes for them.
Best regards,
Javier
Javier Martinez Canillas (5):
[media] v4l: vsp1: Fix m
On 09/01/2016 05:32 PM, Greg Kroah-Hartman wrote:
> On Thu, Aug 25, 2016 at 06:56:07PM -0400, Javier Martinez Canillas wrote:
>> Hello David,
>>
>> On 08/25/2016 12:01 PM, David Daney wrote:
>>> On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote:
>>>>
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier
Hello David,
On 08/25/2016 12:01 PM, David Daney wrote:
> On 08/25/2016 06:55 AM, Javier Martinez Canillas wrote:
>> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
>> built-in or as a module, use that macro instead of open coding the same.
>>
>
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Using the macro makes the code more readable by helping abstract away some
of the Kconfig built-in and module enable details.
Signed-off-by: Javier
Hello Greg,
On 08/21/2016 12:02 PM, Greg Kroah-Hartman wrote:
> On Thu, Jul 14, 2016 at 01:06:09PM -0400, Javier Martinez Canillas wrote:
>> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
>> built-in or as a module, use that macro instead of open
The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
built-in or as a module, use that macro instead of open coding the same.
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/octeon/ethernet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
The patch looks good and I agree that makes things more clear.
Reviewed-by: Javier Martinez Canillas
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
___
devel mailing list
de...@linuxdriverproj
up in this function will make very clear
that a single function is the counter part of the previous two operations.
> thanks,
> -- Shuah
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
Hello Laurent,
On 12/06/2015 12:18 AM, Laurent Pinchart wrote:
> Hi Javier,
>
> Thank you for the patch.
>
> On Sunday 30 August 2015 00:06:13 Mauro Carvalho Chehab wrote:
>> From: Javier Martinez Canillas
>>
>> Assessing media_entity ID should now use media_
Hello Laurent,
On 12/06/2015 12:10 AM, Laurent Pinchart wrote:
> Hi Javier,
>
> Thank you for the patch.
>
Thanks for your feedback.
> On Thursday 03 September 2015 18:00:32 Javier Martinez Canillas wrote:
>> The omap4iss driver initializes the entities and creates the
The IEEE80211_STYPE_PROBE_REQ flag appears twice in the expression
and coccicheck complains with:
wilc_wfi_cfgoperations.h:80:3-38: duplicated argument to & or |
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/wilc1000/wilc_wfi_cfgoperations.h | 1 -
1 file changed, 1 dele
er to avoid leaking the buffer memory.
Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Javier Martinez Canillas
---
Changes in v2:
- Change also the #ifdef MEMORY_DYNAMIC to #ifndef MEMORY_STATIC since buffer
is allocated when MEMORY_STATI
Hello Sudip,
Thanks a lot for your feedback.
On 09/22/2015 02:16 PM, Sudip Mukherjee wrote:
> On Tue, Sep 22, 2015 at 12:24:50PM +0200, Javier Martinez Canillas wrote:
>> The wilc_wlan_cleanup() function iterates over the list of transmission
>> buffers freeing all of them and the
. This not only causes a
dereference to a pointer already freed but also leaks the memory in the
struct rxq_entry_t buffer.
Fixes: c5c77ba18ea6 ("staging: wilc1000: Add SDIO/SPI 802.11 driver")
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/wilc1000/wilc_wlan.c | 2 +-
1 fi
Hello Sudip,
On 09/22/2015 06:52 AM, Sudip Mukherjee wrote:
> On Tue, Sep 22, 2015 at 02:39:36AM +0200, Javier Martinez Canillas wrote:
>> The driver is using -1 instead of the -ENOMEM defined macro to specify
>> that a buffer allocation failed. Since the error number is propagated
: returning -1 instead of -ENOMEM is sloppy
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/dgap/dgap.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
index 303d97023ccb
me '*.h'
> -type f) ; do sed s,media_entity_create_link,media_create_pad_link,g <$i >a
> && mv a $i; done
>
> Signed-off-by: Mauro Carvalho Chehab
> Acked-by: Hans Verkuil
> Signed-off-by: Mauro Carvalho Chehab
&g
Hello Jonathan,
On 09/05/2015 06:31 PM, Jonathan Cameron wrote:
> On 01/09/15 00:09, Javier Martinez Canillas wrote:
>> Hello Jonathan,
>>
>> On 08/22/2015 07:59 PM, Jonathan Cameron wrote:
>>> On 20/08/15 08:07, Javier Martinez Canillas wrote:
>>>> The S
atches and they were
only build tested. So testing that I didn't introduce any regression will
be highly appreciated.
[0]: https://lkml.org/lkml/2015/8/26/453
[1]: http://www.spinics.net/lists/linux-samsung-soc/msg47089.html
Best regards,
Javier
Javier Martinez Canillas (5):
[media] staging:
are
made after the entities registration.
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/media/omap4iss/iss.c | 101 ++-
drivers/staging/media/omap4iss/iss_csi2.c| 35 +++---
drivers/staging/media/omap4iss/iss_csi2.h| 1 +
drivers
Hello Jonathan,
On 08/22/2015 07:59 PM, Jonathan Cameron wrote:
> On 20/08/15 08:07, Javier Martinez Canillas wrote:
>> The SPI core always reports the MODALIAS uevent as "spi:"
>> regardless of the mechanism that was used to register the device
>> (i.e: OF or bo
The driver has a I2C device id table that is used to create the modaliases
which already contains "synaptics_rmi4_ts". So the alias is not needed.
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 1 -
1 file changed, 1 deletion(-)
di
Hello Laurent,
On 08/21/2015 02:15 AM, Laurent Pinchart wrote:
> Hi Javier,
>
> On Friday 21 August 2015 02:14:05 Javier Martinez Canillas wrote:
>> On 08/20/2015 08:37 PM, Laurent Pinchart wrote:
>>> On Wednesday 19 August 2015 17:35:19 Javier Martinez Canilla
Hello Laurent,
On 08/20/2015 08:37 PM, Laurent Pinchart wrote:
> Hi Javier,
>
> Thank you for the patch.
>
> On Wednesday 19 August 2015 17:35:19 Javier Martinez Canillas wrote:
>> The struct media_entity does not have an .id field anymore since
>> now the entity I
Hello Brian,
On 08/20/2015 11:11 PM, Brian Norris wrote:
> On Thu, Aug 20, 2015 at 09:07:13AM +0200, Javier Martinez Canillas wrote:
>> Patches #1 and #2 solves a), patches #3 to #8 solves b) and patches
>
> ^^^ I'm dying to know how this sentence ends :)
>
Sigh,
Hello Hans,
On 08/20/2015 02:41 PM, Hans Verkuil wrote:
> On 08/19/15 17:35, Javier Martinez Canillas wrote:
>> Hello,
>>
>> This series contains a couple of build fixes and cleanups for the
>> Media Controller framework. The goal of the series is to get rid of
>>
So, it's better to also export the OF table even when
is unused now to prevent breaking module loading when the core changes.
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/s
the SPI id table and this be built into
the module or udev won't have the necessary information to autoload
the needed driver module when the device is added.
Signed-off-by: Javier Martinez Canillas
---
drivers/staging/iio/magnetometer/hmc5843_spi.c | 1 +
1 file changed, 1 insertion(+)
diff
first applying all the other patches in this series, will break
module autoloading for the drivers of devices registered using OF but
that lacks an of_match_table. I'll repost patch #18 once all the patches
in this series have landed.
[0]: https://lkml.org/lkml/2015/7/30/519
Best regards,
Jav
me->graph_obj.mdev
@@
struct media_entity *link;
@@
- link->source->entity->parent
+ link->source->entity->graph_obj.mdev
@@
struct exynos_video_entity *ve;
@@
- ve->vdev.entity.parent
+ ve->vdev.entity.graph_obj.mdev
Suggested-by: Mauro Carvalho Chehab
Signed-off-by: Javier Ma
The struct media_entity does not have an .id field anymore since
now the entity ID is stored in the embedded struct media_gobj.
This caused the omap4iss driver fail to build. Fix by using the
media_entity_id() macro to obtain the entity ID.
Signed-off-by: Javier Martinez Canillas
---
drivers
and the drivers were build tested using allyesconfig and x-building
the ARM Exynos and OMAP defconfigs + the needed media config options.
Best regards,
Javier
[0]: http://www.mail-archive.com/linux-media@vger.kernel.org/msg91330.html
Javier Martinez Canillas (4):
[media] staging: omap4iss
s prototype for
> ‘smtcfb_setmode’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria
Acked-by: Javier M. Mellid
> ---
> drivers/staging/sm7xxfb/sm7xxfb.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
> b/drivers
56 matches
Mail list logo
