Re: [PATCH RESEND v3 5/6] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2016-03-03 Thread Jubin John
On Thu, Mar 03, 2016 at 10:50:41AM -0500, Doug Ledford wrote: > On 03/01/2016 03:27 PM, Jubin John wrote: > >>> diff --git a/drivers/staging/rdma/hfi1/sdma.c > >>> b/drivers/staging/rdma/hfi1/sdma.c > >>> index 1d38be5..cb66bd0 100644 > >>>

Re: [PATCH RESEND v3 5/6] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2016-03-01 Thread Jubin John
> > diff --git a/drivers/staging/rdma/hfi1/sdma.c > > b/drivers/staging/rdma/hfi1/sdma.c > > index 1d38be5..cb66bd0 100644 > > --- a/drivers/staging/rdma/hfi1/sdma.c > > +++ b/drivers/staging/rdma/hfi1/sdma.c > > @@ -1061,7 +1061,6 @@ int sdma_init(struct hfi1_devdata *dd, u8 port) > >

[PATCH RESEND v3] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

2016-01-11 Thread Jubin John
from process context to promote it to ACTIVE. Reviewed-by: Dean Luick Reviewed-by: Ira Weiny Reviewed-by: Mike Marciniszyn Signed-off-by: Jim Snow Signed-off-by: Brendan Cunningham Signed-off-by: Jubin John --- NOTE: This is being resubmitted to linux-rdma (for patchworks) to aid Doug Ledford

[PATCH RESEND v3 2/2] staging/rdma/hfi1: Fix Xmit Wait calculation

2016-01-11 Thread Jubin John
-off-by: Jubin John --- Changes in v2: - No changes Changes in v3: - Refreshed patches against latest staging-next drivers/staging/rdma/hfi1/mad.c | 33 - 1 files changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rdma/hfi1

[PATCH RESEND v3 0/2] Driver cleanup and misc fixes series 3

2016-01-11 Thread Jubin John
NOTE: This is being resubmitted to linux-rdma (for patchworks) to aid Doug Ledford in taking over the staging/rdma subtree. https://www.mail-archive.com/linux-rdma%40vger.kernel.org/msg30860.html This patch set is to follow: staging/rdma/hfi1: Remove unneeded variable index Thanks, Jubin These

[PATCH RESEND v3 6/6] staging/rdma/hfi1: Remove unneeded variable index

2016-01-11 Thread Jubin John
From: Dean Luick The variable "index" increments the same as dd->ndevcntrs. Just use the later. Remove uneeded usage of "index" in the fill loop - it is not used there or later in the function. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by:

[PATCH RESEND v3 1/2] staging/rdma/hfi1: Clean up comments

2016-01-11 Thread Jubin John
From: Edward Mascarenhas Clean up comments by deleting numbering and terms internal to Intel. The information on the actual bugs is not deleted. Reviewed-by: Mike Marciniszyn Signed-off-by: Edward Mascarenhas Signed-off-by: Jubin John --- Changes in v2: - Added more information in

[PATCH RESEND v3 1/6] staging/rdma/hfi1: Use BIT macro

2016-01-11 Thread Jubin John
Signed-off-by: Jubin John --- Changes in v2: - Updated commit message with more information about changes in patch Changes in v3: - Refreshed patch against latest staging-next drivers/staging/rdma/hfi1/chip.h | 48 ++-- drivers/staging/rdma

[PATCH RESEND v3 3/6] staging/rdma/hfi1: change krcvqs module parameter type from byte to uint

2016-01-11 Thread Jubin John
From: Mark F. Brown The krcvqs parameter is displayed incorrectly in sysfs. The workaround is to set the param type as uint. Reviewed-by: Mike Marciniszyn Reviewed-by: Mitko Haralanov Signed-off-by: Mark F. Brown Signed-off-by: Jubin John --- Changes in v2: - None Changes in v3

[PATCH RESEND v3 5/6] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2016-01-11 Thread Jubin John
Marciniszyn Signed-off-by: Vennila Megavannan Signed-off-by: Jubin John --- Changes in v2: - None Changes in v3: - Refreshed patch against latest staging-next drivers/staging/rdma/hfi1/chip.c | 110 +++- drivers/staging/rdma/hfi1/chip.h

[PATCH RESEND v3 2/6] staging/rdma/hfi1: Move s_sde to the read mostly portion of the hfi1_qp structure

2016-01-11 Thread Jubin John
From: Harish Chegondi This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send function when invoked from post_send thereby improving performance of post_send. Reviewed-by: Mike Marciniszyn Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- Changes in v2

[PATCH RESEND v3 4/6] staging/rdma/hfi1: Change default krcvqs

2016-01-11 Thread Jubin John
Change the default number of krcvqs to number of numa nodes + 1 based on the performance data collected. Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- Changes in v2: - None Changes in v3: - Refreshed patch against latest staging-next drivers/staging/rdma/hfi1

[PATCH RESEND v3 0/6] staging/rdma/hfi1: Driver cleanup and misc fixes

2016-01-11 Thread Jubin John
to the read mostly portion of the hfi1_qp structure Jubin John (2): staging/rdma/hfi1: Use BIT macro staging/rdma/hfi1: Change default krcvqs Mark F. Brown (1): staging/rdma/hfi1: change krcvqs module parameter type from byte to uint Vennila Megavannan (1): staging/rdma/hfi1: adding

[PATCH v3] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

2016-01-05 Thread Jubin John
from process context to promote it to ACTIVE. Reviewed-by: Dean Luick Reviewed-by: Ira Weiny Reviewed-by: Mike Marciniszyn Signed-off-by: Jim Snow Signed-off-by: Brendan Cunningham Signed-off-by: Jubin John --- Changes in v2: - Fixed whitespace - Converted armed->act

Re: [PATCH v2] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

2016-01-05 Thread Jubin John
On Mon, Jan 04, 2016 at 10:23:46PM +0200, Leon Romanovsky wrote: > On Mon, Jan 04, 2016 at 11:21:19AM -0500, Jubin John wrote: > > From: Jim Snow > > > > } else { > > + /* Auto activate link on non-SC15 packet receive */ > > +

[PATCH v2] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

2016-01-04 Thread Jubin John
from process context to promote it to ACTIVE. Reviewed-by: Dean Luick Reviewed-by: Ira Weiny Reviewed-by: Mike Marciniszyn Signed-off-by: Jim Snow Signed-off-by: Brendan Cunningham Signed-off-by: Jubin John --- Changes in v2: - Fixed whitespace - Converted armed->act

Re: [PATCH 3/3] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

2015-12-23 Thread Jubin John
On Fri, Dec 18, 2015 at 09:31:39AM +0300, Dan Carpenter wrote: > Possible off by one, but mostly the whitespace makes me itch. > > Jim was not on the CC list. > > On Thu, Dec 17, 2015 at 07:24:15PM -0500, Jubin John wrote: > > From: Jim Snow > > > > The link st

[PATCH v3 1/2] staging/rdma/hfi1: Clean up comments

2015-12-21 Thread Jubin John
From: Edward Mascarenhas Clean up comments by deleting numbering and terms internal to Intel. The information on the actual bugs is not deleted. Reviewed-by: Mike Marciniszyn Signed-off-by: Edward Mascarenhas Signed-off-by: Jubin John --- Changes in v2: - Added more information in

[PATCH v3 0/2] Driver cleanup and misc fixes series 3

2015-12-21 Thread Jubin John
These patches were part of series: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-December/082248.html but did not apply cleanly to the staging-testing branch. Refreshed the remaining 2 patches against the latest staging-testing. Changes in v2: - Added more informa

[PATCH v3 2/2] staging/rdma/hfi1: Fix Xmit Wait calculation

2015-12-21 Thread Jubin John
-off-by: Jubin John --- Changes in v2: - No changes Changes in v3: - Refreshed patches against latest staging-testing drivers/staging/rdma/hfi1/mad.c | 33 - 1 files changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rdma/hfi1

[PATCH v3 5/6] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2015-12-21 Thread Jubin John
Marciniszyn Signed-off-by: Vennila Megavannan Signed-off-by: Jubin John --- Changes in v2: - None Changes in v3: - Refreshed patch against latest staging-testing drivers/staging/rdma/hfi1/chip.c | 110 +++- drivers/staging/rdma/hfi1/chip.h

[PATCH v3 6/6] staging/rdma/hfi1: Remove unneeded variable index

2015-12-21 Thread Jubin John
From: Dean Luick The variable "index" increments the same as dd->ndevcntrs. Just use the later. Remove uneeded usage of "index" in the fill loop - it is not used there or later in the function. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by:

[PATCH v3 3/6] staging/rdma/hfi1: change krcvqs module parameter type from byte to uint

2015-12-21 Thread Jubin John
From: Mark F. Brown The krcvqs parameter is displayed incorrectly in sysfs. The workaround is to set the param type as uint. Reviewed-by: Mike Marciniszyn Reviewed-by: Mitko Haralanov Signed-off-by: Mark F. Brown Signed-off-by: Jubin John --- Changes in v2: - None Changes in v3

[PATCH v3 2/6] staging/rdma/hfi1: Move s_sde to the read mostly portion of the hfi1_qp structure

2015-12-21 Thread Jubin John
From: Harish Chegondi This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send function when invoked from post_send thereby improving performance of post_send. Reviewed-by: Mike Marciniszyn Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- Changes in v2

[PATCH v3 1/6] staging/rdma/hfi1: Use BIT macro

2015-12-21 Thread Jubin John
Signed-off-by: Jubin John --- Changes in v2: - Updated commit message with more information about changes in patch Changes in v3: - Refreshed patch against latest staging-testing drivers/staging/rdma/hfi1/chip.h | 48 ++-- drivers/staging

[PATCH v3 0/6] staging/rdma/hfi1: Driver cleanup and misc fixes

2015-12-21 Thread Jubin John
mostly portion of the hfi1_qp structure Jubin John (2): staging/rdma/hfi1: Use BIT macro staging/rdma/hfi1: Change default krcvqs Mark F. Brown (1): staging/rdma/hfi1: change krcvqs module parameter type from byte to uint Vennila Megavannan (1): staging/rdma/hfi1: adding

[PATCH v3 4/6] staging/rdma/hfi1: Change default krcvqs

2015-12-21 Thread Jubin John
Change the default number of krcvqs to number of numa nodes + 1 based on the performance data collected. Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- Changes in v2: - None Changes in v3: - Refreshed patch against latest staging-testing drivers/staging/rdma/hfi1

Re: [PATCH 2/3] staging/rdma/hfi1: Fix module parameter spelling

2015-12-18 Thread Jubin John
On Fri, Dec 18, 2015 at 09:42:20AM +0300, Dan Carpenter wrote: > Nice. Whenever you see a bug like this, you should report it to > kernel-janitors because you know that 10 other people have made the same > mistake. Sure, I will do that for similar bugs. > > I will take care of it. Thank you. >

[PATCH 3/3] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

2015-12-17 Thread Jubin John
from process context to promote it to ACTIVE. Signed-off-by: Jim Snow Signed-off-by: Brendan Cunningham Reviewed-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |5 ++- drivers/staging/rdma/hfi1/chip.h |2 + drivers/staging/rdma/hfi1/driver.c | 66

[PATCH 1/3] staging/rdma/hfi1: Remove incorrect link credit check

2015-12-17 Thread Jubin John
From: Dean Luick Remove an invalid sanity check that compares the local link credits with the peer link credits. The two have no dependency on each other. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |3 +-- 1

[PATCH 2/3] staging/rdma/hfi1: Fix module parameter spelling

2015-12-17 Thread Jubin John
Fix the spelling of user_credit_return_threshold, it was incorrectly spelled as user_credit_return_theshold causing two module parameters, one with typo, to be shown in modinfo Reviewed-by: Ira Weiny Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/init.c

Re: [PATCH v2 00/13] staging/rdma/hfi1: Driver cleanup and misc fixes

2015-12-08 Thread Jubin John
Hi Greg, Is this patch series still in your queue? I just wanted to make sure it didn't get dropped. Thanks, Jubin John ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v2 12/17] staging/rdma/hfi1: Unexpected link up pkey values are not an error

2015-12-01 Thread Jubin John
From: Dean Luick Only warn when link up pkeys are not what we expect. Also, allow for the pkey to already be initialized. Reviewed-by: Arthur Kepner Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in v2: - No changes drivers/staging/rdma/hfi1/chip.c |8

[PATCH v2 17/17] staging/rdma/hfi1: Adding counter resolutions for DataPortCounters

2015-12-01 Thread Jubin John
d-by: Mike Marciniszyn Signed-off-by: Andrea Lowe Signed-off-by: Jubin John --- Changes in v2: - No changes drivers/staging/rdma/hfi1/mad.c | 38 ++ 1 files changed, 26 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rdma/hfi1/mad.c

[PATCH v2 05/17] staging/rdma/hfi1: Clean up comments

2015-12-01 Thread Jubin John
From: Edward Mascarenhas Clean up comments by deleting numbering and terms internal to Intel. The information on the actual bugs is not deleted. Reviewed-by: Mike Marciniszyn Signed-off-by: Edward Mascarenhas Signed-off-by: Jubin John --- Changes in v2: - Added more information in

[PATCH v2 07/17] staging/rdma/hfi1: Extend quiet timeout

2015-12-01 Thread Jubin John
From: Dean Luick The longest quiet timeout is now 6s. Extend the driver wait to 6s. The driver wasn't following our internal specification: 6 seconds. This patch corrects that issue. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes

[PATCH v2 08/17] staging/rdma/hfi1: Add a credit push on diagpkt allocate fail

2015-12-01 Thread Jubin John
From: Dean Luick When sending a diagnostic packet, if the send context does not have enough room, force a credit return and try again. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in v2: - No changes drivers/staging/rdma/hfi1

[PATCH v2 10/17] staging/rdma/hfi1: Adds software counters for bitfields within various error status fields

2015-12-01 Thread Jubin John
From: Joel Rosenzweig Provides error status counters for CceErrStatus, Send*ErrStatus, RcvErrStatus and MISC_ERR_STATUS Reviewed-by: Mitko Haralanov Reviewed-by: Mike Marciniszyn Signed-off-by: Joel Rosenzweig Signed-off-by: Jubin John --- Changes in v2: - Refreshed patch on top of

[PATCH v2 14/17] staging/rdma/hfi1: unknown frame messages are not errors

2015-12-01 Thread Jubin John
From: Dean Luick Change reported unknown frame messages into a counter. These are informational, no errors. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in v2: - No changes drivers/staging/rdma/hfi1/chip.c | 18

[PATCH v2 04/17] staging/rdma/hfi1: Fix qp.h comments

2015-12-01 Thread Jubin John
From: Kaike Wan This patch fixes a few incorrect header file comments in qp.h Reviewed-by: Mike Marciniszyn Signed-off-by: Kaike Wan Signed-off-by: Jubin John --- Changes in v2: - Added more information in commit message drivers/staging/rdma/hfi1/qp.h |8 1 files

[PATCH v2 13/17] staging/rdma/hfi1: remove SPC freeze error messages

2015-12-01 Thread Jubin John
From: Dean Luick An SPC freeze is not an error. Remove the messages. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in v2: - No changes drivers/staging/rdma/hfi1/chip.c |2 -- 1 files changed, 0 insertions(+), 2 deletions

[PATCH v2 16/17] staging/rdma/hfi1: Fix Xmit Wait calculation

2015-12-01 Thread Jubin John
-off-by: Jubin John --- Changes in v2: - No changes drivers/staging/rdma/hfi1/mad.c | 32 1 files changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rdma/hfi1/mad.c b/drivers/staging/rdma/hfi1/mad.c index a122565..6fb4eab 100644 --- a

[PATCH v2 11/17] staging/rdma/hfi1: Destroy workqueues if hfi1_register_ib_device() call returns error

2015-12-01 Thread Jubin John
From: Harish Chegondi Currently, if hfi1_register_ib_device() call is unsuccessful, workqueues are not being destroyed before bailing out. This patch fixes this issue. Reviewed-by: Dennis Dalessandro Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- Changes in v2: - No

[PATCH v2 09/17] staging/rdma/hfi1: Correctly limit VLs against SDMA engines

2015-12-01 Thread Jubin John
x27;t have enough SDMA (4) mechanisms for the typical number of VLs. Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in v2: - Added more information in commit message drivers/staging/rdma/hfi1/chip.c |6 +++--- 1 files changed, 3 inser

[PATCH v2 06/17] staging/rdma/hfi1: Add one-time LCB reset

2015-12-01 Thread Jubin John
From: Dean Luick Add one-time LCB reset on driver load to pre-emptively work around any LCB power cycle issues. Reviewed-by: Easwar Hariharan Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in v2: - Fixed driver name to hfi1 in subject line drivers/staging/rdma/hfi1

[PATCH v2 15/17] staging/rdma/hfi1: Consider VL15 MTU also when calculating the maximum VL MTU

2015-12-01 Thread Jubin John
-by: Dean Luick Reviewed-by: Arthur Kepner Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- Changes in v2: - No changes drivers/staging/rdma/hfi1/chip.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers

[PATCH v2 02/17] staging/rdma/hfi1: Decode CNP opcode

2015-12-01 Thread Jubin John
by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in v2: - Added more information in commit message drivers/staging/rdma/hfi1/trace.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rdma/hfi1/trace.h b/drive

[PATCH v2 01/17] staging/rdma/hfi1: Support alternate firmware names

2015-12-01 Thread Jubin John
From: Dean Luick Add support for an automatic fallback for firmware names to support debug-signed and production-signed firmware images. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in v2: - Added more information in commit message

[PATCH v2 03/17] staging/rdma/hfi1: Add aeth name syndrome decode

2015-12-01 Thread Jubin John
the decode with the fix: aeth syn 0x00 ACK Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- Changes in v2: - Added more information in commit message drivers/staging/rdma/hfi1/trace.c | 29 ++--- 1 files changed, 22

[PATCH v2 00/17] Driver cleanup and misc fixes series 3

2015-12-01 Thread Jubin John
Changes in v2: - Added more information in commit messages of patches 01, 02 03, 04, 05, 07 and 09 - Fixed driver name to hfi1 in subject line of patch 06 - Refreshed patch 10 on top of staging-next - Dropped patch 18 (staging/rdma/hfi1: Workaround

[PATCH v3] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

2015-11-20 Thread Jubin John
: Ira Weiny Signed-off-by: Jubin John --- Changes in v2: - Removed unlikely() in sdma_select_engine_vl() Changes in v3: - Refreshed patch against latest staging-next drivers/staging/rdma/hfi1/sdma.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH v2 2/2] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

2015-11-20 Thread Jubin John
Does it fail to apply to staging-next or staging-testing or something else? > > As both trees are now the same, it fails to apply to both at the moment > :) I will refresh this patch against the latest staging-next. Thanks, Jubin John > > thanks, > > greg k-h > -- >

[PATCH] staging/rdma/hfi1: Fix error in hfi1 driver build

2015-11-20 Thread Jubin John
) in the CONFIG_PRESCAN_RXQ ifdef block. This function is independent of CONFIG_PRESCAN_RXQ and should be outside this block. Fixes: 82c2611daaf0 ("staging/rdma/hfi1: Handle packets with invalid RHF on context 0") Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- drivers/sta

[PATCH v2 07/13] staging/rdma/hfi1: rework is_a0() and is_bx()

2015-11-16 Thread Jubin John
From: Mike Marciniszyn The current is_bx() will incorrectly match on other steppings. is_a0() is removed in favor of is_ax(). Reviewed-by: Mark Debbage Signed-off-by: Mike Marciniszyn Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 44

[PATCH v2 09/13] staging/rdma/hfi1: Change default krcvqs

2015-11-16 Thread Jubin John
Change the default number of krcvqs to number of numa nodes + 1 based on the performance data collected. Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rdma

[PATCH v2 13/13] staging/rdma/hfi1: Adjust EPROM partitions, add EPROM commands

2015-11-16 Thread Jubin John
: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/eprom.c| 119 +++--- drivers/staging/rdma/hfi1/file_ops.c | 18 ++ include/uapi/rdma/hfi/hfi1_user.h| 10 +-- 3 files changed, 77 insertions(+), 70

[PATCH v2 10/13] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2015-11-16 Thread Jubin John
Marciniszyn Signed-off-by: Vennila Megavannan Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 110 +++- drivers/staging/rdma/hfi1/chip.h |5 + drivers/staging/rdma/hfi1/chip_registers.h |1 + drivers/staging/rdma/hfi1/hfi.h

[PATCH v2 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-16 Thread Jubin John
From: Dean Luick Read an EFI variable for the device description. Create the infrastructure for additional variable reads. Reviewed-by: Easwar Hariharan Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/Makefile |2 +- drivers/staging/rdma/hfi1/chip.c

[PATCH v2 11/13] staging/rdma/hfi1: Remove unneeded variable index

2015-11-16 Thread Jubin John
From: Dean Luick The variable "index" increments the same as dd->ndevcntrs. Just use the later. Remove uneeded usage of "index" in the fill loop - it is not used there or later in the function. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: J

[PATCH v2 05/13] staging/rdma/hfi1: Add space between concatenated string elements

2015-11-16 Thread Jubin John
Space between concantenated string elements is more human readable and fixes the checkpatch issue: CHECK: Concatenated strings should use spaces between elements Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 10 +- drivers/staging

[PATCH v2 04/13] staging/rdma/hfi1: Remove rcv bubbles code

2015-11-16 Thread Jubin John
From: Ira Weiny Rcv bubbles were improperly calculated for HFIs, fix that here. Reviewed-by: Mike Marciniszyn Reviewed-by: Arthur Kepner Signed-off-by: Ira Weiny Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/mad.c | 64 +- 1 files changed, 2

[PATCH v2 06/13] staging/rdma/hfi1: Move s_sde to the read mostly portion of the hfi1_qp structure

2015-11-16 Thread Jubin John
From: Harish Chegondi This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send function when invoked from post_send thereby improving performance of post_send. Reviewed-by: Mike Marciniszyn Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1

[PATCH v2 03/13] staging/rdma/hfi1: remove RxCtxRHQS from hfi1stats

2015-11-16 Thread Jubin John
From: Vennila Megavannan Removed the RxCtxRHQS counter being dumped into dev_cntrs Reviewed-by: Dennis Dalessandro Signed-off-by: Vennila Megavannan Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |2 -- drivers/staging/rdma/hfi1/chip.h |1

[PATCH v2 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-16 Thread Jubin John
Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.h | 48 ++-- drivers/staging/rdma/hfi1/common.h |4 +- drivers/staging/rdma/hfi1/diag.c |4 +- drivers/staging/rdma/hfi1/hfi.h| 22 drivers/staging/rdma/hfi1/init.c

[PATCH v2 02/13] staging/rdma/hfi1: Fix downgrade race

2015-11-16 Thread Jubin John
-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 31 --- 1 files changed, 24 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c index d858f36..6c942f6 100644 --- a/drivers

[PATCH v2 08/13] staging/rdma/hfi1: change krcvqs module parameter type from byte to uint

2015-11-16 Thread Jubin John
From: Mark F. Brown The krcvqs parameter is displayed incorrectly in sysfs. The workaround is to set the param type as uint. Reviewed-by: Mike Marciniszyn Reviewed-by: Mitko Haralanov Signed-off-by: Mark F. Brown Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/hfi.h |2

[PATCH v2 00/13] staging/rdma/hfi1: Driver cleanup and misc fixes

2015-11-16 Thread Jubin John
staging/rdma/hfi1: Adjust EPROM partitions, add EPROM commands Harish Chegondi (1): staging/rdma/hfi1: Move s_sde to the read mostly portion of the hfi1_qp structure Ira Weiny (1): staging/rdma/hfi1: Remove rcv bubbles code Jubin John (3): staging/rdma/hfi1: Use BIT macro sta

Re: [PATCH 10/13] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2015-11-16 Thread Jubin John
On Wed, Nov 11, 2015 at 11:22:15AM +0300, Dan Carpenter wrote: > On Wed, Nov 11, 2015 at 02:33:30AM -0500, Jubin John wrote: > > @@ -8288,6 +8367,21 @@ static int init_cntrs(struct hfi1_devdata *dd) > > dd->ndevcntrs++; > >

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-16 Thread Jubin John
On Sat, Nov 14, 2015 at 12:41:02PM +0530, Sudip Mukherjee wrote: > On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote: > > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote: > > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > >

[PATCH 10/18] staging/rdma/hfi1: Adds software counters for bitfields within various error status fields

2015-11-13 Thread Jubin John
From: Joel Rosenzweig Provides error status counters for CceErrStatus, Send*ErrStatus, RcvErrStatus and MISC_ERR_STATUS Reviewed-by: Mitko Haralanov Reviewed-by: Mike Marciniszyn Signed-off-by: Joel Rosenzweig Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 3185

[PATCH 17/18] staging/rdma/hfi1: Adding counter resolutions for DataPortCounters

2015-11-13 Thread Jubin John
d-by: Mike Marciniszyn Signed-off-by: Andrea Lowe Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/mad.c | 38 ++ 1 files changed, 26 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rdma/hfi1/mad.c b/drivers/staging/rdma/hfi1/mad.c ind

[PATCH 15/18] staging/rdma/hfi1: Consider VL15 MTU also when calculating the maximum VL MTU

2015-11-13 Thread Jubin John
-by: Dean Luick Reviewed-by: Arthur Kepner Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rdma/hfi1/chip.c b/drivers/staging/rdma/hfi1/chip.c index f26b9d5

[PATCH 12/18] staging/rdma/hfi1: Unexpected link up pkey values are not an error

2015-11-13 Thread Jubin John
From: Dean Luick Only warn when link up pkeys are not what we expect. Also, allow for the pkey to already be initialized. Reviewed-by: Arthur Kepner Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |8 1 files changed, 4 insertions(+), 4

[PATCH 14/18] staging/rdma/hfi1: unknown frame messages are not errors

2015-11-13 Thread Jubin John
From: Dean Luick Change reported unknown frame messages into a counter. These are informational, no errors. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 18 ++ drivers/staging/rdma/hfi1/chip.h

[PATCH 09/18] staging/rdma/hfi1: Correctly limit VLs against SDMA engines

2015-11-13 Thread Jubin John
From: Dean Luick Correctly reduce the number of VLs when limited by the number of SDMA engines. Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 08/18] staging/rdma/hfi1: Add a credit push on diagpkt allocate fail

2015-11-13 Thread Jubin John
From: Dean Luick When sending a diagnostic packet, if the send context does not have enough room, force a credit return and try again. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/diag.c |8 1 files changed, 8

[PATCH 07/18] staging/rdma/hfi1: Extend quiet timeout

2015-11-13 Thread Jubin John
From: Dean Luick The longest quiet timeout is now 6s. Extend the driver wait. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 18/18] staging/rdma/hfi1: Workaround CONFIG_SDMA_VERBOSITY timing issue

2015-11-13 Thread Jubin John
Enabling CONFIG_SDMA_VERBOSITY exposes a timing issue in the driver/DC firmware. Removing the CCE_INT_* CSR reads from sdma_dumpstate and a sdma_dumpstate call from the sdma_sendctrl() works around the issue Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1

[PATCH 13/18] staging/rdma/hfi1: remove SPC freeze error messages

2015-11-13 Thread Jubin John
From: Dean Luick An SPC freeze is not an error. Remove the messages. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rdma/hfi1

[PATCH 16/18] staging/rdma/hfi1: Fix Xmit Wait calculation

2015-11-13 Thread Jubin John
-off-by: Jubin John --- drivers/staging/rdma/hfi1/mad.c | 32 1 files changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rdma/hfi1/mad.c b/drivers/staging/rdma/hfi1/mad.c index 32f7037..e151359 100644 --- a/drivers/staging/rdma/hfi1/mad.c +++ b

[PATCH 11/18] staging/rdma/hfi1: Destroy workqueues if hfi1_register_ib_device() call returns error

2015-11-13 Thread Jubin John
From: Harish Chegondi Currently, if hfi1_register_ib_device() call is unsuccessful, workqueues are not being destroyed before bailing out. This patch fixes this issue. Reviewed-by: Dennis Dalessandro Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1

[PATCH 02/18] staging/rdma/hfi1: Decode CNP opcode

2015-11-13 Thread Jubin John
From: Dean Luick Add CNP opcode decode Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/trace.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/staging/rdma/hfi1/trace.h b/drivers/staging/rdma

[PATCH 06/18] staging/rdma/hfi: Add one-time LCB reset

2015-11-13 Thread Jubin John
From: Dean Luick Add one-time LCB reset on driver load to pre-emptively work around any LCB power cycle issues. Reviewed-by: Easwar Hariharan Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 20 drivers/staging/rdma

[PATCH 05/18] staging/rdma/hfi1: Clean up comments

2015-11-13 Thread Jubin John
From: Edward Mascarenhas Clean up comments Reviewed-by: Mike Marciniszyn Signed-off-by: Edward Mascarenhas Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |1 - drivers/staging/rdma/hfi1/driver.c |2 +- drivers/staging/rdma/hfi1/hfi.h|4 ++-- drivers/staging

[PATCH 04/18] staging/rdma/hfi1: Fix qp.h comments

2015-11-13 Thread Jubin John
From: Kaike Wan This patch fixes a few qp.h comments. Reviewed-by: Mike Marciniszyn Signed-off-by: Kaike Wan Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/qp.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rdma/hfi1/qp.h b/drivers

[PATCH 01/18] staging/rdma/hfi1: Support alternate firmware names

2015-11-13 Thread Jubin John
From: Dean Luick Add support for an automatic fallback for firmware names. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/firmware.c | 189 -- 1 files changed, 157 insertions(+), 32 deletions

[PATCH 03/18] staging/rdma/hfi1: Add aeth name syndrome decode

2015-11-13 Thread Jubin John
From: Dean Luick Add aeth name syndrome decode Reviewed-by: Mike Marciniszyn Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/trace.c | 29 ++--- 1 files changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rdma

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-13 Thread Jubin John
On Fri, Nov 13, 2015 at 01:03:44PM -0500, Jubin John wrote: > On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote: > > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote: > > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > > > > T

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-13 Thread Jubin John
On Fri, Nov 13, 2015 at 11:09:22AM -0500, Jubin John wrote: > On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote: > > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > > > This patch fixes the checkpatch issue: > > > CHECK: Prefer using the BIT

Re: [PATCH 01/13] staging/rdma/hfi1: Use BIT macro

2015-11-13 Thread Jubin John
On Fri, Nov 13, 2015 at 06:45:58PM +0530, Sudip Mukherjee wrote: > On Wed, Nov 11, 2015 at 02:33:21AM -0500, Jubin John wrote: > > This patch fixes the checkpatch issue: > > CHECK: Prefer using the BIT macro > > > > Reviewed-by: Dean Luick > > Reviewed-by:

[PATCH 11/13] staging/rdma/hfi1: Remove unneeded variable index

2015-11-10 Thread Jubin John
From: Dean Luick The variable "index" increments the same as dd->ndevcntrs. Just use the later. Remove uneeded usage of "index" in the fill loop - it is not used there or later in the function. Reviewed-by: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: J

[PATCH 13/13] staging/rdma/hfi1: Adjust EPROM partitions, add EPROM commands

2015-11-10 Thread Jubin John
: Dennis Dalessandro Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/eprom.c| 119 +++--- drivers/staging/rdma/hfi1/file_ops.c | 18 ++ include/uapi/rdma/hfi/hfi1_user.h| 10 +-- 3 files changed, 77 insertions(+), 70

[PATCH 04/13] staging/rdma/hfi: Remove rcv bubbles code

2015-11-10 Thread Jubin John
From: Ira Weiny Rcv bubbles were improperly calculated for HFIs, fix that here. Reviewed-by: Mike Marciniszyn Reviewed-by: Arthur Kepner Signed-off-by: Ira Weiny Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/mad.c | 64 +- 1 files changed, 2

[PATCH 03/13] staging/rdma/hfi1: remove RxCtxRHQS from hfi1stats

2015-11-10 Thread Jubin John
From: Vennila Megavannan Removed the RxCtxRHQS counter being dumped into dev_cntrs Reviewed-by: Dennis Dalessandro Signed-off-by: Vennila Megavannan Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c |2 -- drivers/staging/rdma/hfi1/chip.h |1

[PATCH 07/13] staging/rdma/hfi1: rework is_a0() and is_bx()

2015-11-10 Thread Jubin John
From: Mike Marciniszyn The current is_bx() will incorrectly match on other steppings. is_a0() is removed in favor of is_ax(). Reviewed-by: Mark Debbage Signed-off-by: Mike Marciniszyn Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 46

[PATCH 12/13] staging/rdma/hfi1: Read EFI variable for device description

2015-11-10 Thread Jubin John
From: Dean Luick Read an EFI variable for the device description. Create the infrastructure for additional variable reads. Reviewed-by: Easwar Hariharan Signed-off-by: Dean Luick Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/Makefile |2 +- drivers/staging/rdma/hfi1/chip.c

[PATCH 10/13] staging/rdma/hfi1: adding per SDMA engine stats to hfistats

2015-11-10 Thread Jubin John
Marciniszyn Signed-off-by: Vennila Megavannan Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 110 +++- drivers/staging/rdma/hfi1/chip.h |5 + drivers/staging/rdma/hfi1/chip_registers.h |1 + drivers/staging/rdma/hfi1/hfi.h

[PATCH 05/13] staging/rdma/hfi1: Add space between concatenated string elements

2015-11-10 Thread Jubin John
Space between concantenated string elements is more human readable and fixes the checkpatch issue: CHECK: Concatenated strings should use spaces between elements Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/chip.c | 10 +- drivers/staging

[PATCH 06/13] staging/rdma/hfi1: Move s_sde to the read mostly portion of the hfi1_qp structure

2015-11-10 Thread Jubin John
From: Harish Chegondi This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send function when invoked from post_send thereby improving performance of post_send. Reviewed-by: Mike Marciniszyn Signed-off-by: Harish Chegondi Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1

[PATCH 08/13] staging/rdma/hfi1: change krcvqs module parameter type from byte to uint

2015-11-10 Thread Jubin John
From: Mark F. Brown The krcvqs parameter is displayed incorrectly in sysfs. The workaround is to set the param type as uint. Reviewed-by: Mike Marciniszyn Reviewed-by: Mitko Haralanov Signed-off-by: Mark F. Brown Signed-off-by: Jubin John --- drivers/staging/rdma/hfi1/hfi.h |2

  1   2   >