On Sat, Mar 13, 2021 at 10:57 PM namratajanawade
wrote:
>
> Warning found by checkpatch.pl script.
That doesn't tell what you did or why you did it. Please write an
appropriate commit description and resend the patch.
karthik
___
devel mailing l
currently the functions defined in ibuf_ctrl_rmgr.c file are only
used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected
so dont't compile it when not needed, also fixes some sparse warnings
Signed-off-by: karthik alapati
---
drivers/staging/media/atomisp/Makefile | 5 +++--
1 file
fix sparse type warning by converting __le32 types
to host byte-order types before comparison
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c
b/drivers/staging/wimax
fix sparse byte-order warnings by converting host byte-order
type to __le16 byte-order types before assigning to hdr.length
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/op-rfkill.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax
drivers/staging//wimax/i2400m/op-rfkill.c:89:25:got unsigned long
.
drivers/staging//wimax/i2400m/fw.c:514:27: warning: restricted __le32 degrades
to integer
karthik alapati (2):
staging: wimax/i2400m: fix byte-order issue
staging: wimax/i2400m: convert __le32 type to host byte-order
currently the functions defined in ibuf_ctrl_rmgr.c file are only
used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected
so dont't compile it when not needed, also fixes some sparse warnings
Signed-off-by: karthik alapati
---
drivers/staging/media/atomisp/Makefile | 5 +++--
1 file
fix sparse type warning by converting __le32 types
to host byte-order types before comparison
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c
b/drivers/staging/wimax
fix sparse byte-order warnings by converting host byte-order
type to __le16 byte-order types before assigning to hdr.length
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/op-rfkill.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax
'ia_css_isys_ibuf_rmgr_acquire' was not declared. Should it be
static?
drivers/staging//media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:106:6:
warning: symbol 'ia_css_isys_ibuf_rmgr_release' was not declared. Should it be
static?
karthik alapati (3):
staging: wimax/i2400m: fix byte-order
currently the functions defined in ibuf_ctrl_rmgr.c file are only
used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected
so dont't compile it when not needed, also fixes some sparse warnings
Signed-off-by: karthik alapati
---
is this the right patch or just compiling out those
fix sparse type warning by converting le32 types to
host byte-order types before comparison
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/fw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c
b/drivers/staging/wimax/i2400m
fix sparse byte-order warnings by converting host byte-order
types to le32 types
Signed-off-by: karthik alapati
---
drivers/staging/wimax/i2400m/op-rfkill.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wimax/i2400m/op-rfkill.c
b/drivers/staging/wimax
fix sparse warning by casting to explicit user address-space
pointer type
Signed-off-by: karthik alapati
---
drivers/staging/wlan-ng/p80211netdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211netdev.c
b/drivers/staging/wlan-ng
convert le32 types to host byte-order types before
comparison
Signed-off-by: karthik alapati
---
i wonder how these could be false-positives
drivers/staging/wimax/i2400m/fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c
b/drivers
convert le32 types to host byte-order types before
comparison
Signed-off-by: karthik alapati
---
i wonder how these could be false-positives
drivers/staging/wimax/i2400m/fw.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/wimax/i2400m/fw.c
b/drivers
There is a bunch of messy, commented out code. Just delete it.
Suggested-by: Dan Carpenter
Signed-off-by: karthik alapati
---
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 40 +--
1 file changed, 2 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal
there are some good function comments not following
kernel-doc. Make them follow kernel-doc style
Signed-off-by: karthik alapati
---
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 185 +++---
1 file changed, 73 insertions(+), 112 deletions(-)
diff --git a/drivers/staging/rtl8723bs
karthik alapati (2):
staging: rtl8723bs: fix function comments to follow kernel-doc
staging: rtl8723bs: remove obsolete commented out code
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 225 ++
1 file changed, 75 insertions(+), 150 deletions(-)
--
2.30.0
fix some checkpatch "Block comments use * on subsequent lines"
warnings and remove obsolete code
Suggested-by: Dan Carpenter
Signed-off-by: karthik alapati
---
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 44 ---
1 file changed, 9 insertions(+), 35 deletions(-)
fix checkpatch.pl warning for "block comments should align the
* on each line" and make function comments follow kernel-doc
Signed-off-by: karthik alapati
---
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 185 +++---
1 file changed, 73 insertions(+), 112 deletions(-)
fix checkpatch.pl warning for "block comments should align the
* on each line" and make function comments follow kernel-doc
Signed-off-by: karthik alapati
---
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 209 --
1 file changed, 91 insertions(+), 118 deletions(-)
fix checkpatch.pl warning for "block comments should align the * on each line"
Signed-off-by: karthik alapati
---
.../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 204 +-
1 file changed, 102 insertions(+), 102 deletions(-)
diff --git a/drivers/staging/rtl
showing this warning.
Signed-off-by: B K Karthik
---
drivers/staging/greybus/audio_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_helper.c
b/drivers/staging/greybus/audio_helper.c
index 3011b8abce38..1ed4772d2771 100644
--- a/drivers
On Sun, Jul 19, 2020 at 5:26 AM Greg Kroah-Hartman
wrote:
>
> On Sat, Jul 18, 2020 at 05:16:26AM -0400, B K Karthik wrote:
> > fixed multiple parentheses coding style issues reported by checkpatch.
> >
> > Signed-off-by: B K Karthik
> > ---
> > drivers/stagin
On Sat, Jul 18, 2020 at 9:17 AM Joe Perches wrote:
>
> On Sat, 2020-07-18 at 05:18 -0400, B K Karthik wrote:
> > placed constant on the right side of the test
> > to fix warnings issued by checkpatch
> []
> > diff --git a/drivers/staging/rtl8188eu/include/wifi.h
>
placed constant on the right side of the test
to fix warnings issued by checkpatch
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_mlme.h | 4 ++--
drivers/staging/rtl8188eu/include/wifi.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
enclosed macros starting with if inside do-while loops to
avoid possible if-else logic defects
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/odm_debug.h | 28 +++
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include
fixed multiple parentheses coding style issues reported by checkpatch.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/ieee80211.h | 4 +--
.../staging/rtl8188eu/include/osdep_service.h | 4 +--
drivers/staging/rtl8188eu/include/wifi.h | 34 +--
3 files
fixed multiple blank space coding style issues
reported by checkpatch
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/hal_com.h | 2 +-
drivers/staging/rtl8188eu/include/osdep_service.h | 2 +-
drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 2 +-
drivers/staging
fixed sparse warnings by adding a cast in assignment from
void [noderef] __user * to unsigned int __force *
and a reverse cast in argument from
unsigned int * to unsigned int __user * .
Signed-off-by: B K Karthik
Reviewed-by: Ian Abbott
---
v1 -> v2:
- Added a reverse cast in argument
v2 -&
ott
v3 -> v4:
- Add versioning information in commit description
Signed-off-by: B K Karthik
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index 3f7
On Thu, Jul 16, 2020 at 10:25 AM Greg Kroah-Hartman
wrote:
>
> On Thu, Jul 16, 2020 at 10:17:47AM -0400, B K Karthik wrote:
> > fixed sparse warnings by adding a cast in assignment from
> > void [noderef] __user * to unsigned int __force *
> > and a reverse cast in argume
fixed sparse warnings by adding a cast in assignment from
void [noderef] __user * to unsigned int __force *
and a reverse cast in argument from
unsigned int * to unsigned int __user * .
Signed-off-by: B K Karthik
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2 insertions
fixed sparse warnings by adding a cast in assignment from
void [noderef] __user * to unsigned int __force *
and a reverse cast in argument from
void [noderef] __user * to unsigned int __user * .
Signed-off-by: B K Karthik
---
drivers/staging/comedi/comedi_fops.c | 4 ++--
1 file changed, 2
On Wed, Jul 15, 2020 at 7:19 AM Ian Abbott wrote:
>
> On 15/07/2020 05:48, B K Karthik wrote:
> > fixed a sparse warning by changing the type in
> > assignment from void [noderef] __user * to unsigned int *
> > (different address space)
> >
> > Signed-off-by
On Wed, Jul 15, 2020 at 5:29 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 05:21:01AM -0400, B K Karthik wrote:
> > On Wed, Jul 15, 2020 at 5:14 AM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Wed, Jul 15, 2020 at 04:41:52AM -0400, B K Karthik wrot
On Wed, Jul 15, 2020 at 5:19 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 04:47:48AM -0400, B K Karthik wrote:
> > On Wed, Jul 15, 2020 at 4:41 AM B K Karthik wrote:
> > >
> > > On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman
> > > wrot
On Wed, Jul 15, 2020 at 5:14 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 04:41:52AM -0400, B K Karthik wrote:
> > On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wro
On Wed, Jul 15, 2020 at 4:41 AM B K Karthik wrote:
>
> On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman
> wrote:
> >
> > On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wrote:
> > > On Wed, Jul 15, 2020, 12:38 PM Greg Kroah-Hartman <
> &
On Wed, Jul 15, 2020 at 4:31 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 01:56:45PM +0530, B K Karthik wrote:
> > On Wed, Jul 15, 2020, 12:38 PM Greg Kroah-Hartman <
> > gre...@linuxfoundation.org> wrote:
> >
> > > On Wed, Jul 15, 2020
On Wed, Jul 15, 2020 at 3:08 AM Greg Kroah-Hartman
wrote:
>
> On Wed, Jul 15, 2020 at 12:48:13AM -0400, B K Karthik wrote:
> > fixed a sparse warning by changing the type in
> > assignment from void [noderef] __user * to unsigned int *
> > (different address space)
&g
fixed a sparse warning by changing the type in
assignment from void [noderef] __user * to unsigned int *
(different address space)
Signed-off-by: B K Karthik
---
drivers/staging/comedi/comedi_fops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi
changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES,
N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they
were not declared earlier.
Signed-off-by: B K Karthik
---
.../media/atomisp/pci/css_2401_system/host/csi_rx.c | 8
1 file changed, 4 insertions
changed symbols N_SHORT_PACKET_LUT_ENTRIES, N_LONG_PACKET_ENTRIES,
N_CSI_RX_FE_CTRL_DLANES, N_CSI_RX_BE_SID_WIDTH to static because they
were not declared earlier.
Signed-off-by: B K Karthik
---
.../media/atomisp/pci/css_2401_system/host/csi_rx.c | 8
1 file changed, 4 insertions
add blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
add parentheses since complex valued macros must be enclosed within parentheses.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers
added blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index
add blank spaces for improved code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h
b/drivers/staging/rtl8188eu/include/rtw_cmd.h
index
added blank spaces to improve code readability. (coding style issue)
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
b/drivers
add blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
add parentheses since complex valued macros must be enclosed within parentheses.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers
added blank spaces to improve code readability. (coding style issue)
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
b/drivers
added blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_recv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_recv.h
b/drivers/staging/rtl8188eu/include/rtw_recv.h
index
add blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
add parentheses since complex valued macros must be enclosed within parentheses.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_pwrctrl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_pwrctrl.h
b/drivers
add blank spaces for improved code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtw_cmd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/rtw_cmd.h
b/drivers/staging/rtl8188eu/include/rtw_cmd.h
index
added blank spaces to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/rtl8188e_xmit.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/rtl8188e_xmit.h
b/drivers/staging/rtl8188eu
Did this get burried in along with a bunch of other patches? I am sending this
email only because I did not recieve a negetive acknowledgement on the patch.
I apologize if this message was hurtful / disrespectfull in any manner,
thank you for reading this message.
karthik
On 20/06/28 12:38AM
removed multiple blank lines to improve code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/ieee80211.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/ieee80211.h
b/drivers/staging/rtl8188eu/include/ieee80211.h
index
added blank space and enclosed a complex valued macro within parentheses for
improved code readability.
Signed-off-by: B K Karthik
---
drivers/staging/rtl8188eu/include/odm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/include/odm.h
b/drivers
added blank space around arithmetic operators to improve readability
Signed-off-by: B K Karthik
---
.../rtl8188eu/include/hal8188e_rate_adaptive.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/include/hal8188e_rate_adaptive.h
b
Fixed a coding style issue.
Signed-off-by: B K Karthik
---
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
b/drivers/staging/media/atomisp/i2c/atomisp-ov2680.c
index
Thank you for the information.
I will take care of all these things from the next time.
sorry for wasting your time
thanks,
karthik
On Sat, Jun 27, 2020 at 4:49 AM Greg Kroah-Hartman
wrote:
>
> On Sat, Jun 27, 2020 at 10:28:31AM +0200, Hans Verkuil wrote:
> > On 27/06/2020 07:07
Removing unnecessary blank line
Signed-off-by: B K Karthik
---
drivers/staging/rtl8712/rtl8712_recv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_recv.h
b/drivers/staging/rtl8712/rtl8712_recv.h
index 3e385b2242d8..69d3d5b287d3 100644
--- a/drivers/staging
Signed-off-by: B K Karthik
---
drivers/staging/qlge/qlge.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
index fc8c5ca8935d..0b971a633001 100644
--- a/drivers/staging/qlge/qlge.h
+++ b/drivers/staging/qlge/qlge.h
@@ -2224,6 +2224,7
fbtft-bus.c:
fixing ERROR: space prohibited before that close parenthesis ')' by removing
that space and ',' in line 65 and 67.
Signed-off-by: B K Karthik
---
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft
fbtft-bus.c:
fixing ERROR: space prohibited before that close parenthesis ')' by removing
that space and ',' in line 65 and 67.
Signed-off-by: B K Karthik
---
drivers/staging/fbtft/fbtft-bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft
, or the driver
is scheduled for removal.
Please do think about adding a file that lists all drivers scheduled
for removal.
I apologize if my message was hurtful or disrespectful in any way.
Thank you for reading this message,
Karthik
On Fri, Jun 26, 2020 at 10:32 AM B K Karthik wrote:
>
>
fixing ERROR: space prohibited before that ',' (ctx:WxW)
Signed-off-by: B K Karthik
---
drivers/staging/media/usbvision/usbvision-i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/usbvision/usbvision-i2c.c
b/drivers/staging/media/usbvision
soc_camera.c:
fixing ERROR: Macros with complex values must be enclused within parentheses.
Signed-off-by: B K Karthik
---
drivers/staging/media/soc_camera/soc_camera.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/soc_camera/soc_camera.c
b
yle problem
"Alignment should match open parenthesis" by adding tab spaces in line 1270.
Signed-off-by: B K Karthik
---
drivers/staging/media/soc_camera/soc_camera.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/soc_camera/soc_camera.
Signed-off-by: B K Karthik
---
drivers/staging/nvec/nvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index 360ec0407740..16afbe1dfdeb 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
erated.
Link: https://github.com/ClangBuiltLinux/linux/issues/170
Signed-off-by: Karthik Nishanth
---
v2: changed the subject
drivers/staging/rtlwifi/regd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/regd.c b/drivers/staging/rtlwifi/regd.c
Do I submit a new patch with the modified subject?
On Sat, Sep 22, 2018 at 03:44:32PM +0300, Dan Carpenter wrote:
>The subject needs a subsystem prefix. It's also slightly long.
>
>[PATCH] Staging: rtlwifi: remove unnecessary NULL check
>
>regards,
>dan carpenter
&g
erated.
Link: https://github.com/ClangBuiltLinux/linux/issues/170
Signed-off-by: Karthik Nishanth
---
drivers/staging/rtlwifi/regd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtlwifi/regd.c b/drivers/staging/rtlwifi/regd.c
index 3afd206ce4b1..5213ca
From: Karthik Tummala <kart...@techveda.org>
Fixed following checkpatch warnings & checks:
CHECK: Unnecessary parentheses
WARNING: suspect code indent for conditional statements
WARNING: Missing a blank line after declarations
Signed-off-by: Karthik Tummala <kart...@techveda.
On Tuesday 18 July 2017 04:41 PM, Bryan O'Donoghue wrote:
On 18/07/17 11:56, kart...@techveda.org wrote:
From: Karthik Tummala <kart...@techveda.org>
Enclosed multiple macro statements in a do - while loop as per kernel
coding standard, pointed by checkpatch.
Signed-off-by: Karthik T
From: Karthik Tummala <kart...@techveda.org>
Enclosed multiple macro statements in a do - while loop as per kernel
coding standard, pointed by checkpatch.
Signed-off-by: Karthik Tummala <kart...@techveda.org>
---
drivers/staging/greybus/loopback.c | 10 ++
1 file changed,
From: Karthik Tummala <kart...@techveda.org>
Fixed following checkpatch.pl warning:
WARNING: Prefer using '"%s...", __func__' to using
the function's name, in a string
It is prefered to use '%s & __func__' instead of function
name for logging.
Signed-off-by: K
On Wednesday 28 June 2017 03:15 PM, Gilad Ben-Yossef wrote:
Thank you Karthik,
On Wed, Jun 28, 2017 at 12:37 PM, <kart...@techveda.org> wrote:
From: Karthik Tummala <kart...@techveda.org>
This patch series fixes coding style and removes the following
checkpatch.pl warnings:
From: Karthik Tummala <kart...@techveda.org>
Fixed following checkpatch.pl warning:
WARNING: braces {} are not necessary for single
statement blocks.
Signed-off-by: Karthik Tummala <kart...@techveda.org>
---
drivers/staging/ccree/ssi_aead.c | 38 ++---
From: Karthik Tummala <kart...@techveda.org>
This patch series fixes coding style and removes the following
checkpatch.pl warnings:
Prefer using '"%s...", __func__' to using the function's name,
in a string.
Braces {} are not necessary for single statement blocks.
Rebase
From: Karthik Tummala <kart...@techveda.org>
Fixed following checkpatch.pl warning:
WARNING: Prefer using '"%s...", __func__' to using
the function's name, in a string
It is prefered to use '%s & __func__' instead of function
name for logging.
Signed-off-by: K
From: Karthik Tummala <kart...@techveda.org>
Fixed following checkpatch.pl warning:
* WARNING: Prefer kcalloc over kzalloc with multiply
Instead of specifying no.of bytes * size as argument
in kzalloc, prefer kcalloc.
Signed-off-by: Karthik Tummala <kart...@techveda.org>
Revi
From: Karthik Tummala <kart...@techveda.org>
Fixed following checkpatch.pl warning:
* WARNING: Prefer kcalloc over kzalloc with multiply
Instead of specifying no.of bytes * size as arugment
in kzalloc, prefer kcalloc.
Signed-off-by: Karthik Tummala <kart...@techveda.org>
---
dri
in
assignment (different base types)
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:expected restricted
__be32 [usertype] serial_number
drivers/staging/comedi/drivers//ni_pcimio.c:1229:32:got unsigned int
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
drivers/s
Hello,
On Thu, Feb 9, 2017 at 4:34 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Thu, Feb 09, 2017 at 01:53:56AM +0530, Karthik Nayak wrote:
>> This patch fixes the following sparse error:
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect t
/drivers//ni_pcimio.c:1229:32:got unsigned int
This is done by removing the whole code block, since the variable
'serial_number' is only assigned but never used.
Helped-by: Ian Abbott <abbo...@mev.co.uk>
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
drivers/staging/co
thanks :)
>
Sorry for the multiple messages, now that we're deleting the whole
block, I think it makes sense to
squash the commits, so I'll send one single patch.
--
Regards,
Karthik Nayak
___
devel mailing list
de...@linuxdriverproject.org
http://d
Hey,
On Wed, Feb 8, 2017 at 11:10 PM, Ian Abbott <abbo...@mev.co.uk> wrote:
> On 08/02/2017 16:55, Karthik Nayak wrote:
>>
>> Drop the 'serial_number' variable from the struct 'ni_private' since
>> its never used after assignment.
>>
>> Signed-off-b
Drop the 'serial_number' variable from the struct 'ni_private' since
its never used after assignment.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
This is to be based on top of "staging: comedi: Fix incorrect type assignment"
to which this is replied to.
driver
Hi,
On Wed, Feb 8, 2017 at 7:18 PM, Ian Abbott <abbo...@mev.co.uk> wrote:
> On 08/02/17 13:26, Karthik Nayak wrote:
>>
>> Hello,
>>
>> On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott <abbo...@mev.co.uk> wrote:
>>>
>>> On 07/02/17 19
Hello,
On Wed, Feb 8, 2017 at 6:43 PM, Ian Abbott <abbo...@mev.co.uk> wrote:
> On 07/02/17 19:06, Karthik Nayak wrote:
>>
>> This patch fixes the following sparse error:
>> drivers/staging/comedi/drivers//ni_pcimio.c:1229:32: warning: incorrect
>> type in
/drivers//ni_pcimio.c:1229:32:got unsigned int
This is done by introducing a temporary variable which is of type
'__be32' and converting the existing variable to type 'unsigned int'.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
drivers/staging/comedi/drivers/ni_pcimio
Since the function brw_inject_one_error() is used only within
brw_test.c, make it static. This was reported as a warning by sparse.
Signed-off-by: Karthik Nayak <karthik@gmail.com>
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Removes the 'out of memory' warning issues by checkpatch
Signed-off-by: Karthik Nayak karthik@gmail.com
---
drivers/staging/et131x/et131x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 41fcaa0..f1a9296 100644
1. WARNING: else is not generally useful after a break or return
2. WARNING: quoted string split across lines
3. WARNING: break quoted strings at a space character
Signed-off-by: Karthik Nayak karthik@gmail.com
---
drivers/staging/bcm/InterfaceIdleMode.c | 11 +--
1 file changed, 5
Oops, i sent the old commit again, sorry!
Regards,
Karthik Nayak
On Tue, Sep 30, 2014 at 11:10 PM, Fabio Estevam feste...@gmail.com wrote:
On Tue, Sep 30, 2014 at 2:19 PM, Karthik Nayak karthik@gmail.com wrote:
Removes the 'out of memory' warning issues by checkpatch
Signed-off
Removes the 'out of memory' warning issued by checkpatch
Signed-off-by: Karthik Nayak karthik@gmail.com
---
drivers/staging/et131x/et131x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 41fcaa0
Removed the else statement occurring after an if statement with a
return value as per checkpatch warning.
Signed-off-by: Karthik Nayak karthik@gmail.com
---
drivers/staging/bcm/InterfaceMisc.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm
100 matches
Mail list logo
