[PATCH] staging: media/atomisp: don't compile unused code

2021-02-21 Thread karthik alapati
currently the functions defined in ibuf_ctrl_rmgr.c file are only used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected so dont't compile it when not needed, also fixes some sparse warnings Signed-off-by: karthik alapati --- drivers/staging/media/atomisp/Makefile | 5 +++-- 1 file

[PATCH 2/2] staging: wimax/i2400m: convert __le32 type to host byte-order

2021-02-21 Thread karthik alapati
fix sparse type warning by converting __le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax

[PATCH 1/2] staging: wimax/i2400m: fix byte-order issue

2021-02-21 Thread karthik alapati
fix sparse byte-order warnings by converting host byte-order type to __le16 byte-order types before assigning to hdr.length Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/op-rfkill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax

[PATCH 0/2] fix sparse warnings

2021-02-21 Thread karthik alapati
drivers/staging//wimax/i2400m/op-rfkill.c:89:25:got unsigned long . drivers/staging//wimax/i2400m/fw.c:514:27: warning: restricted __le32 degrades to integer karthik alapati (2): staging: wimax/i2400m: fix byte-order issue staging: wimax/i2400m: convert __le32 type to host byte-order

[PATCH 3/3] staging: media/atomisp: don't compile unused code

2021-02-21 Thread karthik alapati
currently the functions defined in ibuf_ctrl_rmgr.c file are only used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected so dont't compile it when not needed, also fixes some sparse warnings Signed-off-by: karthik alapati --- drivers/staging/media/atomisp/Makefile | 5 +++-- 1 file

[PATCH 2/3] staging: wimax/i2400m: convert __le32 type to host byte-order

2021-02-21 Thread karthik alapati
fix sparse type warning by converting __le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax

[PATCH 1/3] staging: wimax/i2400m: fix byte-order issue

2021-02-21 Thread karthik alapati
fix sparse byte-order warnings by converting host byte-order type to __le16 byte-order types before assigning to hdr.length Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/op-rfkill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax

[PATCH 0/3] fix sparse warnings

2021-02-21 Thread karthik alapati
'ia_css_isys_ibuf_rmgr_acquire' was not declared. Should it be static? drivers/staging//media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:106:6: warning: symbol 'ia_css_isys_ibuf_rmgr_release' was not declared. Should it be static? karthik alapati (3): staging: wimax/i2400m: fix byte-order

[PATCH] staging: media/atomisp: don't compile unused code

2021-02-20 Thread karthik alapati
currently the functions defined in ibuf_ctrl_rmgr.c file are only used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected so dont't compile it when not needed, also fixes some sparse warnings Signed-off-by: karthik alapati --- is this the right patch or just compiling out those

[PATCH] staging: wimax/i2400m: fix byte-order type issue

2021-02-20 Thread karthik alapati
fix sparse type warning by converting le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m

[PATCH] staging: wimax/i2400m: fix byte-order issue

2021-02-20 Thread karthik alapati
fix sparse byte-order warnings by converting host byte-order types to le32 types Signed-off-by: karthik alapati --- drivers/staging/wimax/i2400m/op-rfkill.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/op-rfkill.c b/drivers/staging/wimax

[PATCH] staging: wimax: fix sparse incorrect type issue

2021-02-20 Thread karthik alapati
fix sparse warning by casting to explicit user address-space pointer type Signed-off-by: karthik alapati --- drivers/staging/wlan-ng/p80211netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wlan-ng/p80211netdev.c b/drivers/staging/wlan-ng

[PATCH] staging: i2400m: use explicit host byte-order types in comparison

2021-02-18 Thread karthik alapati
convert le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- i wonder how these could be false-positives drivers/staging/wimax/i2400m/fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers

[PATCH] use explicit host byte-order types in comparison

2021-02-18 Thread karthik alapati
convert le32 types to host byte-order types before comparison Signed-off-by: karthik alapati --- i wonder how these could be false-positives drivers/staging/wimax/i2400m/fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers

[PATCH v4 2/2] staging: rtl8723bs: remove obsolete commented out code

2021-02-11 Thread karthik alapati
There is a bunch of messy, commented out code. Just delete it. Suggested-by: Dan Carpenter Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 40 +-- 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH v4 1/2] staging: rtl8723bs: fix function comments to follow kernel-doc

2021-02-11 Thread karthik alapati
there are some good function comments not following kernel-doc. Make them follow kernel-doc style Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 185 +++--- 1 file changed, 73 insertions(+), 112 deletions(-) diff --git a/drivers/staging/rtl8723bs

[PATCH v4 0/2] staging: rtl8723bs: driver cleanup

2021-02-11 Thread karthik alapati
karthik alapati (2): staging: rtl8723bs: fix function comments to follow kernel-doc staging: rtl8723bs: remove obsolete commented out code .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 225 ++ 1 file changed, 75 insertions(+), 150 deletions(-) -- 2.30.0

[PATCH] staging: rtl8723bs: remove obsolete commented out code

2021-02-10 Thread karthik alapati
fix some checkpatch "Block comments use * on subsequent lines" warnings and remove obsolete code Suggested-by: Dan Carpenter Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 44 --- 1 file changed, 9 insertions(+), 35 deletions(-)

[PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc

2021-02-10 Thread karthik alapati
fix checkpatch.pl warning for "block comments should align the * on each line" and make function comments follow kernel-doc Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 185 +++--- 1 file changed, 73 insertions(+), 112 deletions(-)

[PATCH] staging: rtl8723bs: fix function comments to follow kernel-doc

2021-02-09 Thread karthik alapati
fix checkpatch.pl warning for "block comments should align the * on each line" and make function comments follow kernel-doc Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 209 -- 1 file changed, 91 insertions(+), 118 deletions(-)

[PATCH] staging: rtl8723bs: fix block comments alignment

2021-02-09 Thread karthik alapati
fix checkpatch.pl warning for "block comments should align the * on each line" Signed-off-by: karthik alapati --- .../staging/rtl8723bs/hal/rtl8723b_phycfg.c | 204 +- 1 file changed, 102 insertions(+), 102 deletions(-) diff --git a/drivers/staging/rtl