[PATCH] staging: ks7010: use little-endian types

2017-06-08 Thread Perry Hooker
This patch fixes a number of sparse warnings of the form: drivers/staging/ks7010/ks_hostif.c:2187:29: warning: incorrect type in assignment (different base types) generated when storing little-endian data in variables that do not have a specified endianness. Signed-off-by: Perry Hooker

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

2017-04-10 Thread perry
Hi Dan, Can you clarify why the rx_buffer always holds little-endian data? It looks to me like this buffer is filled by wilc_sdio_cmd53(), which uses sdio_memcpy_toio(), which ultimately sets the data with sg_set_buf(). This function appears to use host-endian byte ordering. Regards, Perry

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

2017-03-23 Thread Robert Perry Hooker
Well, yes, all data is 'endian' one way or another, right? I guess the byte order of the tx/rx_buffers is host-endian (which could be big), or _maybe_ network-endian... Regards, Perry On Thu, 2017-03-23 at 11:33 +0300, Dan Carpenter wrote: > On Wed, Mar 22, 2017 at 07:53:28PM -0600, Rob

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

2017-03-22 Thread Robert Perry Hooker
I don't think buff is an ieee80211_hdr struct. I think it's the rx_buffer allocated at wilc_wlan.c:1417. Regards, Perry On Wed, 2017-03-22 at 12:24 +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 03:40:10PM -0600, Robert Perry Hooker wrote: > > Thanks for taking a look, Dan. S

Re: [PATCH] staging: wilc1000: use kernel define byte order macros

2017-03-21 Thread Robert Perry Hooker
). Is there an issue with calling cpu_to_le16 on a u8 that isn't encountered by implicitly casting a u8 to __le16? Or am I missing something else? Regards, Perry On Tue, 2017-03-21 at 23:19 +0300, Dan Carpenter wrote: > On Tue, Mar 21, 2017 at 01:55:40PM -0600, Perry Hooker wrote: > > Th

[PATCH] staging: rtl8192u: use __le16_to_cpu instead of cast

2017-03-12 Thread Perry Hooker
__le16 Signed-off-by: Perry Hooker <perry.hoo...@gmail.com> --- drivers/staging/rtl8192u/r8192U_dm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c index 9209aad..33d105d 100644 --- a/drivers/s

Re: [PATCH] staging: r8712u: use __le32 type for little-endian data

2017-02-11 Thread Perry Hooker
Thank you all for taking the time to look at this. I'm sorry for filling your inboxes with my mistakes - as you probably guessed, I'm new to kernel development, so I really appreciate the feedback. Perry On Fri, Feb 10, 2017 at 1:55 PM, Larry Finger <larry.fin...@lwfinger.net> wrote: >

Re: [PATCH] staging: r8712u: remove unnecessary le32_to_cpu

2017-02-10 Thread Perry Hooker
7 at 08:52:12AM -0600, Larry Finger wrote: >>> >>> On 02/10/2017 08:08 AM, Greg KH wrote: >>>> >>>> On Thu, Feb 09, 2017 at 08:51:55PM -0700, Perry Hooker wrote: >>>>> >>>>> This patch fixes the following sparse warning: &

[PATCH] staging: r8712u: use __le32 type for little-endian data

2017-02-10 Thread Perry Hooker
This patch fixes the following sparse warning: drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to restricted __le32 Signed-off-by: Perry Hooker <perry.hoo...@gmail.com> --- drivers/staging/rtl8712/usb_ops_linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH] staging: r8712u: remove unnecessary le32_to_cpu

2017-02-09 Thread Perry Hooker
This patch fixes the following sparse warning: drivers/staging/rtl8712/usb_ops_linux.c:212:33: warning: cast to restricted __le32 Signed-off-by: Perry Hooker <perry.hoo...@gmail.com> --- drivers/staging/rtl8712/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3] staging: lustre: libcfs: move assignment out of conditional

2015-07-13 Thread Perry Hooker
Found by checkpatch.pl Signed-off-by: Perry Hooker perry.hoo...@gmail.com --- .../staging/lustre/include/linux/libcfs/libcfs_fail.h | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h b/drivers

Re: [HPDD-discuss] [PATCH] staging: lustre: libcfs: move assignment out of if condition

2015-07-12 Thread Perry Hooker
] on behalf of Perry Hooker [perry.hoo...@gmail.com] Sent: Sunday, July 12, 2015 4:27 PM To: oleg.dro...@intel.com; andreas.dil...@intel.com; gre...@linuxfoundation.org; de...@driverdev.osuosl.org; hpdd-disc...@lists.01.org Cc: Perry Hooker Subject: [HPDD-discuss] [PATCH] staging: lustre: libcfs: move

[PATCH] staging: lustre: libcfs: move assignment out of conditional

2015-07-12 Thread Perry Hooker
Found by checkpatch.pl Signed-off-by: Perry Hooker perry.hoo...@gmail.com Please enter the commit message for your changes. Lines starting --- .../staging/lustre/include/linux/libcfs/libcfs_fail.h | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH] staging: lustre: libcfs: move assignment out of if condition

2015-07-12 Thread Perry Hooker
Found by checkpatch.pl Signed-off-by: Perry Hooker perry.hoo...@gmail.com --- drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_fail.h b/drivers/staging/lustre