Re: Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread shaojie . dong
Hi I do not have rtl8712 hardware So that I would remain this code and give up my patch Thank you ! > -原始邮件- > 发件人: "Dan Carpenter" > 发送时间: 2020-12-10 23:16:31 (星期四) > 收件人: shaojie.d...@isrc.iscas.ac.cn > 抄送: larry.fin...@lwfinger.net, florian.c.schilha...@googlemail.com, gre...@linuxfo

Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread shaojie . dong
Hi Thanks ! I will modify sign name correctly later Sorry to say that I have no rtl8712 hardware, so that I could not test it. From Dan Carpenter's email reply, "free_netdev(adapter->pnetdev)" function may cause use after free issue So that I reply email to ensure if this return value should b

Re: Re: [PATCH] staging: rtl8712: check register_netdev() return value

2020-12-10 Thread shaojie . dong
Hi > > This function should not be calling register_netdev(). What does that > have to do with firmware? It should also not free_netdev() because > that will just lead to a use after free in the caller. > --> check code history author changed synchronous firmware loading to asynchronous firmw

[PATCH] staging: rtl8712: check register_netdev() return value

2020-12-09 Thread shaojie . dong
From: "shaojie.dong" Function register_netdev() can fail, so we should check it's return value Signed-off-by: shaojie.dong --- drivers/staging/rtl8712/hal_init.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl871

[PATCH] staging: rtl8712: check register_netdev() return value

2020-12-06 Thread shaojie . dong
From: "shaojie.dong" Function register_netdev() can fail, so we should check it's return value Signed-off-by: shaojie.dong --- drivers/staging/rtl8712/hal_init.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/