For variables of the struct list_head* use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma <srishtis...@gmail.
list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8188eu/co
list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8188
list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8188eu
This patch series performs code cleanup like using list_for_each_entry_safe
to make code more compact and using list_entry instead of container_of for
struct list_head* variable types.
Srishti Sharma (4):
Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe
Staging: rtl8188eu
ree(
-(P *)
x )
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
-Do transformation left out by coccinelle
-Improve commit message
drivers/staging/rtl8723bs/core/rtw_cmd.c | 60
1 file changed, 30 insertions(+), 30 deletions(-)
d
On Sun, Oct 8, 2017 at 1:36 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sun, 8 Oct 2017, Srishti Sharma wrote:
>
>> On Sat, Oct 7, 2017 at 11:42 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>> >
>> >
>> > On Sat, 7 Oct 2017, S
On Sat, Oct 7, 2017 at 11:42 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 7 Oct 2017, Srishti Sharma wrote:
>
>> The cast to pointer types in kfree is not needed and can be dropped.
>> Done using the following semantic by coccinelle.
lumn_end)
c2 = int (p2[0].column)
if l1 == l2 and c1+1 == c2:
cocci.include_match(False)
@r3@
position r1.p1, r1.p2;
@@
if(...
- )@p1
-{@p2
+) {
...
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
-Improve commit message.
drivers/staging/pi4
t;data = d;
|
- l->data = d;
...
- l->function = f;
)
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtlwifi/phydm/phydm_interface.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtlwifi/phydm/phydm_interface.c
b/drive
p1;
p2 << r1.p2;
@@
l1 = int (p1[0].line)
l2 = int (p2[0].line)
c1 = int (p1[0].column_end)
c2 = int (p2[0].column)
if l1 == l2 and c1+1 == c2:
cocci.include_match(False)
@r3@
position r1.p1, r1.p2;
@@
if(...
- )@p1
-{@p2
+) {
...
}
Signed-off-by: Srishti Sharma <srisht
occinelle.T1 = T[:-2]
else:
coccinelle.T1 = T
print T, T1
@r2@
type r1.T;
identifier p.T1;
@@
- typedef
struct
+ T1
{
...
}
- T
;
@r3@
type r1.T;
identifier p.T1;
@@
- T
+ struct T1
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
.../media/atomisp/pci/atomisp2/css2400/runtime/spctrl/
The cast to pointer types in kfree is not needed and can be dropped.
Done using the following semantic by coccinelle.
@r@
type T,P;
T* x;
@@
kfree(
-(P *)
x )
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_cmd.
list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v3
-Add a blank l
list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2
-Make commit message cl
list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2
-Make th
list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2
-Make comm
list_for_each_entry_safe;
@@
f(...){
+T1* tmp;
<+...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2
-Make comm
On Wed, Oct 4, 2017 at 10:37 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Wed, 4 Oct 2017, Srishti Sharma wrote:
>
>> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter <dan.carpen...@oracle.com>
>> wrote:
>> > On Wed, Oct 04, 2017 at 03:34:05P
subject line to make
>> them unique.
>>
>
> And the subject needs to start with [PATCH v3] and then after the
> Signed off by line put:
Shouldn't it be only v2 as I haven't sent a v2 for this before.
Regards,
Srishti
>
> ---
> v2 and v3: Changes to the su
gt;> >
>> > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote:
>> > > > Use list_for_each_entry_safe when the list elements may get deleted
>> > > > during traversal.
>> > >
>> > > This patch is fine as a clea
ile(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 +++-
1 file changed, 3 insertions(+), 5 del
ile(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_xmit.c | 23 ++-
1 file changed, 6 insertions(+),
ile(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...+>
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
For variables of the struct list_head* use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma <srishtis...@gmail.
;
...
-while(...)
+list_for_each_entry_safe(pos,tmp,l,m)
{
...
-pos = container_of(l,T1,m);
...
-l=e;
<+...
list_del_init(>m)
...+>
}
...
}
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 22 ++
1 file change
On Tue, Oct 3, 2017 at 9:44 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote:
>> Replaces instances of container_of with list_entry to
>> access current list element.
>>
>> Srishti Sharma (6):
&
For variables of type struct list_head* use list_entry to access
current list element instead of using container_of. Done by the
following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma <srishtis...@gmail.
For variables of type struct list_head* use list_entry to access
current list element instead of using container_of. Done using
the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma <srishtis...@gmail.
For variables of the type struct list_head* use list_entry to access
current list element instead of using container_of. Done using the
following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma <srishtis...@gmail.
For variables of the type struct list_head* use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma <srishtis...@gmail.
For variables of the type struct list_head use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma <srishtis...@gmail.
For variables of the struct list_head* use list_entry to access
current list element instead of using container_of.
Done using the following semantic patch by coccinelle.
@r@
struct list_head* l;
@@
-container_of
+list_entry
(l,...)
Signed-off-by: Srishti Sharma <srishtis...@gmail.
Replaces instances of container_of with list_entry to
access current list element.
Srishti Sharma (6):
Staging: rtl8188eu: core: Use list_entry instead of container_of
Staging: rtl8188eu: core: Use list_entry instead of container_of
Staging: rtl8188eu: core: Use list_entry instead
On Sat, Sep 30, 2017 at 11:51 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 30 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>> >
>> >
>> > On Sat, 30 Sep 20
On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 30 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>> >
>> >
>> > On Sat, 30
On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 30 Sep 2017, Srishti Sharma wrote:
>
>> For variables of the type struct list_head* use list_entry to access
>> the current list element instead of using container_of.
>&g
_entry
(
...)
)
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c
b/drivers/staging/rtl8188eu/core/rtw_sta
_entry
(
...)
)
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_recv.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c
b/drivers/staging/rtl8188eu/core/rtw_recv.c
index 3fd5
Remove unused fields and comments associated with them in
the structure definition.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
- Use the word field instead of variable.
drivers/staging/dgnc/dgnc_driver.h | 9 -
1 file changed, 9 deletions(-)
diff
Eliminate the fields that are not used and the comments
associated with them.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
- Use the word field instead of variable.
drivers/staging/dgnc/dgnc_driver.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/d
Remove fields that are not used, from structure definitions , and
eliminate the comments associated with them.
Srishti Sharma (2):
Staging: dgnc: Remove unused variables in structure definition
Staging: dgnc: Remove unused variable in structure
drivers/staging/dgnc/dgnc_driver.h | 15
Eliminate the variables that are not used and the comments
associated with them.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/stagin
Remove unused variables and comments associated with them in
the structure definition.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/s
This patch series attempts to remove unused variables in structure
variables and the comments associated with them.
Srishti Sharma (2):
Staging: dgnc: Remove unused variables in structure definition
Staging: dgnc: Remove unused variable in structure
drivers/staging/dgnc/dgnc_driver.h | 15
On Sat, Sep 16, 2017 at 5:45 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>> >
>> >
>> > On Sat, 16
On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> Some variables in the structure were unused and hence them and
>> the comments associated with them can be removed.
>
> How did you
Some variables in the structure were unused and hence them and
the comments associated with them can be removed.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/stagin
)
S
|
-if(E==NULL)
+if(!E)
S
)
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/irda/net/discovery.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/irda/net/discovery.c
b/drivers/staging/irda/net/discovery.c
index 3
On Sat, Sep 16, 2017 at 2:39 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>> >
>> >
>> > On Sat, 16 Se
On Sat, Sep 16, 2017 at 1:30 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> Write assignment statement outside the if statement. Done using
>> the following semantic patch by coccinelle.
>>
>> @@
>&g
Parentheses are not needed on the right hand side of assignment
statement in most cases. Done using the following semantic
patch by coccinelle.
@@
identifier E,F,G,f;
expression e,r;
@@
(
E = (G == F);
|
E = (e == r);
|
E =
-(
...
-)
;
)
Signed-off-by: Srishti Sharma <srishtis...@gmail.
Write assignment statement outside of the if statement. Done
using the following semantic patch by coccinelle.
@@
identifier E;
expression F;
statement S;
@@
-if((E = F))
+E = F;
+if(E)
S
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/irda/drivers/irda-usb
This patch series intends to remove the assignment statements
inside the if statement, and eliminates the cases of parentheses
around the right hand side of assignment generated as a result of
the same.
Srishti Sharma (2):
Staging: irda: Don't use assignment inside if statement
Staging
Write assignment statement outside the if statement. Done using
the following semantic patch by coccinelle.
@@
identifier E;
expression F;
statement S;
@@
-if((E = F))
+E = F;
+if(E)
S
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
-Semicolon was missing
On Sat, Sep 16, 2017 at 1:08 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 16 Sep 2017, Srishti Sharma wrote:
>
>> Write assignment statement outside the if statement. Done using
>> the following semantic patch by coccinelle.
>>
>> @@
>&g
On Sat, Sep 16, 2017 at 1:03 AM, Srishti Sharma <srishtis...@gmail.com> wrote:
> Write assignment statement outside the if statement. Done using
> the following semantic patch by coccinelle.
>
> @@
> identifier E;
> expression F;
> statement S;
> @@
>
>
Write assignment statement outside the if statement. Done using
the following semantic patch by coccinelle.
@@
identifier E;
expression F;
statement S;
@@
-if((E = F))
+E = F
+if(E)
S
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/irda/drivers/irda-usb
Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
- eliminate parentheses around the
Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_sysfs.c | 2 +-
1 file chan
Use kcalloc instead of kzalloc to check for overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/lustre/lustre/obdclass/cl_object.c | 2
Use kcalloc instead of kzalloc to check for an overflow before
multiplication. Done using the following semantic patch by
coccinelle.
http://coccinelle.lip6.fr/rules/kzalloc.cocci
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/c
Merge the assignment and the return statements to return the value
directly. Done using the following semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging
Merge the assignment and the return statements to return the value
directly. Done using the following semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging
On Tue, Sep 12, 2017 at 2:49 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>> The use of volatile for the variable monitor_lock is unnecessary.
>>
>> Signed-off-by: Srishti Sharma <srishtis...
On Mon, Sep 11, 2017 at 9:54 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Thu, Sep 07, 2017 at 07:44:52PM +0530, Srishti Sharma wrote:
>> Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.
>>
>> Signed-off-by: Srishti Sharma <srishtis..
On Mon, Sep 11, 2017 at 9:45 PM, Srishti Sharma <srishtis...@gmail.com> wrote:
> On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>>
>>
>> On Mon, 11 Sep 2017, Srishti Sharma wrote:
>>
>>> On Mon, Sep 11, 2017 at 9:3
Remove the variable monitor_lock as it is not used anywhere.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
-The variable that was not to be declared as volatile can be
eliminated as it is not being used anywhere.
drivers/staging/ccree/ssi_request_mgr.c |
On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Mon, 11 Sep 2017, Srishti Sharma wrote:
>
>> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gre...@linuxfoundation.org> wrote:
>> > On Mon, Sep 11, 2017 at 09:29:31PM +05
On Mon, Sep 11, 2017 at 9:34 PM, Greg KH <gre...@linuxfoundation.org> wrote:
> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote:
>> The use of volatile for the variable monitor_lock is unnecessary.
>>
>> Signed-off-by: Srishti Sharma <srishtis...@gmail.c
The use of volatile for the variable monitor_lock is unnecessary.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_request_mgr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_request_mgr.c
b/drivers/staging
Remove extra blank line.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/rtl8712/rtl8712_event.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8712/rtl8712_event.h
b/drivers/staging/rtl8712/rtl8712_event.h
index b383740..cad7085
Fix alignment so that it matches open parentheses.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c
b/drivers/staging/xgifb/XGI_mai
On Sat, Sep 9, 2017 at 10:29 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>
> Coccinelle is not always p
Merge the assignment and return statements to return the value
directly. Done using the following semantic patch by
coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
-C
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_sysfs.c | 4 +---
1 file c
On Sat, Sep 9, 2017 at 12:26 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>>
>> @@
>> local ide
Merge the assignment and the return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v4:
-Edit commit message so that it re
On Sat, Sep 9, 2017 at 12:27 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>> >
>> >
>> > On Sat, 9 Sep 20
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v3:
-Edit commit message so that it respe
On Sat, Sep 9, 2017 at 2:28 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Merge the assignment and return statements to return the value
>> directly. Done using coccinelle.
>>
>> @@
>> local ide
Merge the assignment and return statements to return the value
directly. Done using coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
- Edit commit message so that it re
On Sat, Sep 9, 2017 at 1:42 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Sat, 9 Sep 2017, Srishti Sharma wrote:
>
>> Return the return value of a function directly, instead of first saving it
>> in a variable and then returning it. This change was mad
Return the return value of a function directly, instead of first saving it in a
variable and then returning it. This change was made using the following
semantic patch by coccinelle.
@@
local idexpression ret;
expression e;
@@
-ret =
+return
e;
-return ret;
Signed-off-by: Srishti Sharma
On Fri, Sep 8, 2017 at 8:59 PM, Sean Paul <seanp...@chromium.org> wrote:
> On Fri, Sep 8, 2017 at 11:11 AM, Srishti Sharma <srishtis...@gmail.com> wrote:
>> Use BIT(x) instead of (1<<x).
>>
>> Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
>
Use BIT(x) instead of (1<<x).
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/media/imx/imx-media.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/media/imx/imx-media.h
b/drivers/staging/media/imx/imx-m
On Fri, Sep 8, 2017 at 8:08 PM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Fri, Sep 08, 2017 at 07:38:18PM +0530, Srishti Sharma wrote:
>> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>>
>> Signed-off-by: Srishti Sharma <srishtis...
On Fri, Sep 8, 2017 at 7:40 PM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Fri, 8 Sep 2017, Srishti Sharma wrote:
>
>> Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
>>
>> Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/media/omap4iss/iss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss.c
b/drivers/staging
Use BIT(x) instead of using (1<<x), reported by checkpatch.pl.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v2:
- Add tab spaces before BIT macro.
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --g
Use BIT(x) instead of (1<<x), reported by checkpatch.pl.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
drivers/staging/ccree/ssi_cipher.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.h
b/drivers/s
On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef <gi...@benyossef.com> wrote:
> Hi,
>
> On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma <srishtis...@gmail.com> wrote:
>> Remove the local variable inflight_counter as it is never used.
>>
>> Signed-off-by
Remove the local variable inflight_counter as it is never used.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v5:
- Correct the format of the subject.
drivers/staging/ccree/ssi_cipher.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging
thers have done. It is not really
> possible to guess correctly. However, one does not generally include the
> extension on a filename.
>
Yes, they have not used the filename in the subject line . So I'll change it to
the required format .
Thanks ,
Srishti
> julia
>
> On Thu, 7 Sep 2017,
Remove local variable inflight_counter, as it is never used.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Change in v4:
-There is no longer a need to make the comment more comprehensible, as I
have deleted the variable associated with it. The v3 of this patch was
not
u and everyone's trying to be nice about it but
> patches are fundamentally points of disagreement and that's stress.
>
> regards,
> dan carpenter
>
Thanks , I'll be more careful !
Regards,
Srishti
___
devel mailing list
de...@linuxdriverprojec
On Thu, Sep 7, 2017 at 2:56 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>> >
>> >
>> > On Thu, 7 Sep 201
On Thu, Sep 7, 2017 at 2:47 AM, Julia Lawall <julia.law...@lip6.fr> wrote:
>
>
> On Thu, 7 Sep 2017, Srishti Sharma wrote:
>
>> Remove local variable inflight_counter ,as it is never used.
>
> "counter ,as" -> "counter, as"
>
Remove local variable inflight_counter ,as it is never used.
Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
---
Changes in v3:
- There was no longer a need to make the comment more comprehensible as
I have deleted the variable associated with it because it is unused .
drivers/s
On Thu, Sep 7, 2017 at 2:29 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote:
> On Thu, Sep 07, 2017 at 12:54:23AM +0530, Srishti Sharma wrote:
>> Correct spelling of counter in comment .
>>
>> Signed-off-by: Srishti Sharma <srishtis...@gmail.com>
>> ---
1 - 100 of 148 matches
Mail list logo
