Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2018-01-09 Thread Greg Kroah-Hartman
On Thu, Dec 21, 2017 at 11:34:10AM +0200, Sakari Ailus wrote: > Hi Joe, > > On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote: > > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > > index a1c81c12718c..4338b8a

Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-21 Thread Sakari Ailus
Hi Joe, On Tue, Dec 19, 2017 at 10:15:08AM -0800, Joe Perches wrote: > diff --git a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > b/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c > index a1c81c12718c..4338b8a1309f 100644 > --- a/drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm.c

Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-20 Thread Zhang Rui
On Tue, 2017-12-19 at 10:15 -0800, Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ >   xargs perl -i -e 'local $/; while (<>) { > s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444

Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-20 Thread Robert Jarzmik
"Rafael J. Wysocki" writes: > On Tuesday, December 19, 2017 7:15:08 PM CET Joe Perches wrote: >> Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. >> >> Done with perl script: >> >> $ git grep -w --name-only DEVICE_ATTR | \ >> xargs perl -i -e 'local $/; while (<>) { >> s/\bDEVICE_A

Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-20 Thread Sagi Grimberg
for the NVMe bits, Acked-by: Sagi Grimberg ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-20 Thread Rafael J. Wysocki
On Tuesday, December 19, 2017 7:15:08 PM CET Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { > s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO

[-next PATCH 3/4] treewide: Use DEVICE_ATTR_RO

2017-12-19 Thread Joe Perches
Convert DEVICE_ATTR uses to DEVICE_ATTR_RO where possible. Done with perl script: $ git grep -w --name-only DEVICE_ATTR | \ xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IRUGO\s*|\s*0444\s*)\)?\s*,\s*\1_show\s*,\s*NULL\s*\)/DEVICE_ATTR_RO(\1)/g; print;