Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

2020-03-09 Thread Shreeya Patel
On Mon, 2020-03-09 at 08:35 +0100, Julia Lawall wrote: > On Mon, 9 Mar 2020, Shreeya Patel wrote: > > > On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > > > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > > > Add space around operators for improving the code > > > > readability.

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

2020-03-09 Thread Julia Lawall
On Mon, 9 Mar 2020, Shreeya Patel wrote: > On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > > Add space around operators for improving the code > > > readability. > > > > Hello again Shreeya. > > > I have some questions here... >

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

2020-03-08 Thread Shreeya Patel
On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > Add space around operators for improving the code > > readability. > > Hello again Shreeya. > I have some questions here... > The subject isn't really quite appropriate as you > ar

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

2020-03-08 Thread Shreeya Patel
On Sun, 2020-03-08 at 16:05 -0700, Joe Perches wrote: > On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > > Add space around operators for improving the code > > readability. > > Hello again Shreeya. > > The subject isn't really quite appropriate as you > are not doing this space around o

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

2020-03-08 Thread Joe Perches
On Mon, 2020-03-09 at 03:30 +0530, Shreeya Patel wrote: > Add space around operators for improving the code > readability. Hello again Shreeya. The subject isn't really quite appropriate as you are not doing this space around operator addition for the entire subsystem. IMO, the subject should be

[Outreachy kernel] [PATCH] Staging: rtl8188eu: Add space around operators

2020-03-08 Thread Shreeya Patel
Add space around operators for improving the code readability. Reported by checkpatch.pl Signed-off-by: Shreeya Patel --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 40 +++ 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ml