Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: remove implicit bool->int conversions

2017-09-22 Thread Aishwarya Pant
On Fri, Sep 22, 2017 at 11:52:36AM +0200, Julia Lawall wrote: > > > On Fri, 22 Sep 2017, Aishwarya Pant wrote: > > > Implicit type conversions are bad; they hinder readability of code and have > > potential to cause bugs. Here the variable wait_ack is always supplied a > > bool > > value while

Re: [Outreachy kernel] [PATCH] staging: rtl8188eu: remove implicit bool->int conversions

2017-09-22 Thread Julia Lawall
On Fri, 22 Sep 2017, Aishwarya Pant wrote: > Implicit type conversions are bad; they hinder readability of code and have > potential to cause bugs. Here the variable wait_ack is always supplied a bool > value while in function declarations it is defined as an int type. Fix it by > defining