On Sun, 25 Oct 2020, Elena Afanasova wrote:
> Replace kmalloc + memset 0 by a call to kzalloc which zeroes memory too.
> Found with Coccinelle.
>
> Signed-off-by: Elena Afanasova <eafanas...@gmail.com>
> ---
> Changes in v3:
> - use array_size()
> Changes in v2:
> - correct the subject line
> - correct the commit message
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> index 63a561ab4a76..53ce97aae206 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
> @@ -227,13 +227,10 @@ static struct ieee80211_txb *ieee80211_alloc_txb(int
> nr_frags, int txb_size,
> {
> struct ieee80211_txb *txb;
> int i;
> - txb = kmalloc(
> - sizeof(struct ieee80211_txb) + (sizeof(u8 *) * nr_frags),
> - gfp_mask);
> + txb = kzalloc(sizeof(*txb) + array_size(sizeof(u8 *), nr_frags),
> gfp_mask);
There is no need to exceed 80 characters here.
julia
> if (!txb)
> return NULL;
>
> - memset(txb, 0, sizeof(struct ieee80211_txb));
> txb->nr_frags = nr_frags;
> txb->frag_size = __cpu_to_le16(txb_size);
>
> --
> 2.25.1
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/outreachy-kernel/43e637becf35f98a952c38ee1a5b690798c62c75.camel%40gmail.com.
>
_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
