Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Dan Carpenter
No signed-off line. Just merge both patches since they do the same thing and go to the same maintainers. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Dan Carpenter
On Mon, Jan 13, 2014 at 09:02:33AM +, Joe Borġ wrote: Apologies for missing that. Feel free to add signed-off-by Joe Borg cyborg101...@gmail.com to the commit message. Unless it's a bugfix for a security issue then we don't fix other people's patches. You have to resend. regards, dan

[PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Joe Borg
Signed-off-by Joe Borg cyborg101...@gmail.com --- drivers/staging/comedi/drivers/das1800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c index 1880038..8fb87df 100644 ---

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 08:14:46PM +, Joe Borg wrote: Signed-off-by Joe Borg cyborg101...@gmail.com You need a changelog comment here, please. And is that your real email address and name? greg k-h ___ devel mailing list

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 09:23:11PM +, Joe Borġ wrote: Ok, will do the change log. Yes, it's my real name and email... I know the email address is embarrassing, but genuine :). Regards, Joseph David Borġ There's nothing wrong with using Joe Borġ as your signed-off-by: line, as

[PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Joe Borg
Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data(). Signed-off-by Joe Borg cyborg101...@gmail.com --- drivers/staging/comedi/drivers/das1800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 09:47:59PM +, Joe Borg wrote: Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data(). Please wrap your changelog comments at 72 colums, like git asks you to when you type them in. Signed-off-by Joe Borg

[PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Joe Borg
Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data(). Signed-off-by Joe Borg cyborg101...@gmail.com --- drivers/staging/comedi/drivers/das1800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-13 Thread Greg KH
On Mon, Jan 13, 2014 at 11:19:15PM +, Joe Borg wrote: Fixed an error flagged by checkpatch.pl, 'foo * bar should be foo *bar' in the parameters of function munge_data(). Ok, real minor nits here, but I'd like you to make them for future patches as it makes my life easier, and I don't like

[PATCH] DAS1800: Fixing foo * bar should be foo *bar

2014-01-11 Thread Joe Borg
--- drivers/staging/comedi/drivers/das1800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das1800.c b/drivers/staging/comedi/drivers/das1800.c index 1880038..8fb87df 100644 --- a/drivers/staging/comedi/drivers/das1800.c +++