Re: [PATCH] Drivers:Staging:vt6656: Fixed checkpatch warning

2014-11-25 Thread Dan Carpenter
On Tue, Nov 25, 2014 at 07:05:51PM +0530, Athira Lekshmi C V wrote: > Fixed the checkpatch warning: > WARNING: else is not generally useful after a break or return > This patch adds a compile warning. > Signed-off-by: Athira Lekshmi C V Btw, signing and from should be your legal name that you

[PATCH] Drivers:Staging:vt6656: Fixed checkpatch warning

2014-11-25 Thread Athira Lekshmi C V
Fixed the checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Athira Lekshmi C V --- drivers/staging/vt6656/rxtx.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/drivers/staging/vt6656/rxtx.

Re: [PATCH] Drivers:staging:vt6656: Fixed checkpatch warning

2014-11-25 Thread Dan Carpenter
On Tue, Nov 25, 2014 at 05:45:40PM +0530, Athira Lekshmi C V wrote: > Fixed the checkpatch warning: > WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are > __aligned(2) For these changes the change log must say how you determined both source and destination are aligned c

[PATCH] Drivers:staging:vt6656: Fixed checkpatch warning

2014-11-25 Thread Athira Lekshmi C V
Fixed the checkpatch warning: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Signed-off-by: Athira Lekshmi C V --- drivers/staging/vt6656/rxtx.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/v