On Mon, 11 Mar 2019 at 18:40, Sam Ravnborg wrote:
>
> Hi Eze
> >
> > Why is this driver still here? I thought we migrated everyhing to
> > tinydrm already.
> Some have been ported, some are waiting for a user to do the port.
> If you looks at tinydrm you will see:
> ili9225.c ili9341.c
>
> And
Hi Dante.
> Hello Sam, thank you very much for your comments,
> As I told Dan (my email did not reach the mailing list) this is my
> first attempt to contribute,
> So I'm learning a lot from your advice and corrections.
>
> I will look for TODO lists to see if there are more useful
>
Hi Eze
>
> Why is this driver still here? I thought we migrated everyhing to
> tinydrm already.
Some have been ported, some are waiting for a user to do the port.
If you looks at tinydrm you will see:
ili9225.c ili9341.c
And we also have under panel:
panel-ilitek-ili9881c.c
Hi everyone,
Dante: please avoid top-posting. In other words, put your replies in-line,
like I'm gonna do now. See below (and see how discussion goes on other threads).
On Mon, 11 Mar 2019 at 17:34, DANTE JAVIER PAZ wrote:
>
> Hello Sam, thank you very much for your comments,
> As I told Dan
Hello Sam, thank you very much for your comments,
As I told Dan (my email did not reach the mailing list) this is my
first attempt to contribute,
So I'm learning a lot from your advice and corrections.
I will look for TODO lists to see if there are more useful
contributions to make, all
Hi Dante
Thanks for the patch.
On Sat, Mar 09, 2019 at 06:48:52PM -0300, Dante Paz wrote:
> From: Dante Paz
>
> Style and coding function issues were corrected, by avoiding macro
> functions with a conflicting coding style.
> Signed-off-by: Dante Paz
But it raised a few comments.
I feel like you need to break the patch up a bit and do the white
space fixes separate from the other changes.
(Probably you're going to have to redo this several times because it's
hard to review when it's so mixed up with multiple changes at the same
time).
regards,
dan carpenter
On Sat, Mar 09, 2019 at 06:48:52PM -0300, Dante Paz wrote:
> From: Dante Paz
>
> Style and coding function issues were corrected, by avoiding macro
> functions with a conflicting coding style.
> Signed-off-by: Dante Paz
Line too long. No blank. Fix indenting.
It's not really clear
From: Dante Paz
Style and coding function issues were corrected, by avoiding macro
functions with a conflicting coding style.
Signed-off-by: Dante Paz
---
drivers/staging/fbtft/fbtft-bus.c | 440 +-
1 file changed, 254 insertions(+), 186 deletions(-)
diff
