Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-13 Thread Dan Carpenter
On Mon, Apr 13, 2015 at 01:25:15PM +0200, Peter Senna Tschudin wrote: > Line 4677 of http://pastebin.com/2bi9Dg7k looks like a bug > > diff -u -p a/arch/powerpc/kernel/signal_32.c b/arch/powerpc/kernel/signal_32.c > - regs->nip = (unsigned long) (unsigned long)ksig->ka.sa.sa_handler; I don'

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-13 Thread Peter Senna Tschudin
Line 4677 of http://pastebin.com/2bi9Dg7k looks like a bug diff -u -p a/arch/powerpc/kernel/signal_32.c b/arch/powerpc/kernel/signal_32.c - regs->nip = (unsigned long) (unsigned long)ksig->ka.sa.sa_handler; On Mon, Apr 13, 2015 at 1:21 PM, Geert Uytterhoeven wrote: > Hi Peter, > > On Mon,

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-13 Thread Geert Uytterhoeven
Hi Peter, On Mon, Apr 13, 2015 at 1:14 PM, Peter Senna Tschudin wrote: >> Perhaps checkpatch should complain about casts outside header files? > Cocinelle found 664 double casts: > http://pastebin.com/2bi9Dg7k > > and 9 triple casts: > http://pastebin.com/RkJhPTTV I think double casts are only n

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-13 Thread Peter Senna Tschudin
On Sun, Apr 12, 2015 at 5:38 PM, Geert Uytterhoeven wrote: > On Sun, Apr 12, 2015 at 3:48 PM, Peter Senna Tschudin > wrote: >> On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven >> wrote: >>> On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin >>> wrote: Sparse compalins about casting

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-13 Thread Dan Carpenter
On Mon, Apr 13, 2015 at 11:16:49AM +0200, Peter Senna Tschudin wrote: > On Mon, Apr 13, 2015 at 11:10 AM, Dan Carpenter > wrote: > > On Sun, Apr 12, 2015 at 11:26:43AM +0200, Peter Senna Tschudin wrote: > >> Sparse compalins about casting void * to u64 on i386. > >> Change the cast to resource_siz

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-13 Thread Peter Senna Tschudin
On Mon, Apr 13, 2015 at 11:10 AM, Dan Carpenter wrote: > On Sun, Apr 12, 2015 at 11:26:43AM +0200, Peter Senna Tschudin wrote: >> Sparse compalins about casting void * to u64 on i386. >> Change the cast to resource_size_t. >> >> Signed-off-by: Peter Senna Tschudin >> --- >> >> Tested by compilati

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-13 Thread Dan Carpenter
On Sun, Apr 12, 2015 at 11:26:43AM +0200, Peter Senna Tschudin wrote: > Sparse compalins about casting void * to u64 on i386. > Change the cast to resource_size_t. > > Signed-off-by: Peter Senna Tschudin > --- > > Tested by compilation only. Tested for x86 and x86_64. > > drivers/staging/goldf

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-12 Thread Geert Uytterhoeven
On Sun, Apr 12, 2015 at 8:14 PM, Joe Perches wrote: > On Sun, 2015-04-12 at 17:38 +0200, Geert Uytterhoeven wrote: >> Perhaps checkpatch should complain about casts outside header files? > > I think that's not feasible/desirable. > > type casting is pretty common and necessary. > There are 50k+ ca

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-12 Thread Joe Perches
On Sun, 2015-04-12 at 17:38 +0200, Geert Uytterhoeven wrote: > Perhaps checkpatch should complain about casts outside header files? I think that's not feasible/desirable. type casting is pretty common and necessary. There are 50k+ casts in drivers/ alone. ___

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-12 Thread Geert Uytterhoeven
On Sun, Apr 12, 2015 at 3:48 PM, Peter Senna Tschudin wrote: > On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven > wrote: >> On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin >> wrote: >>> Sparse compalins about casting void * to u64 on i386. >>> Change the cast to resource_size_t. >>> >>

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-12 Thread Peter Senna Tschudin
On Sun, Apr 12, 2015 at 3:05 PM, Geert Uytterhoeven wrote: > On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin > wrote: >> Sparse compalins about casting void * to u64 on i386. >> Change the cast to resource_size_t. >> >> Signed-off-by: Peter Senna Tschudin >> --- >> >> Tested by compilatio

Re: [PATCH] Fix pointer cast for 32 bits arch

2015-04-12 Thread Geert Uytterhoeven
On Sun, Apr 12, 2015 at 11:26 AM, Peter Senna Tschudin wrote: > Sparse compalins about casting void * to u64 on i386. > Change the cast to resource_size_t. > > Signed-off-by: Peter Senna Tschudin > --- > > Tested by compilation only. Tested for x86 and x86_64. > > drivers/staging/goldfish/goldfi

[PATCH] Fix pointer cast for 32 bits arch

2015-04-12 Thread Peter Senna Tschudin
Sparse compalins about casting void * to u64 on i386. Change the cast to resource_size_t. Signed-off-by: Peter Senna Tschudin --- Tested by compilation only. Tested for x86 and x86_64. drivers/staging/goldfish/goldfish_nand.c | 3 ++- include/linux/goldfish.h | 2 +- 2 files ch