On Sat, Sep 07, 2019 at 04:48:21PM +0200, Sandro Volery wrote:
> > Joe's comments are, of course, correct as well.
> >
> > regards,
> > dan carpenter
> >
>
> I'll take a look at Joe's suggestions too sometime tonight. I'd feel kinda
> bad tho if I just apply his work and send it in?
Don't
> On 7 Sep 2019, at 16:39, Dan Carpenter wrote:
>
> You need a subject prefix. It should be something like:
>
> [PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c
>
Thanks for the reply! I'll try to do that better for my next patch.
> Generally "Fix" is considered
You need a subject prefix. It should be something like:
[PATCH] Staging: gasket: Fix parentheses malpractice in apex_driver.c
Generally "Fix" is considered better style than "Fixed". We aren't
going to care about that in staging, but the patch prefix is mandatory
so you will need to redo it
On Fri, 2019-09-06 at 20:38 +0200, volery wrote:
> There were some parentheses at the end of lines, which I took care of.
Not every instance of this checkpatch warning should be changed.
This specific instance is because it uses very long identifiers
and really maybe should just be left alone.
There were some parentheses at the end of lines, which I took care of.
This is my first patch.
Signed-off-by: Sandro Volery
---
drivers/staging/gasket/apex_driver.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gasket/apex_driver.c
