Re: [PATCH] Resolve RF Type mismatch

2018-02-07 Thread Dan Carpenter
Also the patch prefix is wrong in the email subject. It should say, [PATCH] staging: rtl8723bs: Resolve RF Type mismatch On Wed, Feb 07, 2018 at 01:31:48AM +0900, Kangmin Park wrote: > Oops, Sorry for being stupid cuz of first time to use git email. No problem. We were all newbies once. Send

Re: [PATCH] Resolve RF Type mismatch

2018-02-07 Thread Dan Carpenter
On Wed, Feb 07, 2018 at 12:57:13AM +0900, Kangmin Park wrote: > From: pr0gr4m No changelog, no sign-off. Changelogs are required but especially in this case, it's not immediately obvious what this patch is about. This patch has unrelated white space changes as well.

Re: [PATCH] Resolve RF Type mismatch

2018-02-06 Thread Bastien Nocera
On Wed, 2018-02-07 at 00:57 +0900, Kangmin Park wrote: > From: pr0gr4m This needs a commit message. I don't understand what the code is trying to do. ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Resolve RF Type mismatch

2018-02-06 Thread Kangmin Park
Oops, Sorry for being stupid cuz of first time to use git email. RF_TYPE and ODM_RF_TYPE on staging/rtl8723bs is different from staging/rtlwifi 's - updated from v 4.14 - So, I try to update code on staging/rtl8723bs in comparison with staging/rtlwifi. commit message is "Update rf_type and

[PATCH] Resolve RF Type mismatch

2018-02-06 Thread Kangmin Park
From: pr0gr4m --- drivers/staging/rtl8723bs/hal/odm.h | 17 + drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 16 ++-- drivers/staging/rtl8723bs/include/rtw_rf.h| 15 ++-