Re: [PATCH] staging: android: ion: fix coding style issue

2017-04-26 Thread adheer chandravanshi
On Wed, Apr 26, 2017 at 12:26 AM, Greg KH wrote: > On Sun, Apr 23, 2017 at 03:37:29PM +0530, Adheer Chandravanshi wrote: >> Use tab instead of spaces for indentation, as reported by checkpatch.pl >> >> Signed-off-by: Adheer Chandravanshi >> --- >> drivers/staging/android/ion/ion_cma_heap.c | 6 +

Re: [PATCH] staging: android: ion: fix coding style issue

2017-04-25 Thread Greg KH
On Sun, Apr 23, 2017 at 03:37:29PM +0530, Adheer Chandravanshi wrote: > Use tab instead of spaces for indentation, as reported by checkpatch.pl > > Signed-off-by: Adheer Chandravanshi > --- > drivers/staging/android/ion/ion_cma_heap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH] staging: android: ion: fix coding style issue

2017-04-23 Thread Adheer Chandravanshi
Use tab instead of spaces for indentation, as reported by checkpatch.pl Signed-off-by: Adheer Chandravanshi --- drivers/staging/android/ion/ion_cma_heap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/andro

[PATCH] staging: android: ion: fix coding style issue

2017-02-10 Thread Youngdo, Lee
Replaced sizeof(struct foo) into sizeof(*ptr), found by checkpatch.pl. Signed-off-by: Youngdo, Lee --- drivers/staging/android/ion/ion_cma_heap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/io

Re: [PATCH] staging: android/ion: Fix coding style issues

2017-01-11 Thread Greg KH
On Wed, Jan 11, 2017 at 11:20:39PM +0200, Bogdan Purcareata wrote: > Fix following checkpatch warnings: > - Lines over 80 characters > - void function with return statement > - Unaligned comment mark > - Header function prototypes missing variable names That's a lot of different things to be doing

[PATCH] staging: android/ion: Fix coding style issues

2017-01-11 Thread Bogdan Purcareata
Fix following checkpatch warnings: - Lines over 80 characters - void function with return statement - Unaligned comment mark - Header function prototypes missing variable names Signed-off-by: Bogdan Purcareata --- drivers/staging/android/ion/ion-ioctl.c | 3 ++- drivers/staging/android/ion/ion_

Re: [PATCH] staging: android/ion: Fix coding style issues

2017-01-10 Thread Joe Perches
On Tue, 2017-01-10 at 23:40 +0200, Bogdan Purcareata wrote: > Fix following checkpatch warnings: > - Lines over 80 characters > - void function with return statement > - Unaligned comment mark > - Header function prototypes missing variable names Please read Documentation/SubmittingPatches (umm, m

Re: [PATCH] staging: android/ion: Fix coding style issues

2017-01-10 Thread Greg KH
On Tue, Jan 10, 2017 at 11:40:30PM +0200, Bogdan Purcareata wrote: > Fix following checkpatch warnings: > - Lines over 80 characters > - void function with return statement > - Unaligned comment mark > - Header function prototypes missing variable names > > Sent against staging-next. > > Signed-o

[PATCH] staging: android/ion: Fix coding style issues

2017-01-10 Thread Bogdan Purcareata
Fix following checkpatch warnings: - Lines over 80 characters - void function with return statement - Unaligned comment mark - Header function prototypes missing variable names Sent against staging-next. Signed-off-by: Bogdan Purcareata --- drivers/staging/android/ion/ion-ioctl.c | 3 ++- dri

Re: [PATCH] Staging: android: ion: fix coding style

2014-09-14 Thread Greg KH
First off, thanks for the patches. But, they need some tweaks before I can accept them. You sent a bunch of patches, all with the same exact subject, with no hint of which order they should be applied in, or what exactly they do. On Sat, Sep 13, 2014 at 04:46:10PM -0700, Sorin Facaoaru wrote: >

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- add line after declaration - remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 27036

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion_system_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_system_heap.c b/drivers/staging/android/ion/ion_system_heap.c index 6b77c51..da2a63

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- remove return statement in void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion_dummy_driver.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/android/ion/ion_dummy_driver.c index 3a45e79..ce606bd

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion_chunk_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_chunk_heap.c b/drivers/staging/android/ion/ion_chunk_heap.c index 9c3e49a..3e6ec2e 1

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion_carveout_heap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c index dcb6f21..

[PATCH] Staging: android: ion: fix coding style

2014-09-13 Thread Sorin Facaoaru
- add line after declaration - remove return statement in empty void function Signed-off-by: Sorin Facaoaru --- drivers/staging/android/ion/ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c index 270