Re: [PATCH] Staging: bcm: DDRInit: fixed issues w/ commenting.

2013-12-18 Thread GaryRookard
On Wed, 18 Dec 2013, Dan Carpenter wrote: Date: Wed, 18 Dec 2013 17:00:16 +0300 From: Dan Carpenter To: Gary Rookard Cc: de...@driverdev.osuosl.org, gre...@linuxfoundation.org, l...@xenapiadmin.com, j...@joshtriplett.org, nandu.hgo...@gmail.com Subject: Re: [PATCH] Staging: bcm: DDRInit

Re: [PATCH] Staging: bcm: DDRInit: fixed issues w/ commenting.

2013-12-18 Thread Dan Carpenter
Gary emailed me privately that fixing my comments would be a problem. 1) Greg complained about your earlier patch where you moved the comments from this: /* comment */ code(); To this: code(); /* comment */ Greg's complaint was not about that you were doing more than one

Re: [PATCH] Staging: bcm: DDRInit: fixed issues w/ commenting.

2013-12-17 Thread Dan Carpenter
On Tue, Dec 17, 2013 at 05:08:52PM -0500, Gary Rookard wrote: > -//DDR INIT-133Mhz > -#define T3_SKIP_CLOCK_PROGRAM_DUMP_133MHZ 12 //index for 0x0F007000 > -static struct bcm_ddr_setting asT3_DDRSetting133MHz[] = {// # DPLL > Clock Setting > +/* DDR INIT-133Mhz */ This is indented i

[PATCH] Staging: bcm: DDRInit: fixed issues w/ commenting.

2013-12-17 Thread Gary Rookard
removed C99 comments to follow the linux kernel coding style thus fixing checkpatch errors respectfully. Signed-off-by: Gary Alan Rookard --- On branch staging-next drivers/staging/bcm/DDRInit.c | 271 +- 1 file changed, 136 insertions(+), 135 deletions(-