Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-12 Thread Srishti Sharma
On Tue, Sep 12, 2017 at 2:49 PM, Dan Carpenter wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma >> --- >>

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-12 Thread Dan Carpenter
On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. > > Signed-off-by: Srishti Sharma > --- > drivers/staging/ccree/ssi_request_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Srishti Sharma
On Mon, Sep 11, 2017 at 9:45 PM, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall wrote: >> >> >> On Mon, 11 Sep 2017, Srishti Sharma wrote: >> >>> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: >>> >

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Srishti Sharma
On Mon, Sep 11, 2017 at 9:41 PM, Julia Lawall wrote: > > > On Mon, 11 Sep 2017, Srishti Sharma wrote: > >> On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: >> > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> >> The use of

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Julia Lawall
On Mon, 11 Sep 2017, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: > > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > >> The use of volatile for the variable monitor_lock is unnecessary. > >> > >> Signed-off-by: Srishti

Re: [Outreachy kernel] Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Sean Paul
On Mon, Sep 11, 2017 at 12:08 PM, Srishti Sharma wrote: > On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: >> On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >>> The use of volatile for the variable monitor_lock is unnecessary.

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Srishti Sharma
On Mon, Sep 11, 2017 at 9:34 PM, Greg KH wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma >> --- >>

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Greg KH
On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. > > Signed-off-by: Srishti Sharma > --- > drivers/staging/ccree/ssi_request_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [Outreachy kernel] [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Julia Lawall
On Mon, 11 Sep 2017, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. You need to give more evidence of why this is the case. How is the variable used? I guess this comes from checkpatch, but checkpatch has only a local view of things, and doesn't

[PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-11 Thread Srishti Sharma
The use of volatile for the variable monitor_lock is unnecessary. Signed-off-by: Srishti Sharma --- drivers/staging/ccree/ssi_request_mgr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ccree/ssi_request_mgr.c