Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

On 16/03/2018 10:48, Pratik Jain wrote: Fixed coding style issue. Signed-off-by: Pratik Jain --- drivers/staging/comedi/drivers/ni_atmio.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

On Fri, Mar 16, 2018 at 03:59:31PM +0530, Pratik Jain wrote: > Yes that can be done. But isn't 80 column limit more of a > historical convention? > No. It's not. We're not super strict about it but it's still a rule we apply unless it hurts readability. regards, dan carpenter

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Yes that can be done. But isn't 80 column limit more of a historical convention? On Fri, Mar 16, 2018 at 10:17:28AM +, Ian Abbott wrote: > On 15/03/2018 18:59, Pratik Jain wrote: > > Fixed coding style issue. > > > > Signed-off-by: Pratik Jain > > --- > >

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

On Fri, Mar 16, 2018 at 01:19:12AM +0530, Pratik Jain wrote: > Resending the email because it was sent only to Greg. > > Context: > In my previous patch, I had removed an extra newline > at the end of the code. > > My Reply: > It was unintentional, but does it violate any coding or > other

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Resending the email because it was sent only to Greg. Context: In my previous patch, I had removed an extra newline at the end of the code. My Reply: It was unintentional, but does it violate any coding or other standard? ___ devel mailing list

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain --- drivers/staging/comedi/drivers/ni_atmio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c index

Re: [PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

On Thu, Mar 15, 2018 at 11:00:40PM +0530, Pratik Jain wrote: > Fixed coding style issue. > > Signed-off-by: Pratik Jain > --- > drivers/staging/comedi/drivers/ni_atmio.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git

[PATCH] Staging: comedi: drivers: ni_atmio.c: fixed multi-line derefernce issue

Fixed coding style issue. Signed-off-by: Pratik Jain --- drivers/staging/comedi/drivers/ni_atmio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/staging/comedi/drivers/ni_atmio.c index