Re: [PATCH] Staging: greybus: Fix multiple checks for null pointers

2018-01-08 Thread Sumit Pundir
On Mon, Jan 8, 2018 at 8:15 PM, Johan Hovold wrote: > Since you're not really fixing anything here, besides silencing a > checkpatch suggestion when run with the --strict option (or on staging > code), I suggest you reword you commit summary (Subject) to, for > example: > >

Re: [PATCH] Staging: greybus: Fix multiple checks for null pointers

2018-01-08 Thread Johan Hovold
On Mon, Jan 08, 2018 at 11:28:13AM +0530, Sumit Pundir wrote: > Fixes the following coding style issue as noted by checkpatch.pl > at multiple lines: > > Comparison to NULL could be written "!token" > > Signed-off-by: Sumit Pundir Since you're not really fixing

[PATCH] Staging: greybus: Fix multiple checks for null pointers

2018-01-07 Thread Sumit Pundir
Fixes the following coding style issue as noted by checkpatch.pl at multiple lines: Comparison to NULL could be written "!token" Signed-off-by: Sumit Pundir --- drivers/staging/greybus/camera.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)