Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-28 Thread Johan Hovold
On Thu, Jul 27, 2017 at 09:49:32PM -0700, Greg KH wrote: > On Mon, Jul 24, 2017 at 10:08:37AM +0300, Dan Carpenter wrote: > > I don't understand why greybus has to be special instead of the same as > > everything else. Who cares about this stuff really? Just do whatever > > is easiest and most

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-27 Thread Greg KH
On Mon, Jul 24, 2017 at 10:08:37AM +0300, Dan Carpenter wrote: > I don't understand why greybus has to be special instead of the same as > everything else. Who cares about this stuff really? Just do whatever > is easiest and most common. It's not special, and --strict should apply here as long

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-27 Thread Greg KH
On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > Alignment should match with open parenthesis. > This fixes the coding style issue. > > Signed-off-by: Shreeya Patel > --- > drivers/staging/greybus/tools/loopback_test.c | 35 >

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-24 Thread Dan Carpenter
I don't understand why greybus has to be special instead of the same as everything else. Who cares about this stuff really? Just do whatever is easiest and most common. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-23 Thread Johan Hovold
On Sun, Jul 23, 2017 at 03:10:53PM +0300, Dan Carpenter wrote: > On Sun, Jul 23, 2017 at 10:47:43AM +0200, Johan Hovold wrote: > > On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > > > Alignment should match with open parenthesis. > > > This fixes the coding style issue. > > > >

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-23 Thread Dan Carpenter
On Sun, Jul 23, 2017 at 10:47:43AM +0200, Johan Hovold wrote: > On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > > Alignment should match with open parenthesis. > > This fixes the coding style issue. > > No, it need not. This is a choice left up to the author, even if > checkpatch

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-23 Thread Johan Hovold
On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > Alignment should match with open parenthesis. > This fixes the coding style issue. No, it need not. This is a choice left up to the author, even if checkpatch happens to complain about it with the --strict option. Thanks, Johan

[PATCH] Staging: greybus: Match alignment with open parenthesis.

2017-07-23 Thread Shreeya Patel
Alignment should match with open parenthesis. This fixes the coding style issue. Signed-off-by: Shreeya Patel --- drivers/staging/greybus/tools/loopback_test.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git