Re: [PATCH] Staging: iio: Prefer using BIT macro

2018-01-08 Thread Jonathan Cameron
On Mon, 8 Jan 2018 01:30:29 +0200 Andy Shevchenko wrote: > On Sat, Jan 6, 2018 at 2:42 PM, Jonathan Cameron wrote: > > On Thu, 4 Jan 2018 22:06:31 +0530 > > >> /* Setup Register Bit Designations (AD7152_REG_CHx_SETUP) */ > >> -#define

Re: [PATCH] Staging: iio: Prefer using BIT macro

2018-01-07 Thread Andy Shevchenko
On Sat, Jan 6, 2018 at 2:42 PM, Jonathan Cameron wrote: > On Thu, 4 Jan 2018 22:06:31 +0530 >> /* Setup Register Bit Designations (AD7152_REG_CHx_SETUP) */ >> -#define AD7152_SETUP_CAPDIFF (1 << 5) >> +#define AD7152_SETUP_CAPDIFF BIT(5) > > This is indeed a 1

Re: [PATCH] Staging: iio: Prefer using BIT macro

2018-01-06 Thread Sumit Pundir
On Sat, Jan 6, 2018 at 6:12 PM, Jonathan Cameron wrote: > On Thu, 4 Jan 2018 22:06:31 +0530 > Sumit Pundir wrote: > > Patch title needs to mention the specific driver being changed. > >> This patch fixes the following checkpatch.pl error at multiple

Re: [PATCH] Staging: iio: Prefer using BIT macro

2018-01-06 Thread Jonathan Cameron
On Thu, 4 Jan 2018 22:06:31 +0530 Sumit Pundir wrote: Patch title needs to mention the specific driver being changed. > This patch fixes the following checkpatch.pl error at multiple lines: > > CHECK: Prefer using the BIT macro > > Signed-off-by: Sumit Pundir

[PATCH] Staging: iio: Prefer using BIT macro

2018-01-04 Thread Sumit Pundir
This patch fixes the following checkpatch.pl error at multiple lines: CHECK: Prefer using the BIT macro Signed-off-by: Sumit Pundir --- drivers/staging/iio/cdc/ad7152.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git