Re: [PATCH] Staging: olpc_dcon: Use WARN_ON() instead of BUG_ON()

2019-04-16 Thread Greg KH
On Fri, Apr 05, 2019 at 02:28:36PM -0500, Madhumitha Prabakaran wrote: > Use WARN_ON() instead of BUG_ON(), as the WARN_ON() produces a backtrace > without crashing the kernel. > > Issue found by checkpatch.pl. > > Signed-off-by: Madhumitha Prabakaran > --- >

[PATCH] Staging: olpc_dcon: Use WARN_ON() instead of BUG_ON()

2019-04-05 Thread Madhumitha Prabakaran
Use WARN_ON() instead of BUG_ON(), as the WARN_ON() produces a backtrace without crashing the kernel. Issue found by checkpatch.pl. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC/PATCH] staging: olpc_dcon: Use WARN_ON instead of BUG_ON

2019-03-24 Thread Greg KH
On Sun, Mar 24, 2019 at 05:42:08PM +0530, Bharath Vedartham wrote: > This is with respect to a checkpatch.pl CHECK: "Avoid crashing the > kernel. Use WARN_ON instead of BUG_ON". But I maybe wrong here. Is a > kernel crash desired if olpc_board_at_least(olpc_board(0xc2)) fails, > will there be

[RFC/PATCH] staging: olpc_dcon: Use WARN_ON instead of BUG_ON

2019-03-24 Thread Bharath Vedartham
This is with respect to a checkpatch.pl CHECK: "Avoid crashing the kernel. Use WARN_ON instead of BUG_ON". But I maybe wrong here. Is a kernel crash desired if olpc_board_at_least(olpc_board(0xc2)) fails, will there be inconsistent results if execution continues? Signed-off-by: Bharath Vedartham