Re: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation

2015-04-07 Thread Dan Carpenter
Some people like to put parenthesis around stuff. It's harmless here. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation

2015-04-06 Thread Sudip Mukherjee
On Sun, Apr 05, 2015 at 07:11:47AM +0530, Amitoj Kaur Chawla wrote: > Removes extra parentheses around bitwise right shift operation. this is not applying. please work against staging-testing. regards sudip > ___ devel mailing list de...@linuxdriverproj

[PATCH] Staging: sm750fb: Remove extra parentheses around right bit shift operation

2015-04-04 Thread Amitoj Kaur Chawla
Removes extra parentheses around bitwise right shift operation. The issue was detected using the following coccinelle script. @@ expression e, e1; constant c; @@ e = -(e1 +e1 << -c); +c; @@ identifier i; constant c; type t; expression e; @@ t i = -(e +e << -c); +c; @@ expression e, e1; identif