Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-12 Thread Sudip Mukherjee
On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote: > On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: > > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: > > > This patch does the following: > > > * changed the complicated if statements to simple case

Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-12 Thread Saurabh Sengar
On 12 December 2015 at 15:41, Sudip Mukherjee wrote: > On Sat, Dec 12, 2015 at 11:40:25AM +0300, Dan Carpenter wrote: >> On Wed, Dec 09, 2015 at 10:47:18AM +0530, Sudip Mukherjee wrote: >> > On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: >> > > This

Re: [PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-08 Thread Sudip Mukherjee
On Mon, Dec 07, 2015 at 06:35:11PM +0530, Saurabh Sengar wrote: > This patch does the following: > * changed the complicated if statements to simple case statements > * in case of E_DEFAULT, no need to return error as ERESTART, > because this is the user asked for. Hence function should return

[PATCH] Staging: speakup: varhandlers: cleanup of function spk_get_punc_var

2015-12-07 Thread Saurabh Sengar
This patch does the following: * changed the complicated if statements to simple case statements * in case of E_DEFAULT, no need to return error as ERESTART, because this is the user asked for. Hence function should return success. * ret variable is 0 always, hence removed it. * removed one