Re: [PATCH] android: binder: fix type mismatch warning

2017-09-22 Thread Martijn Coenen
On Fri, Sep 22, 2017 at 11:12 AM, Arnd Bergmann wrote: > How would waiting help? Once P drops support for v7, all P userspaces (including containerized ones) need to be v8. After a while, the number of non-Android userspaces < P with v7 would become practically zero. But it's

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-22 Thread Arnd Bergmann
On Fri, Sep 22, 2017 at 9:00 AM, Martijn Coenen wrote: >> The case that gets interesting is a any kind of user that wants to >> run an Android application on a regular Linux box without >> using virtual machines or emulation, e.g. a an app developer, >> or a user that wants to

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-22 Thread Martijn Coenen
On Wed, Sep 20, 2017 at 3:37 PM, Arnd Bergmann wrote: > I'm not really worried about shipping Android products, for those > there is no big problem using the compile-time option as they build > everything together. Ack. > The case that gets interesting is a any kind of user that

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-21 Thread Greg Kroah-Hartman
On Wed, Sep 20, 2017 at 01:37:45PM +, Arnd Bergmann wrote: > On Wed, Sep 20, 2017 at 12:24 PM, Martijn Coenen wrote: > > On Wed, Sep 20, 2017 at 11:58 AM, Arnd Bergmann wrote: > >> > >> - Since you say there are existing users of recent 32-bit Android > >>

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-20 Thread Arnd Bergmann
On Wed, Sep 20, 2017 at 12:24 PM, Martijn Coenen wrote: > On Wed, Sep 20, 2017 at 11:58 AM, Arnd Bergmann wrote: >> >> - Since you say there are existing users of recent 32-bit Android >> including Oreo, I also think that removing support for the v7 ABI >> is

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-20 Thread Martijn Coenen
On Wed, Sep 20, 2017 at 11:58 AM, Arnd Bergmann wrote: > - On stable mainline kernels (unlike android-common), the v8 > interface has never been available as a build option, and making > it user-selectable will required additional patches to make it > actually build on 32-bit

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-20 Thread Arnd Bergmann
On Wed, Sep 20, 2017 at 11:08 AM, Martijn Coenen wrote: > On Mon, Sep 18, 2017 at 9:49 PM, Arnd Bergmann wrote: >> The current Kconfig comment says that v7 of the ABI is also >> incompatible with Android 4.5 and later user space. Can someone >> confirm that? > >

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-20 Thread Martijn Coenen
On Mon, Sep 18, 2017 at 9:49 PM, Arnd Bergmann wrote: > The current Kconfig comment says that v7 of the ABI is also > incompatible with Android 4.5 and later user space. Can someone > confirm that? That is not actually true - v7 does work with all versions of Android (up to and

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Arnd Bergmann
On Mon, Sep 18, 2017 at 6:23 PM, Christoph Hellwig wrote: > On Mon, Sep 18, 2017 at 05:53:47PM +0200, Greg Kroah-Hartman wrote: >> > It seems like a legitimate use case of the binder modules, but >> > now there is a kernel Kconfig option that has to match a user >> > space

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Greg Kroah-Hartman
On Mon, Sep 18, 2017 at 09:23:03AM -0700, Christoph Hellwig wrote: > On Mon, Sep 18, 2017 at 05:53:47PM +0200, Greg Kroah-Hartman wrote: > > > It seems like a legitimate use case of the binder modules, but > > > now there is a kernel Kconfig option that has to match a user > > > space binary. > >

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Christoph Hellwig
On Mon, Sep 18, 2017 at 05:53:47PM +0200, Greg Kroah-Hartman wrote: > > It seems like a legitimate use case of the binder modules, but > > now there is a kernel Kconfig option that has to match a user > > space binary. > > So, should we revert that? > > I don't really know what to suggest here,

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Greg Kroah-Hartman
On Mon, Sep 18, 2017 at 05:35:03PM +0200, Arnd Bergmann wrote: > On Mon, Sep 18, 2017 at 4:02 PM, Greg Kroah-Hartman > wrote: > >> However, there is another problem with the Kconfig option: turning > >> it on or off creates two incompatible ABI versions, a kernel that

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Christoph Hellwig
On Mon, Sep 18, 2017 at 05:35:03PM +0200, Arnd Bergmann wrote: > Probably not on a native Android device or even a Chromebook that > ships a binder user space together with a kernel, but what about > people using "anbox" or similar projects that allow you to run > Android apps in a container? > >

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Arnd Bergmann
On Mon, Sep 18, 2017 at 4:02 PM, Greg Kroah-Hartman wrote: >> However, there is another problem with the Kconfig option: turning >> it on or off creates two incompatible ABI versions, a kernel that >> has this enabled cannot run user space that was built without it >>

Re: [PATCH] android: binder: fix type mismatch warning

2017-09-18 Thread Greg Kroah-Hartman
On Tue, Sep 05, 2017 at 10:56:13AM +0200, Arnd Bergmann wrote: > Allowing binder to expose the 64-bit API on 32-bit kernels caused a > build warning: > > drivers/android/binder.c: In function 'binder_transaction_buffer_release': > drivers/android/binder.c:2220:15: error: cast to pointer from

[PATCH] android: binder: fix type mismatch warning

2017-09-05 Thread Arnd Bergmann
Allowing binder to expose the 64-bit API on 32-bit kernels caused a build warning: drivers/android/binder.c: In function 'binder_transaction_buffer_release': drivers/android/binder.c:2220:15: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] fd_array = (u32