Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

2015-11-01 Thread Andy Shevchenko
On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote: > BIT macro is used for defining bit location instead of shifting > operator - coding style issue > #define APCI1032_CTRL_INT_OR (0 << 1) > +#define APCI1032_CTRL_INT_AND BIT(1) And now you have two

[PATCH] comedi: drivers: Fix - BIT macro used coding style issue

2015-11-01 Thread Ranjith
BIT macro is used for defining bit location instead of shifting operator - coding style issue Signed-off-by: Ranjith T --- drivers/staging/comedi/drivers/addi_apci_1032.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

2015-11-01 Thread Greg Kroah-Hartman
On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote: > On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote: > > BIT macro is used for defining bit location instead of shifting > > operator - coding style issue > > > #define APCI1032_CTRL_INT_OR (0 << 1)

Re: [PATCH] comedi: drivers: Fix - BIT macro used coding style issue

2015-11-01 Thread Greg Kroah-Hartman
On Sun, Nov 01, 2015 at 10:10:59AM -0800, Greg Kroah-Hartman wrote: > On Sun, Nov 01, 2015 at 12:20:59PM +0200, Andy Shevchenko wrote: > > On Sun, Nov 1, 2015 at 11:59 AM, Ranjith wrote: > > > BIT macro is used for defining bit location instead of shifting > > > operator -