Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-15 Thread Greg KH
On Sat, Jan 14, 2017 at 10:53:04PM +0300, Ivan Safonov wrote: > On 01/14/2017 10:40 PM, Greg KH wrote: > > On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote: > > Even better yet, remove it and rebuild the driver and see if it > > breaks :) > > Only if the code is not between #ifn?def

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-15 Thread Greg KH
On Sun, Jan 15, 2017 at 01:08:15AM +0530, Kartikey Singh wrote: > On Sat, Jan 14, 2017 at 07:38:01PM +0100, Greg KH wrote: > > On Sat, Jan 14, 2017 at 11:53:36PM +0530, Kartikey Singh wrote: > > > do while loop removed from single statement macro > > > > > > Signed-off-by: Kartikey Singh

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Ivan Safonov
On 01/14/2017 10:40 PM, Greg KH wrote: On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote: Even better yet, remove it and rebuild the driver and see if it breaks :) Only if the code is not between #ifn?def / #endif... ___ devel mailing

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Kartikey Singh
On Sat, Jan 14, 2017 at 07:38:01PM +0100, Greg KH wrote: > On Sat, Jan 14, 2017 at 11:53:36PM +0530, Kartikey Singh wrote: > > do while loop removed from single statement macro > > > > Signed-off-by: Kartikey Singh > > --- > > drivers/staging/rtl8188eu/include/wifi.h |

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Greg KH
On Sun, Jan 15, 2017 at 12:44:41AM +0530, Kartikey singh wrote: > I think that macro is required. Anyway I won't have trouble cleaning it up if > you say so. I don't see it being used anywhere, do you? Use 'git grep' to search for it. Even better yet, remove it and rebuild the driver and see if

Re: [PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Greg KH
On Sat, Jan 14, 2017 at 11:53:36PM +0530, Kartikey Singh wrote: > do while loop removed from single statement macro > > Signed-off-by: Kartikey Singh > --- > drivers/staging/rtl8188eu/include/wifi.h | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff

[PATCH] drivers: staging: rtl8188eu: include: wifi: Unnecessary do-while removed from macro

2017-01-14 Thread Kartikey Singh
do while loop removed from single statement macro Signed-off-by: Kartikey Singh --- drivers/staging/rtl8188eu/include/wifi.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h