On Tue, Mar 14, 2017 at 03:01:50AM -0700, Pushkar Jambhlekar wrote:
> Hi Dan,
>
> I am trying to fix warnings by "checkpatch.pl". Even though it is not
> super exciting, no harm to follow correct way.
>
The harm is that it takes something that's already terrible and makes it
even more unreadable
Hi Dan,
I am trying to fix warnings by "checkpatch.pl". Even though it is not
super exciting, no harm to follow correct way.
On Tue, Mar 14, 2017 at 2:43 AM, Dan Carpenter wrote:
> On Tue, Mar 14, 2017 at 11:12:42AM +0530, Pushkar Jambhlekar wrote:
>> Description:
>> In driver module ks7010, "ch
On Tue, Mar 14, 2017 at 11:12:42AM +0530, Pushkar Jambhlekar wrote:
> Description:
> In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis
> around macro params.
> Also, removing extra line.
Don't do this as one patch.
>
> Signed-off-by: Pushkar Jambhlekar
> ---
> driver
Description:
In driver module ks7010, "checkpatch.pl" flags error for adding parenthesis
around macro params.
Also, removing extra line.
Signed-off-by: Pushkar Jambhlekar
---
drivers/staging/ks7010/ks7010_sdio.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/d