Re: [PATCH] media: atomisp: remove redundant NULL check

2021-01-22 Thread Robert Foss
Thanks for the patch. Feel free to add my r-b: Reviewed-by: Robert Foss On Thu, 21 Jan 2021 at 09:31, Yang Li wrote: > > Fix below warnings reported by coccicheck: > ./drivers/staging/media/atomisp/pci/sh_css_params.c:1575:2-8: WARNING: > NULL check before some freeing functions is not needed.

[PATCH] media: atomisp: remove redundant NULL check

2021-01-21 Thread Yang Li
Fix below warnings reported by coccicheck: ./drivers/staging/media/atomisp/pci/sh_css_params.c:1575:2-8: WARNING: NULL check before some freeing functions is not needed. ./drivers/staging/media/atomisp/pci/sh_css_params.c:3006:2-8: WARNING: NULL check before some freeing functions is not needed.

[PATCH] media: atomisp: Remove redundant NULL check

2020-12-25 Thread Xu Wang
Fix warnings reported by coccicheck: ./drivers/staging/media/atomisp/pci/runtime/isp_param/src/isp_param.c:159:4-10: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Xu Wang --- .../media/atomisp/pci/runtime/isp_param/src/isp_param.c| 3 +-- 1 file

[PATCH] media: atomisp: Remove redundant NULL check

2020-12-25 Thread Xu Wang
./drivers/staging/media/atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c:390:2-8: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Xu Wang --- .../atomisp/pci/isp/kernels/sdis/sdis_1.0/ia_css_sdis.host.c | 3 +-- 1 file changed, 1 insertion(+), 2

[PATCH] media: atomisp: remove redundant NULL check of "params"

2020-11-17 Thread Ding Xiang
The check result of (!A || (A && B)) is equivalent to (!A || B), so remove redundant NULL check of "params" Signed-off-by: Ding Xiang --- drivers/staging/media/atomisp/pci/sh_css_params.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git