Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

2019-07-15 Thread Bharath Vedartham
On Mon, Jul 15, 2019 at 11:10:20AM -0700, John Hubbard wrote: > On 7/14/19 11:56 PM, Bharath Vedartham wrote: > > On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote: > >> On 7/14/19 12:08 PM, Bharath Vedartham wrote: > [...] > >> 1. Pull down https://github.com/johnhubbard/linux/commits/g

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

2019-07-15 Thread Bharath Vedartham
On Mon, Jul 15, 2019 at 09:29:53AM -0700, Ira Weiny wrote: > On Mon, Jul 15, 2019 at 12:26:54PM +0530, Bharath Vedartham wrote: > > On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote: > > > On 7/14/19 12:08 PM, Bharath Vedartham wrote: > > > > This patch converts all call sites of get_use

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

2019-07-15 Thread John Hubbard
On 7/14/19 11:56 PM, Bharath Vedartham wrote: > On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote: >> On 7/14/19 12:08 PM, Bharath Vedartham wrote: [...] >> 1. Pull down https://github.com/johnhubbard/linux/commits/gup_dma_core >> and find missing conversions: look for any additional mis

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

2019-07-15 Thread Ira Weiny
On Mon, Jul 15, 2019 at 12:26:54PM +0530, Bharath Vedartham wrote: > On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote: > > On 7/14/19 12:08 PM, Bharath Vedartham wrote: > > > This patch converts all call sites of get_user_pages > > > to use put_user_page*() instead of put_page*() functi

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

2019-07-15 Thread Bharath Vedartham
On Sun, Jul 14, 2019 at 08:33:57PM -0600, Jens Axboe wrote: > On 7/14/19 1:08 PM, Bharath Vedartham wrote: > > diff --git a/fs/io_uring.c b/fs/io_uring.c > > index 4ef62a4..b4a4549 100644 > > --- a/fs/io_uring.c > > +++ b/fs/io_uring.c > > @@ -2694,10 +2694,9 @@ static int io_sqe_buffer_register(st

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

2019-07-14 Thread Bharath Vedartham
On Sun, Jul 14, 2019 at 04:33:42PM -0700, John Hubbard wrote: > On 7/14/19 12:08 PM, Bharath Vedartham wrote: > > This patch converts all call sites of get_user_pages > > to use put_user_page*() instead of put_page*() functions to > > release reference to gup pinned pages. Hi John, > Hi Bharath, >

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

2019-07-14 Thread Jens Axboe
On 7/14/19 1:08 PM, Bharath Vedartham wrote: > diff --git a/fs/io_uring.c b/fs/io_uring.c > index 4ef62a4..b4a4549 100644 > --- a/fs/io_uring.c > +++ b/fs/io_uring.c > @@ -2694,10 +2694,9 @@ static int io_sqe_buffer_register(struct io_ring_ctx > *ctx, void __user *arg, >* i

Re: [PATCH] mm/gup: Use put_user_page*() instead of put_page*()

2019-07-14 Thread John Hubbard
On 7/14/19 12:08 PM, Bharath Vedartham wrote: > This patch converts all call sites of get_user_pages > to use put_user_page*() instead of put_page*() functions to > release reference to gup pinned pages. Hi Bharath, Thanks for jumping in to help, and welcome to the party! You've caught everyone

[PATCH] mm/gup: Use put_user_page*() instead of put_page*()

2019-07-14 Thread Bharath Vedartham
This patch converts all call sites of get_user_pages to use put_user_page*() instead of put_page*() functions to release reference to gup pinned pages. This is a bunch of trivial conversions which is a part of an effort by John Hubbard to solve issues with gup pinned pages and filesystem writebac