Re: [PATCH] rtl8723bs/ioctl_linux: Add a security check to copy_from_user()

2019-01-02 Thread Dan Carpenter
On Sun, Dec 23, 2018 at 06:13:02PM -0600, Aditya Pakki wrote: > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c > b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c > index b8631baf128d..9992caa8c839 100644 > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c > +++

[PATCH] rtl8723bs/ioctl_linux: Add a security check to copy_from_user()

2018-12-23 Thread Aditya Pakki
Currently, the return value of copy_from_user is not checked. extra is assigned to u32wps_start irrespective of these failures. Signed-off-by: Aditya Pakki --- drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git